SecurePoll: namespace not updated when election edited while election is running
Closed, ResolvedPublic3 Estimated Story PointsBUG REPORT
Actions

Assigned To

Authored By

	dom_walden
	Mar 8 2021, 5:25 PM

Description

What is the problem?

When creating an election, the election's config is recorded in a page (e.g. https://vote.wikimedia.beta.wmflabs.org/wiki/SecurePoll:154). This page is not updated when the election is edited while the election is running.

It is updated if I edit the election before it starts.

Steps to reproduce problem

Go to https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/create
Create a new election, setting the start date to today
Find the election's $id and go to https://vote.wikimedia.beta.wmflabs.org/wiki/SecurePoll:$id
Edit the election, change the Return-to URL and/or the Admins

Expected behavior: The edits made in step 4 should be reflected in https://vote.wikimedia.beta.wmflabs.org/wiki/SecurePoll:$id
Observed behavior: The namespace remains the same as after the election was first created (in step 3)

Details

	Subject	Repo	Branch	Lines +/-
	Write changes to namespace when editing running polls	mediawiki/extensions/SecurePoll	master	+14 -4

Customize query in gerrit

Related Objects

Mentioned In: T273025: SecurePoll: Allow editing some of the election config post election-start
Mentioned Here: rESPO83d545c20618: Localisation updates from https://translatewiki.net.

Event Timeline

dom_walden created this task.Mar 8 2021, 5:25 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 8 2021, 5:25 PM

dom_walden mentioned this in T273025: SecurePoll: Allow editing some of the election config post election-start.Mar 8 2021, 5:25 PM

Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment board.Mar 9 2021, 3:33 PM

Change 674567 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Write changes to namespace when editing running polls

https://gerrit.wikimedia.org/r/674567

gerritbot added a project: Patch-For-Review.Mar 24 2021, 11:30 AM

STran claimed this task.Mar 24 2021, 11:34 AM

STran moved this task from Triage/To be Estimated to The Letter Song on the Anti-Harassment board.Mar 24 2021, 11:44 AM

STran edited projects, added Anti-Harassment (The Letter Song); removed Anti-Harassment.

STran moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment (The Letter Song) board.

STran moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment (The Letter Song) board.Mar 24 2021, 11:51 AM

STran set the point value for this task to 2.Mar 24 2021, 4:43 PM

STran changed the point value for this task from 2 to 3.

Change 674567 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Write changes to namespace when editing running polls

https://gerrit.wikimedia.org/r/674567

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 25 2021, 6:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 25 2021, 6:10 PM

Tchanders moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment (The Letter Song) board.Mar 26 2021, 2:31 PM

I cannot reproduce the bug in the description. The respective SecurePoll:$id page gets updated.

I also retested editing an election before it has started and making sure the SecurePoll:$id and SecurePoll:$id/msg/$lang gets updated, in case of regression.

Test environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (83d545c) 06:33, 30 March 2021.

Tchanders closed this task as Resolved.Mar 31 2021, 10:28 AM

SecurePoll: namespace not updated when election edited while election is runningClosed, ResolvedPublic3 Estimated Story PointsBUG REPORTActions