Review test coverage for add link feature
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	kostajh
	Mar 8 2021, 8:24 PM

Description

We've been avoiding writing a lot of tests but as development stabilizes, it would be useful to add in some tests to protect against regression tests.

We can use this task to make a more specific list of areas we'd like coverage for – end-to-end testing on the frontend, integration tests, unit tests, etc.

QUnit

T285651: Add Qunit tests for AddLinkArticleTarget.prototype.annotateSuggestions

PHPUnit

unit tests

shared class factored out of refreshLinkRecommendations.php in T284551: Maintenance script for updating recommendations to newer dataset
Unit tests for HomepageHooks::onSearchDataForIndex ?

integration tests

e2e

T284611: Selenium tests for add link feature

Related Objects
Search...

Status	Assigned	Task
Open	KStoller-WMF	T276517 [EPIC] Growth: "add a link" structured task 3.0
Resolved	kostajh	T276860 Review test coverage for add link feature
Resolved	kostajh	T284611 Selenium tests for add link feature
Resolved	kostajh	T285651 Add Qunit tests for AddLinkArticleTarget.prototype.annotateSuggestions

Event Timeline

kostajh created this task.Mar 8 2021, 8:24 PM

Restricted Application added a project: Growth-Team. · View Herald TranscriptMar 8 2021, 8:24 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

kostajh added a subscriber: Etonkovidova.Mar 8 2021, 8:26 PM

One thing I'd like to cover especially well is refreshLinkRecommendations.php. It's very hard to test manually, it has lots of code paths, and it will be hard to diagnose what's going on if it breaks. (Related: T276795: Monitoring for GrowthExperiments link recommendation task pool)

kostajh moved this task from Backlog to Post-release backlog on the Add-Link board.Mar 29 2021, 11:34 AM

MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM

kostajh triaged this task as Low priority.Apr 26 2021, 7:53 PM

kostajh raised the priority of this task from Low to Medium.May 12 2021, 12:14 PM

kostajh updated the task description. (Show Details)

kostajh added a parent task: T276517: [EPIC] Growth: "add a link" structured task 3.0.

• Rileych edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Jun 4 2021, 9:11 PM

• Rileych moved this task from Incoming to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.

kostajh moved this task from Post-release backlog to Backlog on the Add-Link board.Jun 7 2021, 7:26 AM

MMiller_WMF raised the priority of this task from Medium to High.Jun 7 2021, 5:11 PM

kostajh updated the task description. (Show Details)Jun 8 2021, 3:00 PM

In T276860#6894073, @Tgr wrote:

One thing I'd like to cover especially well is refreshLinkRecommendations.php. It's very hard to test manually, it has lots of code paths, and it will be hard to diagnose what's going on if it breaks. (Related: T276795: Monitoring for GrowthExperiments link recommendation task pool)

I think we could cover that in part by the proposed refactoring in T284551: Maintenance script for updating recommendations to newer dataset, and adding unit tests for the shared class.

kostajh lowered the priority of this task from High to Medium.Jun 28 2021, 10:34 AM

kostajh updated the task description. (Show Details)

Moving to "Code review" mainly to get consensus / input from other engineers if there's anything else want to spend time writing tests for. If so, please update the task description.

@mewoph @Tgr -- please check this out and add comments if you wish!

In T276860#7288442, @MMiller_WMF wrote:

@mewoph @Tgr -- please check this out and add comments if you wish!

I'm marking this as resolved – @Tgr @mewoph if you want to file more tasks for test coverage, please do :)

kostajh changed the status of subtask T284611: Selenium tests for add link feature from Open to Stalled.Sep 13 2021, 10:15 AM

kostajh closed subtask T285651: Add Qunit tests for AddLinkArticleTarget.prototype.annotateSuggestions as Resolved.Oct 7 2021, 7:08 PM

kostajh changed the status of subtask T284611: Selenium tests for add link feature from Stalled to Open.Jan 5 2022, 11:36 AM

Urbanecm_WMF changed the status of subtask T284611: Selenium tests for add link feature from Open to In Progress.Jan 31 2022, 11:34 AM

Urbanecm_WMF removed a project: Growth-Team-Filtering.Feb 5 2022, 4:51 PM

kostajh closed subtask T284611: Selenium tests for add link feature as Resolved.Apr 8 2022, 8:34 PM

Review test coverage for add link featureClosed, ResolvedPublicActions