As part of T273044: Convert SecurePoll VotePage to use OOUI, this included ballot will need to return an OOUI object. You should check the getForm and getQuestionForm functions. VotePage.php calls getForm which calls getQuestionForm.
Description
Description
Details
Details
Related Changes in Gerrit:
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Update ApprovalBallot.php to OOUI | mediawiki/extensions/SecurePoll | master | +16 -12 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T49145 Formally deprecate jQuery UI after we've stopped using jQuery UI in extensions and core | |||
| Open | None | T100270 Replace use of jQuery UI and MW UI with OOUI across all Wikimedia-deployed extensions and core | |||
| Open | None | T208687 Convert SecurePoll to use OOUI | |||
| Resolved | • wikitrent | T273044 Convert SecurePoll VotePage to use OOUI | |||
| Resolved | • wikitrent | T276901 Convert ApprovalBallot to use OOUI |
Event Timeline
Comment Actions
Change 672726 had a related patch set uploaded (by Wikitrent; owner: Wikitrent):
[mediawiki/extensions/SecurePoll@master] WIP: Update ApprovalBallot.php to OOUI
Comment Actions
Change 672726 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Update ApprovalBallot.php to OOUI
Comment Actions
For an election of type "Approval vote", I tested submitting votes and checking the votes were recorded correctly in the database.
I inspected the HTML of the voting form, compared to how it used to be. The checkbox <input>s name and value attributes are unaffected, so we should not have affected how votes are recorded.
I also checked that the <label> corresponds to the correct <input> (even when the questions/options are randomised), so users are voting for the right thing.
I tested voting without JS as well.
Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (97412a0) 07:26, 19 March 2021.