As part of T273044: Convert SecurePoll VotePage to use OOUI, this included ballot will need to return an OOUI object. You should check the getForm and getQuestionForm functions. VotePage.php calls getForm which calls getQuestionForm.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Use OOUI in PreferentialBallot | mediawiki/extensions/SecurePoll | master | +33 -21 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | Goal | None | T122014 Convert all extensions/skins to OOUI | ||
| Open | None | T208687 Convert SecurePoll to use OOUI | |||
| Resolved | • wikitrent | T273044 Convert SecurePoll VotePage to use OOUI | |||
| Resolved | STran | T276903 Convert PreferentialBallot to use OOUI |
Event Timeline
Comment Actions
Change 674550 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Use OOUI in PreferentialBallot
Comment Actions
Change 674550 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Use OOUI in PreferentialBallot
Comment Actions
I checked that I can submit a Schulze ballot and the vote is correctly recorded in the database.
I notice the validation messages are different. So far, I haven't noticed any difference in what the validation will allow/not allow. It expects an integer between 1 and 999, and it allows the same rank to be repeated across options (same as before this change).
For example, before this change, when trying to submit without all required questions answered:
After this change:
Before this change when entering an invalid answer:
After this change:
Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (69d5f55b) 07:38, 1 April 2021