Page MenuHomePhabricator

Convert PreferentialBallot to use OOUI
Closed, ResolvedPublic3 Estimated Story Points

Description

As part of T273044: Convert SecurePoll VotePage to use OOUI, this included ballot will need to return an OOUI object. You should check the getForm and getQuestionForm functions. VotePage.php calls getForm which calls getQuestionForm.

Event Timeline

Change 674550 had a related patch set uploaded (by STran; owner: STran):
[mediawiki/extensions/SecurePoll@master] Use OOUI in PreferentialBallot

https://gerrit.wikimedia.org/r/674550

Niharika set the point value for this task to 3.Mar 24 2021, 4:49 PM

Change 674550 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Use OOUI in PreferentialBallot

https://gerrit.wikimedia.org/r/674550

dom_walden added a subscriber: dom_walden.

I checked that I can submit a Schulze ballot and the vote is correctly recorded in the database.

I notice the validation messages are different. So far, I haven't noticed any difference in what the validation will allow/not allow. It expects an integer between 1 and 999, and it allows the same rank to be repeated across options (same as before this change).

For example, before this change, when trying to submit without all required questions answered:

before_required.png (655×902 px, 69 KB)

After this change:

after_required.png (496×644 px, 25 KB)

Before this change when entering an invalid answer:

before_invalid_answer.png (547×752 px, 33 KB)

After this change:

after_invalid_answer.png (499×624 px, 25 KB)

Test Environment: https://vote.wikimedia.beta.wmflabs.org SecurePoll 2.0.0 (69d5f55b) 07:38, 1 April 2021