Page MenuHomePhabricator
Create Task
Maniphest T276936

Improve wrapping of page contents delivered using MassMessage
Closed, ResolvedPublic
Actions

Description

Per parent task, we have identified new requirements to avoid regressions in the new workflow:

  • Keep the section tag wrapping, if delivering a section
  • Wrap the content in appropriate dir and lang attributes to ensure correct rendering in case page content differs from target page language

Details

SubjectRepoBranchLines +/-
MassMessage: Unbreak remote content fetchingmediawiki/extensions/MassMessagewmf/1.36.0-wmf.35+53 -6
MassMessage: Unbreak remote content fetchingmediawiki/extensions/MassMessagewmf/1.36.0-wmf.36+53 -6
MassMessage: Unbreak remote content fetchingmediawiki/extensions/MassMessagemaster+53 -6
Wrap page contents with lang and dir attributesmediawiki/extensions/MassMessagemaster+173 -59
Include section wrapping when delivering a sectionmediawiki/extensions/MassMessagemaster+12 -7
Customize query in gerrit

Related Objects
Search...

Event Timeline

Nikerabbit created this task.Mar 9 2021, 2:42 PM
Nikerabbit moved this task from Quarter Backlog to In Progress on the Language-Team (Language-2021-January-March) board.
gerritbot added a comment.Mar 11 2021, 12:42 PM

Change 670811 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/MassMessage@master] Include section wrapping when delivering a section

https://gerrit.wikimedia.org/r/670811

gerritbot added a project: Patch-For-Review.Mar 11 2021, 12:42 PM

Change 670812 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/MassMessage@master] Wrap page contents with lang and dir attributes

https://gerrit.wikimedia.org/r/670812

Nikerabbit triaged this task as Medium priority.Mar 11 2021, 12:42 PM
Nikerabbit moved this task from In Progress to In Review on the Language-Team (Language-2021-January-March) board.

Inherit priority from parent task.

gerritbot added a comment.Mar 12 2021, 1:29 PM

Change 670811 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Include section wrapping when delivering a section

https://gerrit.wikimedia.org/r/670811

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 12 2021, 2:00 PM
gerritbot added a comment.Mar 15 2021, 1:27 PM

Change 670812 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] Wrap page contents with lang and dir attributes

https://gerrit.wikimedia.org/r/670812

Nikerabbit removed a project: Patch-For-Review.Mar 15 2021, 2:05 PM
Nikerabbit moved this task from In Review to Recheck after deployment on the Language-Team (Language-2021-January-March) board.
gerritbot added a comment.Mar 23 2021, 7:52 AM

Change 674253 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/MassMessage@master] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674253

gerritbot added a project: Patch-For-Review.Mar 23 2021, 7:52 AM
gerritbot added a comment.Mar 23 2021, 1:43 PM

Change 674253 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@master] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674253

Maintenance_bot removed a project: Patch-For-Review.Mar 23 2021, 2:10 PM
gerritbot added a comment.Mar 23 2021, 2:48 PM

Change 674366 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/MassMessage@wmf/1.36.0-wmf.36] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674366

gerritbot added a project: Patch-For-Review.Mar 23 2021, 2:48 PM

Change 674367 had a related patch set uploaded (by Nikerabbit; owner: Nikerabbit):
[mediawiki/extensions/MassMessage@wmf/1.36.0-wmf.35] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674367

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.37; 2021-03-30); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 23 2021, 4:00 PM
gerritbot added a comment.Mar 24 2021, 11:36 AM

Change 674366 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@wmf/1.36.0-wmf.36] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674366

gerritbot added a comment.Mar 24 2021, 11:37 AM

Change 674367 merged by jenkins-bot:
[mediawiki/extensions/MassMessage@wmf/1.36.0-wmf.35] MassMessage: Unbreak remote content fetching

https://gerrit.wikimedia.org/r/674367

Stashbot added a comment.Mar 24 2021, 11:45 AM

Mentioned in SAL (#wikimedia-operations) [2021-03-24T11:45:11Z] <andrew-wmde@deploy1002> Synchronized php-1.36.0-wmf.36/extensions/MassMessage/: Backport: [[gerrit:674366|MassMessage: Unbreak remote content fetching (T276936)]] (duration: 01m 07s)

Stashbot added a comment.Mar 24 2021, 11:51 AM

Mentioned in SAL (#wikimedia-operations) [2021-03-24T11:51:09Z] <andrew-wmde@deploy1002> Synchronized php-1.36.0-wmf.35/extensions/MassMessage/: Backport: [[gerrit:674367|MassMessage: Unbreak remote content fetching (T276936)]] (duration: 01m 08s)

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.37; 2021-03-30).Mar 24 2021, 12:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 24 2021, 12:11 PM
Pginer-WMF edited projects, added Language-Team (Language-2021-April-June); removed Language-Team (Language-2021-January-March).Apr 1 2021, 11:17 AM
Pginer-WMF moved this task from Quarter Backlog to Recheck after deployment on the Language-Team (Language-2021-April-June) board.
Nikerabbit moved this task from Recheck after deployment to Done on the Language-Team (Language-2021-April-June) board.Apr 14 2021, 8:19 AM
Nikerabbit closed this task as Resolved.Apr 28 2021, 4:13 PM
Trizek-WMF awarded a token.Apr 28 2021, 4:14 PM
Dreamy_Jazz mentioned this in T70512: Please include an easy way to mark the language for the "Body of the message" to add automatic language tagging during delivery.Dec 15 2022, 2:33 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits