Page MenuHomePhabricator

Remove deprecated property key and bump SecurePoll version
Closed, ResolvedPublic2 Estimated Story Points

Description

The not-blocked election property will be deprecated as part of T268800: SecurePoll should differentiate partial blocks from full blocks.

The old property will be replaced with properties that distinguish between partial blocks and sitewide blocks.

For now, we're still handling this deprecated property, but we should remove it and bump the SecurePoll version number to 3.0.0 to indicate the breaking change, at a time when no polls are running in production.

Event Timeline

Should I push my changes or wait for T277079 to be merged first? In the code, the documentation mentioned waiting for this task to be completed and no election running in production.

Change 676150 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/SecurePoll@master] Remove not-blocked use

https://gerrit.wikimedia.org/r/676150

Should I push my changes or wait for T277079 to be merged first? In the code, the documentation mentioned waiting for this task to be completed and no election running in production.

Thanks it's helpful to have this pushed. You're right that we should merge T277079 first, so I'll drag that in.

Change 676150 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Remove not-blocked use

https://gerrit.wikimedia.org/r/676150

Change 676793 had a related patch set uploaded (by Tchanders; author: Tchanders):

[mediawiki/extensions/SecurePoll@master] Revert "Revert "Remove not-blocked use""

https://gerrit.wikimedia.org/r/676793

Change 676793 merged by AGueyte:

[mediawiki/extensions/SecurePoll@master] Revert "Revert "Remove not-blocked use""

https://gerrit.wikimedia.org/r/676793