Page MenuHomePhabricator

Pass IDatabase to ActorNormalization methods
Closed, ResolvedPublic

Description

ActorNormalization should only be used in the context of direct database access. In such a context, an IDatabase instance should be readily available, and should be provided to the methods on ActorNormalization, to ensure a consistent transactional context.

NOTE: is new in 1.36 can can be changed without deprecation until 1.36 is released. However, care must be taken not to break extensions that already use it, especially if WMF uses them in production.
NOTE: acquireActorId() already has an optional IDatabase parameter. It is however use by several extensions already, most of which do not provide the parameter. All callers will have to be fixed before the parameter can be required.

Event Timeline

Change 668559 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] WIP: ActorNormalization should require a DB connection.

https://gerrit.wikimedia.org/r/668559

Change 670296 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/WikiForum@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670296

Change 670297 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/VoteNY@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670297

Change 670299 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/Comments@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670299

Change 670301 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/UserMerge@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670301

Change 670303 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/extensions/SocialProfile@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670303

Change 668559 merged by jenkins-bot:
[mediawiki/core@master] ActorNormalization should require a DB connection.

https://gerrit.wikimedia.org/r/668559

Change 670297 merged by jenkins-bot:
[mediawiki/extensions/VoteNY@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670297

Change 670303 merged by jenkins-bot:
[mediawiki/extensions/SocialProfile@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670303

Change 670301 merged by jenkins-bot:
[mediawiki/extensions/UserMerge@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670301

Change 670299 merged by jenkins-bot:
[mediawiki/extensions/Comments@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670299

Change 670296 merged by jenkins-bot:

[mediawiki/extensions/WikiForum@master] Pass a database to acquireActorId().

https://gerrit.wikimedia.org/r/670296

Change 694497 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/extensions/Comments@master] Provide $dbw to ActorNormalization always

https://gerrit.wikimedia.org/r/694497

Change 694499 had a related patch set uploaded (by Ppchelko; author: Ppchelko):

[mediawiki/core@master] ActorNormalization::acquireActorId - require IDatabase

https://gerrit.wikimedia.org/r/694499

Change 694497 merged by jenkins-bot:

[mediawiki/extensions/Comments@master] Provide $dbw to ActorNormalization always

https://gerrit.wikimedia.org/r/694497

Change 694499 merged by jenkins-bot:

[mediawiki/core@master] ActorNormalization::acquireActorId - require IDatabase

https://gerrit.wikimedia.org/r/694499