Ensure duplicate notifications are not sent for the same talk page event
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	• ppelberg
	Mar 9 2021, 10:30 PM

Description

This task is about making sure people do not receive multiple notifications for a single signed talk page edit.

In this task we are considering "topic subscription" and "mention" events. (There are also "user talk" events, but those will be considered elsewhere).

Desired behavior

IF at "Time 1" Marcus subscribes to "Topic A"
AND at "Time 2" Ashley posts a new comment in "Topic A" and mentions Marcus in said comment
THEN at "Time 2" Marcus should receive ONE notification alerting him that Ashley has mentioned him in a comment.

Done

The Desired behavior is implemented

Details

	Subject	Repo	Branch	Lines +/-
	Introduce 'EchoGetEventsForRevision' hook	mediawiki/extensions/Echo	master	+69 -22

Customize query in gerrit

Related Objects
Search...

Status	Assigned	Task
Open	None	T276497 Scale DiscussionTools to all projects
Open	None	T251207 [Epic] Scale DiscussionTools to all Wikipedias
Resolved	• ppelberg	T284489 Deploy topic subscriptions (desktop) as opt-out feature at all projects
Resolved	• ppelberg	T284490 Offer topic subscriptions as a Beta Feature at all projects
Resolved	• ppelberg	T287276 Offer manual topic subscriptions as Beta Feature at all projects
Open	None	T233447 [OKR] Increase response rates
Open	None	T273920 [Interventions] Notifications
Open	None	T263820 [Intervention] Manual topic subscriptions
Resolved	• LZaman	T274188 Offer manual topic subscriptions as a Beta Feature at partner wikis
Resolved	• ppelberg	T274216 Build topic subscriptions v1.0
Resolved	Esanders	T276990 Ensure duplicate notifications are not sent for the same talk page event

Event Timeline

• ppelberg created this task.Mar 9 2021, 10:30 PM

• ppelberg moved this task from Incoming to Upcoming on the Editing-team (Kanban Board) board.

• ppelberg moved this task from Backlog to Triaged on the DiscussionTools board.

• ppelberg updated the task description. (Show Details)

• ppelberg mentioned this in T263819: [Intervention] Automatic topic subscriptions.Mar 9 2021, 10:34 PM

• ppelberg moved this task from Upcoming to Ready to Be Worked On on the Editing-team (Kanban Board) board.Mar 10 2021, 2:21 AM

Esanders updated the task description. (Show Details)Mar 10 2021, 12:25 PM

@Catrope's notes from offline conversations:

Change Echo so that DT can hook in and selectively suppress Echo mention notifs that it knows will be duplicative of reply notifications it has sent / will send
- Make EchoDiscussionParser::generateEventsForRevision() generate an array of event data arrays, then run them through a hook that lets DT modify them, only then issue the events with EchoEvent::create()
- Hook into this in DT, and remove mention recipients who will receive a reply notification
Make DT suppress all Echo mention events when it's installed, and take over mentions completely
- DT could have its own mention presentation model, or use Echo's (by having DT generate events of type 'mention', which Echo registers a presentation model for)

• ppelberg assigned this task to Esanders.Mar 10 2021, 4:28 PM

• ppelberg moved this task from Ready to Be Worked On to Doing on the Editing-team (Kanban Board) board.

What about simply dropping the DT notification if we know the user will get a mention notification anyways? Mention is a notification type Echo already handles, so implementing it in DT seems reinventing the wheel to me.

In T276990#6903192, @Tacsipacsi wrote:

What about simply dropping the DT notification if we know the user will get a mention notification anyways? Mention is a notification type Echo already handles, so implementing it in DT seems reinventing the wheel to me.

Yes - we can choose between either of the notifications. I will prioritise the mention notification for now because I think it is more specific information to present to the user.

Change 670498 had a related patch set uploaded (by Esanders; owner: Esanders):
[mediawiki/extensions/Echo@master] Introduce 'EchoGetEventsForRevision' hook

https://gerrit.wikimedia.org/r/670498

gerritbot added a project: Patch-For-Review.Mar 17 2021, 9:59 PM

Esanders moved this task from Doing to Code Review on the Editing-team (Kanban Board) board.Mar 17 2021, 10:35 PM

Change 670498 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Introduce 'EchoGetEventsForRevision' hook

https://gerrit.wikimedia.org/r/670498

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 7:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2021, 7:10 PM

Test wiki created on Patch Demo by PPelberg (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/77cda30f9d/w/

• ppelberg mentioned this in T274201: Consult with Senior Contributors about topic subscription requirements.Apr 2 2021, 1:54 AM

This has been implemented in https://gerrit.wikimedia.org/r/c/mediawiki/extensions/DiscussionTools/+/663894 (it should have been tagged with this task).

• ppelberg closed this task as Resolved.Apr 9 2021, 1:24 AM

• ppelberg added a project: Skipped QA.

Test wiki on Patch demo by PPelberg (WMF) using patch(es) linked to this task was deleted:

~~https://patchdemo.wmflabs.org/wikis/77cda30f9d/w/~~

Ensure duplicate notifications are *not* sent for the same talk page eventClosed, ResolvedPublicActions