Investigate failures to successfully reparse as table cell attributes
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Assigned To

Authored By

	ssastry
	Mar 10 2021, 1:43 AM

Description

Error

MediaWiki version: 1.36.0-wmf.33

message

Invariant failed: Expected successful parse of  [[:Vorlage:Houptsyte/Bilder/24.02]] |
Invariant failed: Expected successful parse of  [[O Pátio das Cantigas (1942)|O Pátio das Cantigas ]] |

Impact

Notes

URLs:

Details

Stack Trace

from /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/assert/src/Assert.php(224)
#0 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/PP/Handlers/TableFixups.php(473): Wikimedia\Assert\Assert::invariant(boolean, string)
#1 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/PP/Handlers/TableFixups.php(581): Wikimedia\Parsoid\Wt2Html\PP\Handlers\TableFixups->combineWithPreviousCell(Wikimedia\Parsoid\Wt2Html\PageConfigFrame, DOMElement)
#2 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(381): Wikimedia\Parsoid\Wt2Html\PP\Handlers\TableFixups->handleTableCellTemplates(DOMElement, Wikimedia\Parsoid\Wt2Html\PageConfigFrame)
#3 [internal function]: Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(DOMElement, Wikimedia\Parsoid\Config\Env, array, boolean, stdClass)
#4 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(80): call_user_func(Closure, DOMElement, Wikimedia\Parsoid\Config\Env, array, boolean, stdClass)
#5 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(152): Wikimedia\Parsoid\Utils\DOMTraverser->callHandlers(DOMElement, Wikimedia\Parsoid\Config\Env, array, boolean, stdClass)
#6 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(167): Wikimedia\Parsoid\Utils\DOMTraverser->traverse(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean, stdClass)
#7 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(167): Wikimedia\Parsoid\Utils\DOMTraverser->traverse(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean, NULL)
#8 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(167): Wikimedia\Parsoid\Utils\DOMTraverser->traverse(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean, NULL)
#9 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Utils/DOMTraverser.php(167): Wikimedia\Parsoid\Utils\DOMTraverser->traverse(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean, NULL)
#10 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(149): Wikimedia\Parsoid\Utils\DOMTraverser->traverse(Wikimedia\Parsoid\Config\Env, DOMElement, array, boolean, NULL)
#11 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(837): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->Wikimedia\Parsoid\Wt2Html\{closure}(DOMElement, array, boolean)
#12 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(887): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->doPostProcess(DOMElement)
#13 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/DOMPostProcessor.php(904): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->process(DOMElement)
#14 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipeline.php(178): Wikimedia\Parsoid\Wt2Html\DOMPostProcessor->processChunkily(string, array)
#15 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Wt2Html/ParserPipelineFactory.php(310): Wikimedia\Parsoid\Wt2Html\ParserPipeline->parseChunkily(string, array)
#16 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Core/WikitextContentModelHandler.php(106): Wikimedia\Parsoid\Wt2Html\ParserPipelineFactory->parse(string)
#17 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Parsoid.php(162): Wikimedia\Parsoid\Core\WikitextContentModelHandler->toDOM(Wikimedia\Parsoid\Config\Env)
#18 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/src/Parsoid.php(194): Wikimedia\Parsoid\Parsoid->parseWikitext(MWParsoid\Config\PageConfig, array)
#19 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/extension/src/Rest/Handler/ParsoidHandler.php(589): Wikimedia\Parsoid\Parsoid->wikitext2html(MWParsoid\Config\PageConfig, array, NULL)
#20 /srv/mediawiki/php-1.36.0-wmf.33/vendor/wikimedia/parsoid/extension/src/Rest/Handler/PageHandler.php(88): MWParsoid\Rest\Handler\ParsoidHandler->wt2html(MWParsoid\Config\PageConfig, array)
#21 /srv/mediawiki/php-1.36.0-wmf.33/includes/Rest/Router.php(395): MWParsoid\Rest\Handler\PageHandler->execute()
#22 /srv/mediawiki/php-1.36.0-wmf.33/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MWParsoid\Rest\Handler\PageHandler)
#23 /srv/mediawiki/php-1.36.0-wmf.33/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#24 /srv/mediawiki/php-1.36.0-wmf.33/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#25 /srv/mediawiki/php-1.36.0-wmf.33/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#26 /srv/mediawiki/w/rest.php(3): require(string)
#27 {main}

Event Timeline

ssastry triaged this task as Medium priority.Mar 10 2021, 1:43 AM

ssastry created this task.

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 10 2021, 1:43 AM

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Mar 10 2021, 7:12 PM

Krinkle updated the task description. (Show Details)

Krinkle edited Stack Trace. (Show Details)

ssastry moved this task from Needs Triage to Bugs & Crashers on the Parsoid board.Mar 10 2021, 11:33 PM

ssastry renamed this task from Invariant failed: Expected successful parse of [[:Vorlage:Houptsyte/Bilder/24.02]] | to More failed assertions in TableFixups handler.Mar 18 2021, 8:27 PM

ssastry removed Request URL.

ssastry updated the task description. (Show Details)

ssastry edited Stack Trace. (Show Details)

ssastry updated the task description. (Show Details)

@ssastry It looks like this no longer ocurrs in Logstash in the last 90 days. Should task be closed, or does it represent a known and understood edge case that still exists but isn't excercised by content currently?

Krinkle moved this task from Mar 2021 to Older on the Wikimedia-production-error board.Jun 8 2023, 3:33 PM

The assertion was changed to a log in,
https://github.com/wikimedia/mediawiki-services-parsoid/commit/1b39be0995a201b4cc949bee32c5964053bdf77e

Parsing one of the pages locally,
https://de.wikipedia.org/w/rest.php/de.wikipedia.org/v3/page/pagebundle/Liste_von_Neuverfilmungen/209848563

I still see,

[error/wt2html] TableFixups: Failed to successfully reparse  [[O Pátio das Cantigas (1942)|O Pátio das Cantigas ]] | as table cell attributes

I'm going to repurpose the task to investigate the logs and remove the Wikimedia-production-error tag

Arlolra renamed this task from More failed assertions in TableFixups handler to Investigate failures to successfully reparse as table cell attributes.Jun 8 2023, 11:19 PM

MSantos added projects: Content-Transform-Team-WIP, Essential-Work.Dec 14 2023, 3:25 PM

MSantos moved this task from Backlog to To Verify on the Content-Transform-Team-WIP board.

With all the latest fixes, these pages render properly.

Investigate failures to successfully reparse as table cell attributesClosed, ResolvedPublicPRODUCTION ERRORActions