Page MenuHomePhabricator

Remove servers interface names from switches interfaces descriptions
Closed, ResolvedPublic

Description

For servers facing ports, the switch descriptions use the following format:
description "hostname:interface_name {#cable_id}";
Unfortunately those descriptions changes during servers re-image, or after their first puppet runs, for example:

-   description "ms-backup1001:##PRIMARY## {#5322}";
+   description "ms-backup1001:ens2f0np0 {#5322}";

Or

[edit interfaces xe-7/0/25]
-   description "an-worker1103:eno1 {#}";
+   description "an-worker1103:eno1np0 {#}";

As running Homer is manual and time consuming, only to update those interfaces descriptions, it's not being done.
This causes the daily diffs emails to always bring up outstanding changes, making those emails less relevant, and could hide some more important discrepancies.

There are several options to improve this situation:

  1. Remove the server interface name from the switch interface description
    • This is the easiest/fastest, downside is for servers with multiple links (not common) but the data is still in Netbox and LLDP
  2. Use a stable identifier
    • Cleanest option, could for example use the Netbox "label" field (to not confuse with "name", that we use). A whole can of worm as it means changing our provisioning scripts and processes
  3. (Semi-)automatically update only the switch interface name
    • Using for example spice-rack/cookbooks to only push a partial config to the switch, probably the long term solution, especially as this will be needed if we do any kind of (semi-)automated remediation/changes, etc

My preference is to go with (1) as now that we have the data in Netbox, there is less need to have the data in the switch config as well.

@Papaul, @Volans what do you think?

Event Timeline

ayounsi triaged this task as Medium priority.Mar 10 2021, 7:13 AM
ayounsi created this task.

I agree with (1) for now, given that probably we'll go for (3) anyway later on.

Change 671176 had a related patch set uploaded (by Ayounsi; owner: Ayounsi):
[operations/software/homer/deploy@master] Remove servers interface names from switches interfaces descriptions

https://gerrit.wikimedia.org/r/671176

Change 671176 merged by Ayounsi:
[operations/software/homer/deploy@master] Remove servers interface names from switches interfaces descriptions

https://gerrit.wikimedia.org/r/671176

Mentioned in SAL (#wikimedia-operations) [2021-03-16T15:27:27Z] <ayounsi@deploy1002> Started deploy [homer/deploy@759f82c]: T277006

Mentioned in SAL (#wikimedia-operations) [2021-03-16T15:32:24Z] <ayounsi@deploy1002> Finished deploy [homer/deploy@759f82c]: T277006 (duration: 04m 56s)

ayounsi claimed this task.

All done!