Page MenuHomePhabricator
Create Task
Maniphest T277056

TypeError: Argument 1 passed to Wikimedia\Rdbms\TransactionProfiler::recordConnection() must be of the type string, null given
Closed, ResolvedPublic
Actions

Description

This error happens when setting up a new wiki on https://patchdemo.wmflabs.org/, when running the edit.php maintenance script:

TypeError: Argument 1 passed to Wikimedia\Rdbms\TransactionProfiler::recordConnection() must be of the type string, null given, called in /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php on line 1006
Backtrace:
from /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/libs/rdbms/TransactionProfiler.php(197)
#0 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1006): Wikimedia\Rdbms\TransactionProfiler->recordConnection(NULL, string, boolean)
#1 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(960): Wikimedia\Rdbms\LoadBalancer->getServerConnection(integer, string, integer)
#2 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1099): Wikimedia\Rdbms\LoadBalancer->getConnection(integer, array, string, integer)
#3 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/includes/user/User.php(819): Wikimedia\Rdbms\LoadBalancer->getConnectionRef(integer)
#4 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/maintenance/edit.php(64): User::newSystemUser(string, array)
#5 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/maintenance/doMaintenance.php(112): EditCLI->execute()
#6 /srv/patchdemo-wikis/78374bbd8ec1152e7332eda02d0f3ff7/w/maintenance/edit.php(134): require_once(string)
#7 {main}

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
rdbms: cleanup getServer() and connection parameter fields in Databasemediawiki/coremaster+244 -181
rdbms: work around Database::getServer() returning nullmediawiki/coremaster+4 -2
rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)mediawiki/corewmf/1.36.0-wmf.35+161 -103
rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)mediawiki/coremaster+161 -103
Revert "rdbms: avoid undefined "expectBy" notices in TransactionProfiler"mediawiki/coremaster+102 -160
Revert "rdbms: Group DBPerformance logs by violated measure"mediawiki/coremaster+3 -5
Customize query in gerrit

Related Objects

Event Timeline

matmarex created this task.Mar 10 2021, 3:58 PM
Restricted Application added a project: Platform Engineering. · View Herald TranscriptMar 10 2021, 3:58 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
matmarex added a subscriber: Krinkle.Mar 10 2021, 4:00 PM

It started happening today, possibly caused by https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666446 or https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666508

Kizule subscribed.Mar 10 2021, 11:19 PM
Esanders triaged this task as High priority.Mar 11 2021, 1:41 PM
matmarex added a comment.Mar 11 2021, 7:55 PM

I will bisect and revert if no one investigates.

Krinkle added a project: Performance-Team.Mar 11 2021, 9:37 PM
Ladsgroup subscribed.Mar 12 2021, 8:01 PM
Ladsgroup added a comment.Mar 12 2021, 8:06 PM

Had this locally, reverting I5d106ac5c95d0ea94c4f6bdee90ca51f8f7ddbad (https://gerrit.wikimedia.org/r/c/mediawiki/core/+/666508) fixed it.

Ladsgroup added a comment.Mar 12 2021, 8:36 PM

This is borderline UBN. Breaking master. Also some regression testing would be nice.

Krinkle assigned this task to aaron.Mar 12 2021, 8:51 PM
Krinkle moved this task from Inbox, needs triage to Doing: Prio Interrupt on the Performance-Team board.
Krinkle moved this task from Untriaged to Rdbms library on the MediaWiki-libs-Rdbms board.
gerritbot added a comment.Mar 12 2021, 10:12 PM

Change 670476 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] rdbms: cleanup getServer() and connection parameter fields in Database

https://gerrit.wikimedia.org/r/670476

gerritbot added a project: Patch-For-Review.Mar 12 2021, 10:12 PM
gerritbot added a comment.Mar 12 2021, 10:14 PM

Change 671282 had a related patch set uploaded (by Aaron Schulz; owner: Aaron Schulz):
[mediawiki/core@master] rdbms: work around Database::getServer() returning null

https://gerrit.wikimedia.org/r/671282

matmarex added a comment.Mar 12 2021, 11:09 PM

The patches (when both are applied) fix the issue for me, but I'm not comfortable merging a 200-line change in database internals.

aaron added a comment.Mar 12 2021, 11:21 PM

The second one alone should be enough for a quick fix.

matmarex added a comment.Mar 13 2021, 12:05 AM

It's not:

Uncaught TypeError: Argument 1 passed to Wikimedia\Rdbms\TransactionProfiler::transactionWritingOut() must be of the type string, null given, called in /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/database/Database.php on line 4699 and defined in /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/TransactionProfiler.php:322
Stack trace:
#0 /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/database/Database.php(4699): Wikimedia\Rdbms\TransactionProfiler->transactionWritingOut(NULL, 'patchdemo_659cc...', '9b0417', 0, 0)
#1 /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(1952): Wikimedia\Rdbms\Database->rollback('MWExceptionHand...', 'flush')
#2 /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/loadbalancer/LoadBalancer.php(2255): Wikimedia\Rdbms\LoadBalancer::Wikimedia\Rdbms\{closure}(Object(Wikimedia\Rdbms\DatabaseMysqli))
#3 /srv/patchdemo-wikis/ in /srv/patchdemo-wikis/659ccdb7732485b5980061ba1de79679/w/includes/libs/rdbms/TransactionProfiler.php on line 322
matmarex added a comment.Mar 13 2021, 12:06 AM

@aaron For testing, you can copy the Gerrit change number into https://patchdemo.wmflabs.org/, and see if it creates a wiki or fails (in which case the exception will be somewhere in the log it prints).

gerritbot added a comment.Mar 15 2021, 10:15 PM

Change 672549 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Revert "rdbms: Group DBPerformance logs by violated measure"

https://gerrit.wikimedia.org/r/672549

gerritbot added a comment.Mar 15 2021, 10:15 PM

Change 672550 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/core@master] Revert "rdbms: avoid undefined "expectBy" notices in TransactionProfiler"

https://gerrit.wikimedia.org/r/672550

matmarex added a comment.Mar 15 2021, 10:19 PM

@aaron I'm sorry but I don't think it's acceptable to leave master broken for almost a week now. This bug is interfering with my work. I hope I'm not causing you too much annoyance by reverting these patches.

Ladsgroup added a comment.Mar 15 2021, 10:24 PM

Agreeing with @matmarex, I do know a little about database internals and would be happy to review but rather smaller patches with proper tests, less duplicated code, hopefully following SOLID a bit, etc.

gerritbot added a comment.Mar 15 2021, 10:42 PM

Change 672549 merged by jenkins-bot:
[mediawiki/core@master] Revert "rdbms: Group DBPerformance logs by violated measure"

https://gerrit.wikimedia.org/r/672549

Krinkle added a comment.EditedMar 15 2021, 10:45 PM

Unfortunately the change in question contained many unrelated internal changes and refactorings, so I have no idea if it safe to revert or what other commits may have started to depend on this since then. Please keep this task open for @aaron to review after the fact, which I'm considering a train blocker for safety.

Krinkle added a parent task: T274939: 1.36.0-wmf.35 deployment blockers.Mar 15 2021, 10:45 PM
Krinkle mentioned this in T277516: Group DBPerformance logs by violated measure.
gerritbot added a comment.Mar 15 2021, 10:48 PM

Change 672550 merged by jenkins-bot:
[mediawiki/core@master] Revert "rdbms: avoid undefined "expectBy" notices in TransactionProfiler"

https://gerrit.wikimedia.org/r/672550

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 15 2021, 11:00 PM
gerritbot added a comment.Mar 16 2021, 3:58 AM

Change 672555 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@master] rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)

https://gerrit.wikimedia.org/r/672555

gerritbot added a comment.Mar 16 2021, 4:00 AM

Change 672587 had a related patch set uploaded (by Krinkle; owner: Aaron Schulz):
[mediawiki/core@wmf/1.36.0-wmf.35] rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)

https://gerrit.wikimedia.org/r/672587

PatchDemoBot added a comment.Mar 16 2021, 4:03 AM

Test wiki created on Patch Demo by Krinkle using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/77aaae428fcb714755519ff4f9281982/w/

gerritbot added a comment.Mar 16 2021, 4:27 AM

Change 672555 merged by jenkins-bot:
[mediawiki/core@master] rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)

https://gerrit.wikimedia.org/r/672555

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 16 2021, 5:00 AM
Ladsgroup added a comment.Mar 16 2021, 8:59 AM

It seems it's not a blocker anymore. Can you remove it?

Krinkle added a comment.Mar 16 2021, 12:51 PM

Backport hasn't landed yet.

Ladsgroup added a comment.Mar 16 2021, 12:52 PM

oh sorry I thought the merged one was the backport

• AMooney moved this task from Inbox to Tracking/Watching on the Platform Engineering board.Mar 16 2021, 2:28 PM
gerritbot added a comment.Mar 16 2021, 6:06 PM

Change 672587 merged by jenkins-bot:
[mediawiki/core@wmf/1.36.0-wmf.35] rdbms: avoid undefined "expectBy" notices in TransactionProfiler (II)

https://gerrit.wikimedia.org/r/672587

dancy subscribed.Mar 16 2021, 6:13 PM

@Ladsgroup The backport has been merged.

dancy removed a parent task: T274939: 1.36.0-wmf.35 deployment blockers.Mar 16 2021, 6:23 PM
ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.35; 2021-03-16); removed MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 16 2021, 7:00 PM
Krinkle closed this task as Resolved.Mar 18 2021, 1:34 AM
gerritbot added a comment.Mar 30 2021, 6:15 PM

Change 671282 abandoned by Aaron Schulz:
[mediawiki/core@master] rdbms: work around Database::getServer() returning null

Reason:
obsolete

https://gerrit.wikimedia.org/r/671282

gerritbot added a comment.May 5 2021, 8:10 PM

Change 670476 merged by jenkins-bot:

[mediawiki/core@master] rdbms: cleanup getServer() and connection parameter fields in Database

https://gerrit.wikimedia.org/r/670476

Maintenance_bot removed a project: Patch-For-Review.May 5 2021, 9:10 PM
PatchDemoBot added a comment.Aug 13 2021, 7:02 PM

Test wiki on Patch Demo by Krinkle using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/77aaae428fcb714755519ff4f9281982/w/

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits