Page MenuHomePhabricator

Fix translator comment which should be a HTML comment
Closed, ResolvedPublic

Description

Task
If I log in to the Wikipedia Library Card and go to https://wikipedialibrary.wmflabs.org/users/ , then above the "Personal Data" section heading I see this text:

# Translators: This is a heading for a section of the user profile which contains personal data about the user, such as their real name.

This is an internal code comment that should be displayed on translatewiki, but not on the production site.

This error was introduced as part of T274879 - the suggested edit was to introduce a Python style comment (# Comment) instead of a HTML compatible one.

The line # Translators: This is a heading for a section of the user profile which contains personal data about the user, such as their real name. should be updated to {% comment %}Translators: This is a heading for a section of the user profile which contains personal data about the user, such as their real name.{% endcomment %} This can be found at TWLight/users/templates/users/editor_detail_data.html, line 247.

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9-WMF renamed this task from Unnecessary internal documentation text appears on the Library Card user preferences page to Fix translator comment which should be a HTML comment.Mar 11 2021, 1:44 PM
Samwalton9-WMF updated the task description. (Show Details)
Gaurav24072002 subscribed.

Hey ! Can you Please help me solve this issue, I am interested in this issue and Please help me with the code base as well 😊 Thank you

I want to work on this issue and since I am new to the open source world, so please guide me through.

Hi both - the task description has links to our getting started and local setup guides. Please take a look at those and give this a go, and if you get stuck you can ask questions here.

This comment was removed by Ankur21980.

https://github.com/WikipediaLibrary/TWLight/pull/647#issue-591896643
This is my pull request to the mentioned issue. So please review it and if their is any kind of mistake then let me know.

Thanks @Ankur21980 and @Samwalton9! I confirm this is fixed in production.

Welcome @Amire80. I would also like to contribute more in this project. So can you please let me know if any beginner friendly issues are there in this project.

Welcome @Amire80. I would also like to contribute more in this project. So can you please let me know if any beginner friendly issues are there in this project.

I reported a few bugs recently: https://phabricator.wikimedia.org/project/board/2765/?filter=y1NSRZ2CT5iC

Most of them are probably easy, but I'm not a developer of this project, so I cannot assess how easy they are or to provide you support.