Page MenuHomePhabricator

"Last updated" in the Terms of Use section in Library card cannot be translated
Closed, ResolvedPublic


The "Last updated at" string on user's profiles has not been marked for translation, but should be. It can be found here:

To make a HTML string translatable we need to use the {% trans 'text goes here' %} format. In this case, we want to update this line to the following:

</br> {% trans 'Last updated at:' %} {{ user.userprofile.terms_of_use_date }} {{ user.userprofile.terms_of_use_date | time:"H:i" }}

We also need a translator comment on the line above, like so: {% comment %} Translators: This text labels the date for when the terms of use were most recently changed. {% endcomment %}

Good first task

This task has been placed in the good first task category. This means it has been scoped and written in a way that makes it simpler for folks who haven’t contributed to the tool’s development or open source software in the past.

If that’s you, welcome! Please feel free to ask questions here about this specific task or the codebase more generally. We’ll be more than happy to help you and clarify the steps needed to complete the task, whether that’s setting up the repository, implementing the necessary changes, or pushing your changes to Github.

If you have experience contributing to this project or similar ones, please consider leaving this one for someone new, and taking a look at the Open Tasks column of the workboard for another task. Also feel free to help out if you see unanswered questions here!

How to contribute

Assign yourself to this task: Click the ‘Add Action’ dropdown menu below and then select Assign / Claim. The box should fill your username in automatically, then click Submit!

The Library Card platform repository can be found at WikipediaLibrary/TWLight. Please see the Getting Started and Local Setup guides to get up and running with a local development environment.

To submit your changes, you should fork the repository and create a new branch. After pushing your changes to your Github branch, you can open a pull request. Please link your pull request in a comment here when it has been submitted, and include the Phabricator task number in the pull request. Experienced contributors to the project will review your code and either provide feedback or merge it in!

Event Timeline

Samwalton9 added a project: good first task.
Samwalton9 updated the task description. (Show Details)
Ankur21980 added a subscriber: Ankur21980.

Hey, I would like to work on this task.

Scardenasmolinar moved this task from Ready to Done on the The-Wikipedia-Library (Kanban) board.
Scardenasmolinar added a subscriber: Scardenasmolinar.

This task has been merged. Thank you for your contribution, @Ankur21980!