Page MenuHomePhabricator
Create Task
Maniphest T277153

Allow user to decide on updating or adding new entry if entry with same spelling exists
Closed, ResolvedPublic4 Estimated Story Points
Actions

Description

If the user tries to add a entry that already exists, they should be informed about this and be given a choice to either update one of the existing entries or add a new one. To give them something to go on, the entries as JSON should be displayed. A more user friendly solution is handled in T277152.

This probably means that we need to add some extra fields to Special:EditLexicon that only show up when certain URL parameters are given.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Allow editing existing lexicon entries via Special:EditLexiconmediawiki/extensions/Wikispeechmaster+335 -55
Customize query in gerrit

Related Objects
Search...

Event Timeline

Sebastian_Berlin-WMSE created this task.Mar 11 2021, 10:49 AM
Sebastian_Berlin-WMSE added a subtask: T274485: Edit lexicon special page should accept URL parameters.
Sebastian_Berlin-WMSE added a parent task: T277152: Display disambiguation information about a lexicon entry.
Sebastian_Berlin-WMSE set the point value for this task to 16.Mar 11 2021, 10:51 AM
Sebastian_Berlin-WMSE moved this task from Incoming to Sprint on the Wikispeech-Jobrunner board.
Sebastian_Berlin-WMSE edited projects, added Wikispeech-Jobrunner (Sprint); removed Wikispeech-Jobrunner.
Sebastian_Berlin-WMSE claimed this task.Mar 26 2021, 8:57 AM
Sebastian_Berlin-WMSE moved this task from Backlog to In progress on the Wikispeech-Jobrunner (Sprint) board.
Sebastian_Berlin-WMSE added a project: User-Sebastian_Berlin-WMSE.
Sebastian_Berlin-WMSE moved this task from Backlog to This Week on the User-Sebastian_Berlin-WMSE board.
Sebastian_Berlin-WMSE added a comment.Apr 1 2021, 8:20 AM

I had to change from FormSpecialPage to normal SpecialPage for this, since the former was to rigid for what I wanted to do.

Sebastian_Berlin-WMSE changed the point value for this task from 16 to 8.Apr 8 2021, 8:10 AM
Sebastian_Berlin-WMSE edited parent tasks, added: T133865: ☂Lexicon editor; removed: T181269: ☂Create a special page for adding entries to the lexicon.Apr 8 2021, 8:35 AM
Sebastian_Berlin-WMSE removed a parent task: T277152: Display disambiguation information about a lexicon entry.
Sebastian_Berlin-WMSE added a parent task: T277152: Display disambiguation information about a lexicon entry.Apr 8 2021, 8:38 AM
Sebastian_Berlin-WMSE closed subtask T274485: Edit lexicon special page should accept URL parameters as Resolved.Apr 8 2021, 11:16 AM
Sebastian_Berlin-WMSE moved this task from Unsorted to Editor on the Wikispeech-Text-to-Speech board.Apr 9 2021, 12:12 PM
Sebastian_Berlin-WMSE mentioned this in T279916: Fix empty objects being turned into empty arrays when handling entries.Apr 12 2021, 12:03 PM
gerritbot added a comment.Apr 12 2021, 3:25 PM

Change 678610 had a related patch set uploaded (by Sebastian Berlin (WMSE); author: Sebastian Berlin (WMSE)):

[mediawiki/extensions/Wikispeech@master] Allow editing existing lexicon entries via Special:EditLexicon

https://gerrit.wikimedia.org/r/678610

gerritbot added a project: Patch-For-Review.Apr 12 2021, 3:25 PM
Sebastian_Berlin-WMSE changed the point value for this task from 8 to 4.Apr 22 2021, 8:03 AM
gerritbot added a comment.Apr 26 2021, 12:01 PM

Change 678610 merged by jenkins-bot:

[mediawiki/extensions/Wikispeech@master] Allow editing existing lexicon entries via Special:EditLexicon

https://gerrit.wikimedia.org/r/678610

Sebastian_Berlin-WMSE mentioned this in rEWIS35abf5c6081e: Allow editing existing lexicon entries via Special:EditLexicon.Apr 26 2021, 12:02 PM
Maintenance_bot removed a project: Patch-For-Review.Apr 26 2021, 12:10 PM
Sebastian_Berlin-WMSE moved this task from In progress to Done on the Wikispeech-Jobrunner (Sprint) board.Apr 26 2021, 1:08 PM
Sebastian_Berlin-WMSE moved this task from This Week to Done on the User-Sebastian_Berlin-WMSE board.Apr 26 2021, 1:49 PM
Jopparn closed this task as Resolved.Jul 19 2021, 11:42 AM
Sebastian_Berlin-WMSE merged a task: T280777: Allow the user to select an entry if spelling is given for Special:EditLexicon.Jul 23 2021, 11:50 AM
Sebastian_Berlin-WMSE added a subscriber: Aklapper.
Stashbot mentioned this in T280258: Mock mw.Api instead of server.Sep 28 2022, 8:03 AM
Stashbot mentioned this in T281262: Treat Speechoid lexicon id (Pronlex id) as int rather than string.
Stashbot mentioned this in T277242: Ensure new lexicon edits are CC0.

Mentioned in SAL (#wikimedia-cloud) [2022-09-28T08:03:03Z] <sebastian-wmse> Deploy latest from Git master: 2c16169, 84c80a6, 1dea391, 67d3618, 10e4ac5, 043335c (T279620), 1cbfbd8, 29f572a, b7ca5be (T280239, T280258), ac721c8, 8eb2f15 (T133857), d5182d6, 9ddab13 (T279652), 8eebc3d, 36c217f (T280244), dc93055 (T279652), 35abf5c (T277153), f922c2d (T277242), d91b7e8, 898e716 (T279632), 3cbb3b9 (T281262),

Stashbot mentioned this in T280244: Optionally mark utterance files with TTL in Swift.Sep 28 2022, 8:03 AM
Stashbot mentioned this in T279620: i18n for wikispeech-edit-lexicon user group.
Stashbot mentioned this in T133857: Link to Special:EditLexicon from player.
Stashbot mentioned this in T280239: Use GET requests for segments and utterances.
Stashbot mentioned this in T279652: Credit PTS in repo code.
Stashbot mentioned this in T279632: Implement local lexicon in new wiki namespace.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits