Page MenuHomePhabricator

The "Withdraw" button on the "My Applications" page in the Library Card platform is not translatable
Closed, ResolvedPublic

Description

I logged in to Library Card platform and set my language to Hebrew. I applied for a publisher and looked at the "My Applications" page. My recently submitted application appeared at the top of the list. Next to it there is a "Withdraw" button. The whole UI is translated to Hebrew, but the "Withdraw" button appears in English. I couldn't find a "Withdraw" message in translatewiki.

Event Timeline

Hi

I have submitted a pull request. I followed the instructions the best I can. Please let me know if I need to correct anything.

https://github.com/WikipediaLibrary/TWLight/pull/779

Thanks @Aacaldwell! You've marked the string for translation correctly, but there's no need for you to make the change to the Hebrew translation file yourself - instead, the translator comment you wrote (Translators: When the user starts a new application and submits the application, the user can view the application and withdraw if need be. This changes the label for the Withdraw button.) should be placed above the string in the HTML file, like so:

{% comment %}Translators: When the user starts a new application and submits the application, the user can view the application and withdraw if need be. This changes the label for the Withdraw button.{% endcomment %}
<input type="submit" value="{% trans "Withdraw" %}" class="btn btn-danger btn-sm">

Once the comment is there, the Django software will pick it up and place it in the relevant translation files for us so that folks like Amir can translate the string via TranslateWiki :)

Okay great. I updated my PR for this one. Thank you for the clarification.