Page MenuHomePhabricator

WikibaseClient: Convert EchoSetupHookHandlers to new Hook Handler definition with DI
Closed, ResolvedPublic

Description

Currently, these Echo hook handlers are registered directly through extension-client.json without a hook handler, which prevents us from employing proper dependency injection.

AC:

  • EchoSetupHookHandlers class is defined as a hook handler in extension-client.json
  • All dependencies are injected to the hook handler through the service container

Notes:

Event Timeline

Lucas_Werkmeister_WMDE moved this task from Incoming to Doing on the Wikibase Service Migration board.

Taking a look at this – I think we can actually use the new system (mostly)?

Change 670825 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/Wikibase@master] Convert EchoSetupHookHandler(s) to hook handler

https://gerrit.wikimedia.org/r/670825

Change 670825 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Convert EchoSetupHookHandler(s) to hook handler

https://gerrit.wikimedia.org/r/670825