Page MenuHomePhabricator
Create Task
Maniphest T277177

TagMultiselectWidget shows 2 tags if allowDisplayInvalidTags is true
Closed, ResolvedPublic
Actions

Description

  1. Go to the "TagMultiselectWidget (inline input, allowed values: [ 'foo', 'bar', 'baz' ], allowDisplayInvalidTags)" demo on https://doc.wikimedia.org/oojs-ui/master/demos/?page=widgets&theme=wikimediaui&direction=ltr&platform=desktop#demo-section-tagMultiselect
  2. Type in "foo" and press <enter>
  3. Observe 2 tags are added, and focus is lost

image.png (65×717 px, 8 KB)

Focus is also lost when backspacing into a tag.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Update OOUI to v0.41.3mediawiki/coremaster+83 -56
TagMultiselectWidget: Don't fire blur event while changing, and restore focusoojs/uimaster+15 -1
Customize query in gerrit

Related Objects

Event Timeline

Esanders created this task.Mar 11 2021, 2:57 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2021, 2:57 PM
gerritbot added a comment.Mar 11 2021, 2:58 PM

Change 670833 had a related patch set uploaded (by Esanders; owner: Esanders):
[oojs/ui@master] TagMultiselectWidget: Don't fire blur event while changing, and restore focus

https://gerrit.wikimedia.org/r/670833

gerritbot added a project: Patch-For-Review.Mar 11 2021, 2:58 PM
gerritbot added a comment.Mar 12 2021, 12:45 AM

Change 670833 merged by jenkins-bot:
[oojs/ui@master] TagMultiselectWidget: Don't fire blur event while changing, and restore focus

https://gerrit.wikimedia.org/r/670833

Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 1:10 AM
gerritbot added a comment.Mar 12 2021, 10:01 PM

Change 671278 had a related patch set uploaded (by Jforrester; owner: Jforrester):
[mediawiki/core@master] Update OOUI to v0.41.3

https://gerrit.wikimedia.org/r/671278

gerritbot added a project: Patch-For-Review.Mar 12 2021, 10:01 PM
gerritbot added a comment.Mar 12 2021, 10:32 PM

Change 671278 merged by jenkins-bot:
[mediawiki/core@master] Update OOUI to v0.41.3

https://gerrit.wikimedia.org/r/671278

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 12 2021, 11:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 12 2021, 11:10 PM
Volker_E closed this task as Resolved.Mar 14 2021, 4:46 PM
Volker_E assigned this task to Esanders.
Volker_E triaged this task as Medium priority.
Volker_E moved this task from Backlog to OOUI-0.41.3 on the OOUI board.
Volker_E edited projects, added OOUI (OOUI-0.41.3); removed OOUI.
Lucas_Werkmeister_WMDE mentioned this in T278522: Grammatical features field is now right-aligned.Mar 26 2021, 11:31 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits