EditPage: Argument 2 passed to MediaWiki\Revision\RevisionStore::getRevisionByTimestamp() must be of the type string, null given
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.33

message

Argument 2 passed to MediaWiki\Revision\RevisionStore::getRevisionByTimestamp() must be of the type string, null given, called in /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php on line 2619

Impact

Looks to me like some edits are failing.

Notes

Page title can be found in logstash under this request ID.

Noticed 6 of these in the last 4 hours in logstash, and 45 in logspam-watch since logs on mwlog1001 last rolled over:

45      __▇▄___ 1044    1312    TypeError...........    .33 i/R/RevisionStore:1209  Argument 2 passed to MediaWiki\Revision\R
[pattern: .*getRevisionByTimestamp.*]

Already in 1.36.0-wmf.33, so not blocking the wmf.34 train on it.

Details

Request ID: YEoXKGIeUVnN@2BpiitlLwAAAIA
Request URL: https://pt.wikipedia.org/w/index.php?title=[title]&action=submit

Stack Trace

exception.trace

from /srv/mediawiki/php-1.36.0-wmf.33/includes/Revision/RevisionStore.php(1209)
#0 /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php(2619): MediaWiki\Revision\RevisionStore->getRevisionByTimestamp(Title, NULL, integer)
#1 /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php(2542): EditPage->getExpectedParentRevision()
#2 /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php(2214): EditPage->mergeChangesIntoContent(WikitextContent)
#3 /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php(1687): EditPage->internalAttemptSave(NULL, boolean)
#4 /srv/mediawiki/php-1.36.0-wmf.33/includes/EditPage.php(662): EditPage->attemptSave(NULL)
#5 /srv/mediawiki/php-1.36.0-wmf.33/includes/actions/EditAction.php(71): EditPage->edit()
#6 /srv/mediawiki/php-1.36.0-wmf.33/includes/actions/SubmitAction.php(38): EditAction->show()
#7 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(531): SubmitAction->show()
#8 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(315): MediaWiki->performAction(Article, Title)
#9 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(925): MediaWiki->performRequest()
#10 /srv/mediawiki/php-1.36.0-wmf.33/includes/MediaWiki.php(547): MediaWiki->main()
#11 /srv/mediawiki/php-1.36.0-wmf.33/index.php(53): MediaWiki->run()
#12 /srv/mediawiki/php-1.36.0-wmf.33/index.php(46): wfIndexMain()
#13 /srv/mediawiki/w/index.php(3): require(string)
#14 {main}

	Subject	Repo	Branch	Lines +/-
	EditPage::getExpectedParentRevision(): guard against null edittime	mediawiki/core	master	+25 -2

Customize query in gerrit

Event Timeline

brennen created this task.Mar 11 2021, 5:14 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2021, 5:14 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Mar 11 2021, 5:15 PM

• AMooney triaged this task as Medium priority.Mar 16 2021, 2:12 PM

• AMooney edited projects, added Platform Team Workboards (Clinic Duty Team); removed Platform Engineering.

• AMooney moved this task from Inbox to Later on the Platform Team Workboards (Clinic Duty Team) board.

Type errors are almost always deterministic, highly visible, and very likely regressions caused by recent development in this area

(Since both this code, and our habit of typing are relatively new; and we tend to fix this kind of issue quickly when it happens.)

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Mar 27 2021, 3:07 AM

The null is EditPage::edittime which is set to empy string, but on validation it can be set to null. When EditPage::editRevId is also null, than it fails like this here.

We should fix this before switching to the new editpage backend, so that it doesn't inherit any existing errors - I'll try to investigate this. Is there a stable link or set of steps to reproduce this?

AnnaMikla moved this task from Later to Doing (S&F WIP:2) on the Platform Team Workboards (Clinic Duty Team) board.Apr 26 2021, 3:21 PM

Art.tsymbar claimed this task.Apr 26 2021, 5:55 PM

I was able to reproduce this by setting the form field editRevId to "0" and omitting the form field wpEdittime. The error occurs when EditPage::mergeChangesIntoContent() is called when edittime is null and editRevId is falsey. If editRevId is null, the edit conflict is suppressed (EditPage.php:2134), that's why you have to set it to 0.

More broadly, edittime is clearly nullable and its type is incorrectly documented. So it's incorrect to pass it through to getRevisionByTimestamp(). getExpectedParentRevision() is documented as potentially returning null, an unlikely scenario with the current code, the effect of which is apparently harmless. Before type checks were added, a null timestamp would have caused it to return null due to the Revision::loadFromTimestamp query returning no rows.

Change 685179 had a related patch set uploaded (by Tim Starling; author: Tim Starling):

[mediawiki/core@master] EditPage::getExpectedParentRevision(): guard against null edittime

https://gerrit.wikimedia.org/r/685179

gerritbot added a project: Patch-For-Review.May 5 2021, 1:43 AM

Change 685179 merged by jenkins-bot:

[mediawiki/core@master] EditPage::getExpectedParentRevision(): guard against null edittime

https://gerrit.wikimedia.org/r/685179

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.5; 2021-05-11).May 6 2021, 3:00 AM

Maintenance_bot removed a project: Patch-For-Review.May 6 2021, 3:10 AM

AnnaMikla moved this task from Doing (S&F WIP:2) to Waiting for deployment on the Platform Team Workboards (Clinic Duty Team) board.May 7 2021, 7:27 AM

AnnaMikla subscribed.May 10 2021, 10:57 AM

Presumably fixed.

• AMooney moved this task from Waiting for deployment to Done on the Platform Team Workboards (Clinic Duty Team) board.May 25 2021, 2:20 PM

EditPage: Argument 2 passed to MediaWiki\Revision\RevisionStore::getRevisionByTimestamp() must be of the type string, null givenClosed, ResolvedPublicPRODUCTION ERRORActions