Page MenuHomePhabricator
Create Task
Maniphest T277222

Create job to tally elections [M]
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

This should be kicked off at the time someone tries to tally. The job should write the results to the securepoll_properties in JSON format. The UI does not respond to this job at the moment.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Create job to tally electionsmediawiki/extensions/SecurePollmaster+342 -155
Tally elections via DeferredUpdate to avoid timeoutmediawiki/extensions/SecurePollmaster+306 -13
Customize query in gerrit

Related Objects
Search...

Event Timeline

STran created this task.Mar 11 2021, 7:48 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 11 2021, 7:48 PM
STran set the point value for this task to 5.Mar 11 2021, 7:49 PM
Tchanders updated the task description. (Show Details)Mar 11 2021, 8:42 PM
Tchanders added a subtask: T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it.
Tchanders added a parent task: T277224: Check on TallyPage.php for tally results and display them.
Tchanders added a project: Anti-Harassment-Team (The Letter Song).Mar 11 2021, 8:47 PM
Tchanders claimed this task.Mar 12 2021, 12:40 PM
Tchanders moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.
gerritbot added a comment.Mar 19 2021, 9:25 PM

Change 673601 had a related patch set uploaded (by Tchanders; owner: Tchanders):
[mediawiki/extensions/SecurePoll@master] WIP Introduce job for tallying large encrypted elections

https://gerrit.wikimedia.org/r/673601

gerritbot added a project: Patch-For-Review.Mar 19 2021, 9:25 PM
Tchanders moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Mar 19 2021, 9:25 PM
Tchanders mentioned this in T278260: Show errors on TallyPage if job fails.Mar 23 2021, 7:50 PM
gerritbot added a comment.Mar 25 2021, 3:28 PM

Change 673601 merged by jenkins-bot:
[mediawiki/extensions/SecurePoll@master] Tally elections via DeferredUpdate to avoid timeout

https://gerrit.wikimedia.org/r/673601

Tchanders moved this task from Code Review 🔍 to Done: Q3 (2020-2021) on the Anti-Harassment-Team (The Letter Song) board.Mar 25 2021, 3:29 PM
Tchanders added a subscriber: dom_walden.

Note that we went with a DeferredUpdate in the end, since we've been told admins may want to tally and re-tally, so waiting for a job each time wouldn't be great.

@dom_walden I think the easiest way to test this would be via T277224, but feel free to move back to QA column if you disagree!

Niharika closed subtask T277221: Add getJSONMethod to ElectionTallier and Tallier and make getHTMLResult use it as Resolved.Mar 30 2021, 2:30 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 30 2021, 3:10 PM
Niharika closed this task as Resolved.Apr 1 2021, 2:40 PM
Niharika triaged this task as Medium priority.
Tchanders mentioned this in T280275: Investigate why tallying a large, encrypted election did not complete on votewiki when kicked off via the tally page [8h].May 7 2021, 9:41 AM
Niharika reopened this task as Open.May 11 2021, 5:53 PM
Niharika edited projects, added Anti-Harassment-Team; removed Anti-Harassment-Team (The Letter Song).
Niharika moved this task from Untriaged to Triage/To be Estimated on the Anti-Harassment-Team board.May 11 2021, 5:56 PM
Niharika subscribed.

Revived this following the conversation in T280275: Investigate why tallying a large, encrypted election did not complete on votewiki when kicked off via the tally page [8h].

Tchanders added a comment.May 26 2021, 4:26 PM

We should be able to start from this old patch set: https://gerrit.wikimedia.org/r/c/mediawiki/extensions/SecurePoll/+/673601/2

ARamirez_WMF renamed this task from Create job to tally elections to Create job to tally elections [M].May 26 2021, 4:27 PM
ARamirez_WMF moved this task from Triage/To be Estimated to Cards ready for development on the Anti-Harassment-Team board.
Tchanders removed Tchanders as the assignee of this task.Jun 1 2021, 4:36 AM
Tchanders subscribed.
ARamirez_WMF moved this task from Cards ready for development to The Letter Song on the Anti-Harassment-Team board.Jun 2 2021, 4:27 PM
ARamirez_WMF edited projects, added Anti-Harassment-Team (The Letter Song); removed Anti-Harassment-Team.
Niharika moved this task from Done: Q3 (2020-2021) to Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) on the Anti-Harassment-Team (The Letter Song) board.Jun 2 2021, 4:31 PM
• AGueyte claimed this task.Jun 2 2021, 6:17 PM
• AGueyte moved this task from Ready 🎬 (ONLY IF YOU HAVE NO MORE CODE TO REVIEW) to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.
gerritbot added a comment.Jun 7 2021, 10:19 PM

Change 698629 had a related patch set uploaded (by AGueyte; author: AGueyte):

[mediawiki/extensions/SecurePoll@master] Create job to tally elections

https://gerrit.wikimedia.org/r/698629

gerritbot added a project: Patch-For-Review.Jun 7 2021, 10:19 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jun 11 2021, 6:33 PM
• AGueyte moved this task from Code Review 🔍 to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Jun 28 2021, 4:51 PM
• AGueyte moved this task from In Progress 💪 to Code Review 🔍 on the Anti-Harassment-Team (The Letter Song) board.Jul 2 2021, 3:47 PM
gerritbot added a comment.Aug 2 2021, 1:13 PM

Change 698629 merged by jenkins-bot:

[mediawiki/extensions/SecurePoll@master] Create job to tally elections

https://gerrit.wikimedia.org/r/698629

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.17; 2021-08-02).Aug 2 2021, 2:00 PM
Maintenance_bot removed a project: Patch-For-Review.Aug 2 2021, 2:10 PM
STran moved this task from Code Review 🔍 to QA/Testing 🐞 on the Anti-Harassment-Team (The Letter Song) board.Aug 2 2021, 4:28 PM
dom_walden mentioned this in T287894: SecurePoll: allow STV elections to be tallied from the cli.Aug 2 2021, 5:22 PM
dom_walden moved this task from QA/Testing 🐞 to In Progress 💪 on the Anti-Harassment-Team (The Letter Song) board.Aug 9 2021, 12:07 PM

For greater visibility, I am moving this back into In Progress.

So far, I have not been able to successfully tally an encrypted election with 1000 votes (https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632)

dom_walden added a comment.Aug 10 2021, 10:21 AM

I started 4 tallying jobs one after the other, but they all appear to be stuck:

(they are all unencrypted, 5000 votes).

I started them while https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632 still had tally-job-enqueued=1 in the DB (tally-ongoing was not set). I have deleted that row from the DB but the jobs still appear stuck.

Niharika added a comment.Aug 10 2021, 5:01 PM
In T277222#7271730, @dom_walden wrote:

I started 4 tallying jobs one after the other, but they all appear to be stuck:

(they are all unencrypted, 5000 votes).

I started them while https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632 still had tally-job-enqueued=1 in the DB (tally-ongoing was not set). I have deleted that row from the DB but the jobs still appear stuck.

@dom_walden do they also fail to tally if we try to tally them from the cli?

• AGueyte added a comment.Aug 10 2021, 7:06 PM

Bugs addressed in this ticket: https://phabricator.wikimedia.org/T288361

• AGueyte added a subtask: T288361: SecurePoll: Tallying an encrypted election on votewiki produces no results.Aug 10 2021, 7:07 PM
• AGueyte moved this task from In Progress 💪 to Done: Q1 (2021-22) on the Anti-Harassment-Team (The Letter Song) board.
dom_walden added a comment.Aug 11 2021, 8:28 AM
In T277222#7272875, @Niharika wrote:
In T277222#7271730, @dom_walden wrote:

I started 4 tallying jobs one after the other, but they all appear to be stuck:

(they are all unencrypted, 5000 votes).

I started them while https://vote.wikimedia.beta.wmflabs.org/wiki/Special:SecurePoll/tally/632 still had tally-job-enqueued=1 in the DB (tally-ongoing was not set). I have deleted that row from the DB but the jobs still appear stuck.

@dom_walden do they also fail to tally if we try to tally them from the cli?

@Niharika They all successfully tally if I do it from the CLI.

Reedy mentioned this in T288712: Why are numerous Crypt functions static and called non statically?.Aug 12 2021, 3:17 AM
Niharika closed this task as Resolved.Aug 16 2021, 11:15 PM
Niharika closed subtask T288361: SecurePoll: Tallying an encrypted election on votewiki produces no results as Resolved.Sep 20 2021, 6:17 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits