Page MenuHomePhabricator
Create Task
Maniphest T277270

Help panel CTA interferes with Add Link plugin
Closed, InvalidPublic
Actions

Description

On mobile, tapping a link-recommendation task takes you to the article in edit mode; the help panel CTA floats above the add link inspector.

Maybe we should only show the help panel CTA if the user taps the "X" at the top right of the inspector:

image.png (292×588 px, 31 KB)

But then the user has no obvious way to access help.

Proposal:

  • Place a "?" icon next to the "X" in the top right of the inspector, and tapping the "?" opens the help panel.
  • Closing the link inspector (by tapping the X) shows the regular, circular help panel CTA

Related Objects
Search...

Event Timeline

kostajh created this task.Mar 12 2021, 8:26 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2021, 8:26 AM
kostajh added a parent task: T261396: Add a link: engineering tasks for initial release.Mar 12 2021, 8:27 AM
kostajh moved this task from Incoming to Needs Design/Design Doing on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh added a subscriber: RHo.

cc @RHo for design specifications.

kostajh updated the task description. (Show Details)Mar 12 2021, 8:28 AM
kostajh mentioned this in T276508: Add a link: task should open the article in edit mode.Mar 12 2021, 8:34 AM
RHo moved this task from Needs Design/Design Doing to Ready for Development on the Growth-Team (Sprint 0 (Growth Team)) board.EditedMar 12 2021, 9:54 AM

hi @kostajh - yes, I've accounted for this in the mobile designs where the help panel is not shown, and there is a "?" icon in the header instead. This is mentioned in T269644 and also the subtask T269654.
See

image.png (681×598 px, 133 KB)
and the mobile figma mocks and spec here: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65

Note by the way that the link inspector bottom card should *not* be closeable as is currently shown in the work-in-progress screenshot posted on this task description.

kostajh closed this task as Invalid.Mar 12 2021, 9:56 AM
In T277270#6907836, @RHo wrote:

hi @kostajh - yes., I've accounted for this in the mobile designs where the help panel is not shown, and there is a "?" icon in the header instead. This is mentioned in T269644 and also the subtask T269654.
See

image.png (681×598 px, 133 KB)
and the mobile figma mocks and spec here: https://www.figma.com/file/2SONd8P1tsexIB5coMOp8h/Growth-Structured-tasks?node-id=181%3A65

Note by the way that the link inspector bottom card should *not* be closeable as is currently shown in the work-in-progress screenshot posted on this task description.

Ah, OK. Sorry I was just looking at the prototype, should have checked the actual phab tasks. I'll mark this as invalid since it's covered in those two tasks.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL