Page MenuHomePhabricator
Create Task
Maniphest T277304

Move WikibaseClient PrefetchingTermLookup to service container
Closed, ResolvedPublic
Actions

Description

Can be done after T276952: WikibaseClient: Move WikibaseServices to service container.

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Move WikibaseClient PrefetchingTermLookup to service containermediawiki/extensions/Wikibasemaster+55 -13
Introduce PrefetchingTermLookupFactory servicemediawiki/extensions/Wikibasemaster+61 -0
Introduce SingleEntitySourceServicesFacrtory Servicemediawiki/extensions/Wikibasemaster+102 -47
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 12 2021, 3:40 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 12 2021, 3:40 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.Mar 12 2021, 3:40 PM
Lucas_Werkmeister_WMDE claimed this task.Mar 15 2021, 4:18 PM
Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
Lucas_Werkmeister_WMDE removed Lucas_Werkmeister_WMDE as the assignee of this task.Mar 15 2021, 4:22 PM
Lucas_Werkmeister_WMDE moved this task from Doing to Waiting for other services on the Wikibase Service Migration board.

On second thought, let’s wait with this until T277314 is done, otherwise we’ll probably end up writing the same service wiring twice.

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 16 2021, 4:27 PM
ItamarWMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Mar 18 2021, 4:17 PM
ItamarWMDE mentioned this in T277856: Remove PrefetchingTermLookup from WikibaseServices.Mar 19 2021, 10:23 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.Mar 19 2021, 2:02 PM
ItamarWMDE moved this task from Doing to Ready to pick up on the Wikibase Service Migration board.
ItamarWMDE claimed this task.Mar 19 2021, 2:04 PM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Mar 19 2021, 2:56 PM

Change 673506 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Introduce SingleEntitySourceServicesFacrtory Service

https://gerrit.wikimedia.org/r/673506

gerritbot added a project: Patch-For-Review.Mar 19 2021, 2:56 PM
gerritbot added a comment.Mar 19 2021, 3:11 PM

Change 673513 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Introduce PrefetchingTermLookupFactory service

https://gerrit.wikimedia.org/r/673513

gerritbot added a comment.Mar 19 2021, 3:26 PM

Change 673516 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Move WikibaseClient PrefetchingTermLookup to service container

https://gerrit.wikimedia.org/r/673516

ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Mar 19 2021, 3:30 PM
ItamarWMDE mentioned this in T277897: WikibaseClient: Move TermBuffer to service container.Mar 19 2021, 5:48 PM
ItamarWMDE mentioned this in T277898: WikibaseClient: Move TermLookup to service container.
gerritbot added a comment.Mar 19 2021, 6:10 PM

Change 673506 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce SingleEntitySourceServicesFacrtory Service

https://gerrit.wikimedia.org/r/673506

gerritbot added a comment.Mar 19 2021, 6:47 PM

Change 673513 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Introduce PrefetchingTermLookupFactory service

https://gerrit.wikimedia.org/r/673513

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 7:00 PM
gerritbot added a comment.Mar 19 2021, 7:09 PM

Change 673516 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move WikibaseClient PrefetchingTermLookup to service container

https://gerrit.wikimedia.org/r/673516

ItamarWMDE moved this task from Up for review to Done on the Wikibase Service Migration board.Mar 19 2021, 7:12 PM
ItamarWMDE closed this task as Resolved.Mar 22 2021, 8:57 AM
ItamarWMDE mentioned this in T277731: WikibaseRepo + WikibaseClient: Remove SingleEntitySourceServicesFactory Service.Apr 28 2021, 10:15 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits