Page MenuHomePhabricator

Move WikibaseRepo PrefetchingTermLookup to service container
Closed, ResolvedPublic

Event Timeline

Change 671198 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getWikibaseServices() calls

https://gerrit.wikimedia.org/r/671198

Change 671198 had a related patch set uploaded (by Lucas Werkmeister (WMDE); owner: Lucas Werkmeister (WMDE)):
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getWikibaseServices() calls

https://gerrit.wikimedia.org/r/671198

This is only related to this task, but I wanted to upload it early so Itamar could take a look.

This is only related to this task, but I wanted to upload it early so Itamar could take a look.

Oooh, thank for the heads up, you know how much I love removing code (especially if it includes Reflections 👹 )

I am still unsure how to migrate this service from MultipleEntitySourceServices As this srvice depends on a collection of SingleSourceServices objects which are not available in the static WikibaseRepo class.

My expectation was that the combined wiring of MultipleEntitySourceServices and SingleSourceServices would move into WikibaseRepo.ServiceWiring.php.

Change 671198 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update WikibaseRepo::getWikibaseServices() calls

https://gerrit.wikimedia.org/r/671198

Change 673018 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo PrefetchingTermLookup to service container

https://gerrit.wikimedia.org/r/673018

Change 673021 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/PropertySuggester@master] Update getPrefetchingTermLookup calls to static method

https://gerrit.wikimedia.org/r/673021

Change 673023 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update getPrefetchingTermLookup calls to static method

https://gerrit.wikimedia.org/r/673023

Change 673060 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/WikibaseLexeme@master] Update teardown code to reset the PrefetchingTermLook service

https://gerrit.wikimedia.org/r/673060

Change 673042 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Create Factory classes for PrefetchingTermLookup and SingleEntitySourceServices

https://gerrit.wikimedia.org/r/673042

Change 673204 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/Wikibase@master] Stop passing SingleEntitySourceServices into prefetching callbacks

https://gerrit.wikimedia.org/r/673204

Change 673205 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/WikibaseMediaInfo@master] Update prefetching term lookup callback

https://gerrit.wikimedia.org/r/673205

Change 673279 had a related patch set uploaded (by Itamar Givon; owner: Itamar Givon):
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily remove type hinting

https://gerrit.wikimedia.org/r/673279

Change 673279 merged by jenkins-bot:
[mediawiki/extensions/WikibaseMediaInfo@master] Temporarily remove type hinting

https://gerrit.wikimedia.org/r/673279

Change 673018 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Move WikibaseRepo PrefetchingTermLookup to service container

https://gerrit.wikimedia.org/r/673018

Change 673023 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexemeCirrusSearch@master] Update getPrefetchingTermLookup calls to static method

https://gerrit.wikimedia.org/r/673023

Change 673060 merged by jenkins-bot:
[mediawiki/extensions/WikibaseLexeme@master] Update teardown code to reset the PrefetchingTermLook service

https://gerrit.wikimedia.org/r/673060

Change 673021 merged by jenkins-bot:
[mediawiki/extensions/PropertySuggester@master] Update getPrefetchingTermLookup calls to static method

https://gerrit.wikimedia.org/r/673021

Change 673042 merged by jenkins-bot:
[mediawiki/extensions/Wikibase@master] Create factories for PrefetchingTermLookup and SingleEntitySourceServices

https://gerrit.wikimedia.org/r/673042