Page MenuHomePhabricator

Lower WVUI Typeahead Search debounce time to 120ms (matching legacy search debounce time)
Closed, ResolvedPublic

Description

The WVUI typeahead search component currently uses a 200ms debounce time: https://github.com/wikimedia/wvui/blob/a0b56d0b82668e53da2ce3ca38e58fa62b8b3c0a/src/components/typeahead-search/TypeaheadSearch.constants.ts#L4

Legacy search (mediawiki.searchSuggest) uses 120ms debounce time:
https://github.com/wikimedia/mediawiki/blob/973f733b5e25cf1815a856e277ff17cb48e3aa8b/resources/src/jquery/jquery.suggestions.js#L606

I don't see a reason for WVUI debounce time to be larger than the debounce time legacy search uses. At the very least, setting the debounce times to the same value would make it easier to compare the "Search Load Start to First Render" metric in the search performance dashboard: https://grafana.wikimedia.org/d/GivPpdsGk/vue-vs-legacy-search?orgId=1

It might make the search results feel more responsive as well.

QA steps

  • Ensure typing into search input still renders search results

Acceptance Criteria

  • Debounce time is set to 120ms

Event Timeline

Assigning this to @cjming since it will get her more familiar with the WVUI project (including its setup) and the gerrit workflow

Change 674690 had a related patch set uploaded (by Nray; author: Nray):
[mediawiki/extensions/WikimediaEvents@master] Add new test file

https://gerrit.wikimedia.org/r/674690

Change 674696 had a related patch set uploaded (by Nray; author: Nray):
[mediawiki/skins/Vector@master] A change that depends on wikimedia-events

https://gerrit.wikimedia.org/r/674696

Change 674696 abandoned by Nray:
[mediawiki/skins/Vector@master] A change that depends on wikimedia-events

Reason:
Showing Clare

https://gerrit.wikimedia.org/r/674696

Change 674696 restored by Nray:
[mediawiki/skins/Vector@master] A change that depends on wikimedia-events

https://gerrit.wikimedia.org/r/674696

Change 674696 abandoned by Nray:
[mediawiki/skins/Vector@master] A change that depends on wikimedia-events

Reason:
Showing Clare again

https://gerrit.wikimedia.org/r/674696

Change 674690 abandoned by Nray:
[mediawiki/extensions/WikimediaEvents@master] Add new test file

Reason:
Showing clare

https://gerrit.wikimedia.org/r/674690

^^ lol Sorry for the spam on this ticket. Was demonstrating the gerrit workflow to Clare :)

Change 674709 had a related patch set uploaded (by Clare Ming; author: Clare Ming):
[wvui@master] Update debounce interval.

https://gerrit.wikimedia.org/r/674709

Change 674709 merged by jenkins-bot:
[wvui@master] Update debounce interval.

https://gerrit.wikimedia.org/r/674709

Congratulations @cjming! Usually once the ticket has been merged, you'd ensure QA steps have been written and move the ticket to the "Needs QA" column for Edward to review but since this patch involves minimal risk, I think this can be safely moved to the sign off column instead

nray removed cjming as the assignee of this task.Mar 24 2021, 9:16 PM
nray added a subscriber: cjming.

@Edtadros: As discussed, you'll need to test this on your local development environment. You'll need to follow the (excellent) instructions in order to do that.

phuedx closed this task as Resolved.EditedApr 7 2021, 3:21 PM

@Edtadros: As discussed, you'll need to test this on your local development environment. You'll need to follow the (excellent) instructions in order to do that.

Scratch that! This LGTM (and is low-enough risk, per @nray's comment above, that I feel confident signing this off as is).

This will be deployed alongside the patch(es) for T277256: Bangla letters are getting broken in the search box , during which we'll release a new version of WVUI and let it ride the train.

Change 682196 had a related patch set uploaded (by VolkerE; author: VolkerE):

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196

Change 682196 merged by jenkins-bot:

[mediawiki/core@master] Update WVUI to v0.1.1

https://gerrit.wikimedia.org/r/682196