Page MenuHomePhabricator

[MEP] [BUG] dt field in migrated client-side EventLogging schemas is not set to meta.dt
Closed, ResolvedPublic

Description

The semantics of the dt field in migrated EventLogging schemas was discussed in T240460. Based on T240460#6631622 the conclusion was that the semantics of dt should be consistent when migrating, which means that it should always reflect the time the server received the event. Based on the output table in T277253 (where meta.dt is renamed to serverside_dt) this is not the case, it's instead set to client_dt (which is what's expected of MEP schemas).

This appears to only affect client-side schemas, as a similar table for a server-side schema as seen in T276235 does not have this issue.

Event Timeline

Change 672454 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/EventLogging@master] [BUG] Prevents 'dt' field being set by client in legacy events.

https://gerrit.wikimedia.org/r/672454

Update: this has been confirmed as a bug, since dt should be server-side for legacy schemas (migrated or not), and client-side for new/modern schemas (cf. T240460#6614767 & T240460#6614779)

@Mholloway has suggested replacing meta.dt and dt with server_dt and client_dt, respectively.

Change 672498 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Do not set dt field for migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672498

Change 672454 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] [BUG] Prevents 'dt' field being set by client in legacy events.

https://gerrit.wikimedia.org/r/672454

Change 672498 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Do not set dt field for migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672498

Change 672782 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672782

Change 672787 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (JS)

https://gerrit.wikimedia.org/r/672787

fdans moved this task from Incoming to Event Platform on the Analytics board.

Change 672787 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (JS)

https://gerrit.wikimedia.org/r/672787

Change 672782 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672782

kzimmerman added a subscriber: kzimmerman.

Morten is going to re-run queries that identified this issue in the first place, I asked him to timebox the investigation to 30 minutes and then follow up with us.

I've rerun my queries to check the timestamps in HomepageModule, EditAttemptSteps, and VisualEditorFeatureUse as those were the client-side schemas that previously had issues. In all of those dt now matches meta.dt as expected. Closing this task as resolved, thanks for fixing this!