Page MenuHomePhabricator
Create Task
Maniphest T277330

[MEP] [BUG] dt field in migrated client-side EventLogging schemas is not set to meta.dt
Closed, ResolvedPublic
Actions

Description

The semantics of the dt field in migrated EventLogging schemas was discussed in T240460. Based on T240460#6631622 the conclusion was that the semantics of dt should be consistent when migrating, which means that it should always reflect the time the server received the event. Based on the output table in T277253 (where meta.dt is renamed to serverside_dt) this is not the case, it's instead set to client_dt (which is what's expected of MEP schemas).

This appears to only affect client-side schemas, as a similar table for a server-side schema as seen in T276235 does not have this issue.

Details

SubjectRepoBranchLines +/-
Unset dt in migrated legacy events (JS)mediawiki/extensions/EventLoggingmaster+6 -3
Unset dt in migrated legacy events (PHP)mediawiki/extensions/EventLoggingmaster+45 -23
Do not set dt field for migrated legacy events (PHP)mediawiki/extensions/EventLoggingmaster+89 -8
[BUG] Prevents 'dt' field being set by client in legacy events.mediawiki/extensions/EventLoggingmaster+13 -7
Customize query in gerrit

Related Objects

Event Timeline

nettrom_WMF created this task.Mar 12 2021, 6:42 PM
LGoto moved this task from Triage to Tracking on the Product-Analytics board.Mar 15 2021, 4:12 PM
gerritbot added a comment.Mar 15 2021, 4:27 PM

Change 672454 had a related patch set uploaded (by Jason Linehan; owner: Jason Linehan):
[mediawiki/extensions/EventLogging@master] [BUG] Prevents 'dt' field being set by client in legacy events.

https://gerrit.wikimedia.org/r/672454

gerritbot added a project: Patch-For-Review.Mar 15 2021, 4:27 PM
mpopov subscribed.Mar 15 2021, 4:27 PM
mpopov added a subscriber: • Mholloway.Mar 15 2021, 4:47 PM

Update: this has been confirmed as a bug, since dt should be server-side for legacy schemas (migrated or not), and client-side for new/modern schemas (cf. T240460#6614767 & T240460#6614779)

@Mholloway has suggested replacing meta.dt and dt with server_dt and client_dt, respectively.

gerritbot added a comment.Mar 15 2021, 6:12 PM

Change 672498 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Do not set dt field for migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672498

gerritbot added a comment.Mar 15 2021, 9:02 PM

Change 672454 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] [BUG] Prevents 'dt' field being set by client in legacy events.

https://gerrit.wikimedia.org/r/672454

gerritbot added a comment.Mar 15 2021, 9:40 PM

Change 672498 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Do not set dt field for migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672498

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 15 2021, 10:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 15 2021, 10:10 PM
gerritbot added a comment.Mar 16 2021, 7:01 PM

Change 672782 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672782

gerritbot added a project: Patch-For-Review.Mar 16 2021, 7:01 PM
gerritbot added a comment.Mar 16 2021, 7:48 PM

Change 672787 had a related patch set uploaded (by Mholloway; owner: Michael Holloway):
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (JS)

https://gerrit.wikimedia.org/r/672787

• fdans triaged this task as High priority.Mar 18 2021, 4:56 PM
• fdans moved this task from Incoming to Event Platform on the Analytics board.
gerritbot added a comment.Mar 22 2021, 3:42 PM

Change 672787 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (JS)

https://gerrit.wikimedia.org/r/672787

gerritbot added a comment.Mar 22 2021, 3:42 PM

Change 672782 merged by jenkins-bot:
[mediawiki/extensions/EventLogging@master] Unset dt in migrated legacy events (PHP)

https://gerrit.wikimedia.org/r/672782

ReleaseTaggerBot edited projects, added MW-1.36-notes (1.36.0-wmf.36; 2021-03-23); removed MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 22 2021, 4:00 PM
Maintenance_bot removed a project: Patch-For-Review.Mar 22 2021, 4:10 PM
• jlinehan added a project: Better Use Of Data.Mar 24 2021, 6:22 PM
LGoto assigned this task to kzimmerman.Mar 24 2021, 6:24 PM
LGoto moved this task from Inbox to QA/Review on the Better Use Of Data board.
kzimmerman reassigned this task from kzimmerman to nettrom_WMF.Mar 24 2021, 9:43 PM
kzimmerman subscribed.

Morten is going to re-run queries that identified this issue in the first place, I asked him to timebox the investigation to 30 minutes and then follow up with us.

nettrom_WMF closed this task as Resolved.Mar 25 2021, 3:40 PM

I've rerun my queries to check the timestamps in HomepageModule, EditAttemptSteps, and VisualEditorFeatureUse as those were the client-side schemas that previously had issues. In all of those dt now matches meta.dt as expected. Closing this task as resolved, thanks for fixing this!

kzimmerman moved this task from QA/Review to Sign-off on the Better Use Of Data board.Mar 25 2021, 4:34 PM

Thanks so much, @nettrom_WMF !

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL