Page MenuHomePhabricator
Create Task
Maniphest T277332

Uncaught Error: Widget not found / Call to a member function getNsIndex() on null on CirrusSearch result page with internal error
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

When I visit https://en.wikipedia.beta.wmflabs.org/w/index.php?search=weak+power+law&title=Special%3ASearch&profile=advanced&fulltext=1&advancedSearch-current=%7B%22fields%22%3A%7B%22phrase%22%3A%22weak+power+law%22%7D%7D&ns0=1&ns1=1&ns2=1&ns3=1&ns4=1&ns5=1&ns6=1&ns7=1&ns8=1&ns9=1&ns10=1&ns11=1&ns12=1&ns13=1&ns14=1&ns15=1&ns100=1&ns101=1&ns108=1&ns109=1&ns118=1&ns119=1&ns190=1&ns191=1&ns446=1&ns447=1&ns482=1&ns483=1&ns710=1&ns711=1&ns810=1&ns811=1&ns828=1&ns829=1&ns2300=1&ns2301=1&ns2302=1&ns2303=1&ns5500=1&ns5501=1
I also see the error Uncaught Error: Widget not found in my JS console.

Screen Shot 2021-03-12 at 11.06.45 AM.png (1×2 px, 698 KB)

Backtrace:

from /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Rescore/NamespacesFunctionScoreBuilder.php(54)
#0 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Rescore/FunctionScoreChain.php(163): CirrusSearch\Search\Rescore\NamespacesFunctionScoreBuilder->__construct(CirrusSearch\HashSearchConfig, array, integer)
#1 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Rescore/FunctionScoreChain.php(109): CirrusSearch\Search\Rescore\FunctionScoreChain->getImplementation(array)
#2 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Rescore/RescoreBuilder.php(122): CirrusSearch\Search\Rescore\FunctionScoreChain->buildRescoreQuery()
#3 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/Rescore/RescoreBuilder.php(100): CirrusSearch\Search\Rescore\RescoreBuilder->buildRescoreQuery(array)
#4 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/SearchContext.php(531): CirrusSearch\Search\Rescore\RescoreBuilder->build()
#5 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Search/SearchRequestBuilder.php(98): CirrusSearch\Search\SearchContext->getRescore()
#6 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/Searcher.php(488): CirrusSearch\Search\SearchRequestBuilder->build()
#7 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/InterwikiSearcher.php(99): CirrusSearch\Searcher->buildSearch()
#8 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(316): CirrusSearch\InterwikiSearcher->getInterwikiResults(CirrusSearch\Search\SearchQuery)
#9 /srv/mediawiki/php-master/extensions/CirrusSearch/includes/CirrusSearch.php(269): CirrusSearch\CirrusSearch->searchTextReal(CirrusSearch\Search\SearchQuery)
#10 /srv/mediawiki/php-master/includes/search/SearchEngine.php(95): CirrusSearch\CirrusSearch->doSearchText(string)
#11 /srv/mediawiki/php-master/includes/search/SearchEngine.php(187): SearchEngine->{closure}()
#12 /srv/mediawiki/php-master/includes/search/SearchEngine.php(96): SearchEngine->maybePaginate(Closure)
#13 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(445): SearchEngine->searchText(string)
#14 /srv/mediawiki/php-master/includes/specials/SpecialSearch.php(229): SpecialSearch->showResults(string)
#15 /srv/mediawiki/php-master/includes/specialpage/SpecialPage.php(646): SpecialSearch->execute(NULL)
#16 /srv/mediawiki/php-master/includes/specialpage/SpecialPageFactory.php(1375): SpecialPage->run(NULL)
#17 /srv/mediawiki/php-master/includes/MediaWiki.php(309): MediaWiki\SpecialPage\SpecialPageFactory->executePath(Title, RequestContext)
#18 /srv/mediawiki/php-master/includes/MediaWiki.php(925): MediaWiki->performRequest()
#19 /srv/mediawiki/php-master/includes/MediaWiki.php(547): MediaWiki->main()
#20 /srv/mediawiki/php-master/index.php(53): MediaWiki->run()
#21 /srv/mediawiki/php-master/index.php(46): wfIndexMain()
#22 /srv/mediawiki/w/index.php(3): require(string)
#23 {main}

On such pages the JS shouldn't be executed at all. The client perhaps should consider this as part of it's startup execution.

https://logstash.wikimedia.org/app/dashboards#/doc/logstash-*/logstash-2021.03.12?id=nYLlJXgBWKe2MTdRJMKN

Details

SubjectRepoBranchLines +/-
Remove namespace name handling from NamespaceWeightsmediawiki/extensions/CirrusSearchmaster+12 -28
Expand CirrusSearchNamespaceWeights with explicit ns numbersoperations/mediawiki-configmaster+44 -3
Customize query in gerrit

Related Objects

Event Timeline

Jdlrobson created this task.Mar 12 2021, 7:08 PM
Restricted Application added a project: Discovery-Search. · View Herald TranscriptMar 12 2021, 7:08 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
MPhamWMF moved this task from needs triage to Current work on the Discovery-Search board.Mar 15 2021, 3:23 PM
MPhamWMF edited projects, added Discovery-Search (Current work); removed Discovery-Search.
MPhamWMF set the point value for this task to 2.Mar 15 2021, 3:56 PM
MPhamWMF moved this task from Incoming to Ready for Dev -- SWE on the Discovery-Search (Current work) board.
EBernhardson subscribed.Mar 15 2021, 3:56 PM

Reasonable chance this is because we are pulling ContLang from SearchConfig, ContLang was never configuration and might no longer be accessible that way.

Ammarpad subscribed.EditedMar 16 2021, 12:56 PM
In T277332#6914184, @EBernhardson wrote:

Reasonable chance this is because we are pulling ContLang from SearchConfig, ContLang was never configuration and might no longer be accessible that way.

It was dropped recently in T245940: Hard-deprecate and remove $wgContLang, that's the immediate cause. The remote cause however, is a bug in CirrusSearch compounded by how the extension is (confusingly) re-using 'ContLang' in this context.

When the global $wgContLang was being replaced in extensions in preparation for the removal there was attempt to fix CirrusSearch gerrit:596254. See the discussion that ensued there. The patch was eventually abandoned because it was agreed at the time that CirrusSearch was not reading or the writing the value from/to the Global Config object. (I am not sure there was code change that changed that between then and now) but indeed it does at least read GlobalVarConfig::get( 'ContLang' ), as the current fatal error and the code in CirrusSearch\SearchConfig show.

EBernhardson added a comment.EditedMar 16 2021, 3:03 PM

This seems to be a misunderstanding in review, CirrusSearch uses ContLang both for local-wiki and cross-wiki behavior. When the wiki is remote Cirrus provides ContLang, but when the wiki is local it depends on the global variable to already exist. I suspect the misunderstanding revolves around how cirrus queries indices and returns results for any wiki in the cluster, and not only the local wiki being queried.

gerritbot added a comment.Mar 16 2021, 5:13 PM

Change 672761 had a related patch set uploaded (by Ebernhardson; owner: Ebernhardson):
[operations/mediawiki-config@master] Expand CirrusSearchNamespaceWeights with explicit ns numbers

https://gerrit.wikimedia.org/r/672761

gerritbot added a project: Patch-For-Review.Mar 16 2021, 5:13 PM
gerritbot added a comment.Mar 16 2021, 5:48 PM

Change 672770 had a related patch set uploaded (by Ebernhardson; owner: Ebernhardson):
[mediawiki/extensions/CirrusSearch@master] Remove namespace name handling from NamespaceWeights

https://gerrit.wikimedia.org/r/672770

gerritbot added a comment.Mar 16 2021, 11:19 PM

Change 672761 merged by jenkins-bot:
[operations/mediawiki-config@master] Expand CirrusSearchNamespaceWeights with explicit ns numbers

https://gerrit.wikimedia.org/r/672761

Stashbot added a comment.Mar 16 2021, 11:22 PM

Mentioned in SAL (#wikimedia-operations) [2021-03-16T23:22:31Z] <krinkle@deploy1002> Synchronized wmf-config/InitialiseSettings.php: Icd6635cb302cc, T277332 (duration: 00m 58s)

Ammarpad unsubscribed.Mar 17 2021, 5:01 AM
EBernhardson claimed this task.Mar 17 2021, 7:46 PM
EBernhardson moved this task from Ready for Dev -- SWE to Needs review on the Discovery-Search (Current work) board.
gerritbot added a comment.Mar 18 2021, 9:01 AM

Change 672770 merged by jenkins-bot:
[mediawiki/extensions/CirrusSearch@master] Remove namespace name handling from NamespaceWeights

https://gerrit.wikimedia.org/r/672770

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2021, 9:10 AM
ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 18 2021, 10:00 AM
EBernhardson moved this task from Needs review to Needs Reporting on the Discovery-Search (Current work) board.Mar 23 2021, 6:54 PM
Gehel closed this task as Resolved.Mar 24 2021, 1:28 PM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Jun 23 2022, 4:06 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL