Special:OAuthConsumerRegistration gives unhelpful error message if logged out
Closed, ResolvedPublic
Actions

Assigned To

Authored By

	Reedy
	Mar 13 2021, 5:17 PM

Description

Screenshot 2021-03-13 at 17.14.58.png (570×1 px, 114 KB)

While it's technically correct... Anons can't have an email "validated"....

The error should first probably say the user needs to be logged in, before showing that error.

	public function userCanExecute( User $user ) {
		return $user->isEmailConfirmed();
	}

	public function displayRestrictionError() {
		throw new \PermissionsError( null, [ 'mwoauthconsumerregistration-need-emailconfirmed' ] );
	}

Details

Subject	Repo	Branch	Lines +/-
Handle logged out users on Special:OAuthConsumerRegistration	mediawiki/extensions/OAuth	REL1_35	+2 -0
Handle logged out users on Special:OAuthConsumerRegistration	mediawiki/extensions/OAuth	REL1_31	+1 -0
Handle logged out users on Special:OAuthConsumerRegistration	mediawiki/extensions/OAuth	master	+1 -0

Customize query in gerrit

Event Timeline

Reedy created this task.Mar 13 2021, 5:17 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 13 2021, 5:17 PM

Reedy renamed this task from Special:OAuthConsumerRegistration gives incorrect error if logged out to Special:OAuthConsumerRegistration gives unhelpful error message if logged out.Mar 13 2021, 5:24 PM

Change 671639 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OAuth@master] Show appropriate error message on Special:OAuthConsumerRegistration to logged out users

https://gerrit.wikimedia.org/r/671639

gerritbot added a project: Patch-For-Review.Mar 13 2021, 5:25 PM

Reedy moved this task from Backlog to Needs Review on the MediaWiki-extensions-OAuth board.Mar 13 2021, 7:05 PM

Change 671639 merged by jenkins-bot:
[mediawiki/extensions/OAuth@master] Handle logged out users on Special:OAuthConsumerRegistration

https://gerrit.wikimedia.org/r/671639

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.35; 2021-03-16).Mar 14 2021, 8:00 PM

Change 672106 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OAuth@REL1_35] Handle logged out users on Special:OAuthConsumerRegistration

https://gerrit.wikimedia.org/r/672106

Change 672107 had a related patch set uploaded (by Reedy; owner: Reedy):
[mediawiki/extensions/OAuth@REL1_31] Handle logged out users on Special:OAuthConsumerRegistration

https://gerrit.wikimedia.org/r/672107

Reedy closed this task as Resolved.Mar 14 2021, 8:07 PM

Reedy claimed this task.

Reedy triaged this task as Low priority.

Change 672107 merged by jenkins-bot:
[mediawiki/extensions/OAuth@REL1_31] Handle logged out users on Special:OAuthConsumerRegistration

https://gerrit.wikimedia.org/r/672107

Change 672106 merged by jenkins-bot:
[mediawiki/extensions/OAuth@REL1_35] Handle logged out users on Special:OAuthConsumerRegistration

https://gerrit.wikimedia.org/r/672106

Maintenance_bot removed a project: Patch-For-Review.Mar 14 2021, 9:10 PM

	F34157746: Screenshot 2021-03-13 at 17.14.58.png
	Mar 13 2021, 5:17 PM

Special:OAuthConsumerRegistration gives unhelpful error message if logged outClosed, ResolvedPublicActions

Description

Details

Event Timeline

Special:OAuthConsumerRegistration gives unhelpful error message if logged out
Closed, ResolvedPublic
Actions