Page MenuHomePhabricator

The message "feedlinks" appears to be unused
Closed, ResolvedPublic

Description

The message feedlinks in core appears to be unused. On codesearch, I can only find this string as the id of an HTML element, and in the json files of translations.

My laptop is broken at the moment and I cannot do a more thorough search in Git, so if I'm missing something and it is actually used, please mark this as invalid :)

If it's indeed unused, it should be removed from core en.json and qqq.json.

Event Timeline

It is unused.

It was last used in the PHPTAL version of MonoBook, around 2004 [1] , before it was rewritten in pure PHP. I'm not sure if it was dropped in the rewrite by accident or intentionally, but it has not been used since then as far as I can see. That code was ultimately deleted in 2006 [2].

[1] https://phabricator.wikimedia.org/source/mediawiki/change/master/skins/disabled/MonoBook.pt;f571b7e068300906fc91f571214fe9938e179f9a <span i18n:translate="string:feedlinks">Feeds:</span>
[2] 644f8a0acc834e552dd5b9b14dac485f33b2f8ba

Change 674968 had a related patch set uploaded (by Amire80; author: Amire80):
[mediawiki/core@master] Remove the unused feedlinks message

https://gerrit.wikimedia.org/r/674968

Change 674968 merged by jenkins-bot:
[mediawiki/core@master] Remove the unused feedlinks message

https://gerrit.wikimedia.org/r/674968

DannyS712 assigned this task to Amire80.