Page MenuHomePhabricator

Don't echo the db connection string at command line prompt
Open, Needs TriagePublic

Description

The migrations/ingest.py script takes a number of command line arguments.

Since this script might run on multi-user systems with interactive logins,
we should make sure that sensible data is not passed as a command line argument (and
accidentally exposed by the output of ps & c).

Event Timeline

Change 672370 had a related patch set uploaded (by Gmodena; owner: Gmodena):
[mediawiki/services/similar-users@main] Read ingest.py parameters from env variables.

https://gerrit.wikimedia.org/r/672370

Change 672370 merged by jenkins-bot:

[mediawiki/services/similar-users@main] Read ingest.py parameters from env variables.

https://gerrit.wikimedia.org/r/672370