Use qqx as content language for PHPUnit tests
Open, Needs TriagePublic
Actions

Assigned To

None

Authored By

	Daimona
	Mar 15 2021, 11:46 AM

Description

Several core tests assume that the wiki is in English, and make assertions about certain messages resolving to some hardcoded English strings. These tests will fail horribly if your wiki is not using English as content language (this is the case for me in my local environment).

I believe we should encourage developers to write tests that are not dependent on the language. A nice solution (IMHO) would be to set the content language to qqx somewhere in our PHPUnit wrapper / test runner, which would ensure consistent output.

Details

	Subject	Repo	Branch	Lines +/-
	Make a few tests not depend on English as content language	mediawiki/core	master	+145 -114
	Set the content language to qqx in PHPUnit tests	mediawiki/core	master	+4 -0

Customize query in gerrit

Related Objects

Mentioned In: T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php
T277470: Ignore (most) of LocalSettings.php when running PHPUnit (fix surprise test failures)
Mentioned Here: T277470: Ignore (most) of LocalSettings.php when running PHPUnit (fix surprise test failures)

Event Timeline

Daimona created this task.Mar 15 2021, 11:46 AM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 15 2021, 11:46 AM

Mainframe98 awarded a token.Mar 15 2021, 12:03 PM

kostajh awarded a token.Mar 15 2021, 12:12 PM

DannyS712 awarded a token.Mar 15 2021, 12:43 PM

DannyS712 subscribed.

Change 672401 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Set the content language to qqx in PHPUnit tests

https://gerrit.wikimedia.org/r/672401

gerritbot added a project: Patch-For-Review.Mar 15 2021, 2:02 PM

Daimona claimed this task.Mar 15 2021, 2:02 PM

Daimona mentioned this in T277470: Ignore (most) of LocalSettings.php when running PHPUnit (fix surprise test failures).Mar 15 2021, 2:17 PM

Change 672444 had a related patch set uploaded (by Daimona Eaytoy; owner: Daimona Eaytoy):
[mediawiki/core@master] Make a few tests not depend on English as content language

https://gerrit.wikimedia.org/r/672444

Based on the attempts above, it seems like we might find unexpected problems. The root cause for this is, I believe, the vast usage of globals in our tests. I think a first step might be setting the language to 'en'. This should be a noop for CI and should help with T277470. And then migrate to qqx for more consistent output.

kostajh mentioned this in T90875: Use vendor/bin/phpunit instead of tests/phpunit/phpunit.php.May 20 2021, 7:41 AM

Krinkle awarded a token.Aug 26 2021, 9:18 PM

Krinkle moved this task from Inbox to PHPUnit on the MediaWiki-Core-Tests board.

Change 672444 abandoned by Daimona Eaytoy:

[mediawiki/core@master] Make a few tests not depend on English as content language

Reason:

Too old

https://gerrit.wikimedia.org/r/672444

Dreamy_Jazz awarded a token.Feb 24 2023, 11:06 PM

Daimona removed Daimona as the assignee of this task.Aug 19 2023, 4:34 PM