cc @Daimona can you list any places that you are still seeing this issue?

In T277465#6913970, @Esanders wrote:

cc @Daimona can you list any places that you are still seeing this issue?

Not right now, since the backport was deployed. A few broken places which I remember from the last time I checked:

• It didn't work on itwiki (because the equivalents of {{hatnote}} and {{ambox}} use TemplateStyles, that is T277367)
• {{redirect}} on frwiki didn't work (you've already fixed this 1 hour ago)

The other malfunctionings I saw on (fr|de|es)wiki were fixed by your edits on the 13th. I haven't checked any other wiki. I think checking what wikis are broken might be relatively easy to automate:

• Get a list of localized templates from https://www.wikidata.org/wiki/Q5962027 and https://www.wikidata.org/wiki/Q5625128 (these lists should be processed separately)
• For each wiki that is on a list, request https://lang.project.org/w/api.php?action=parse&format=json&title=Main%20page&text= + urlencode( '{{<LOCAL_NAME_OF_TEMPLATE>}}' )
• Parse the resulting HTML like MoveLeadParagraphTransform does (skip style elements, verify whether the first element has "ambox" or "hatnote")

However, I think at this point it would make more sense to let communities fix what they want to. There might be additional templates, not included in Q5962027 or Q5625128, that might need to stay at the top for a certain project. Fixing everything now would likely make the JobQueue grow again.

Is this still being considered a train blocker?

No, sorry, that's just confusion over the task inheritance.

Thanks!

Change 676123 had a related patch set uploaded (by MSantos; author: MSantos):

[mediawiki/services/mobileapps@master] mobile-html: fix some hatnotes not being hoisted properly

https://gerrit.wikimedia.org/r/676123

Change 676123 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] mobile-html: fix some hatnotes not being hoisted properly

https://gerrit.wikimedia.org/r/676123

As a note, <style> is not the only tag to be looking for from TemplateStyles, <link> may be interesting as well, which is the deduplicated TemplateStyle tag rendering (today).

E.g.,

{{hatnote|Content}}
{{hatnote|Content}}
Lorem ipsum dolor...

Will have rendering along the lines of

<style mw-id=ABC/>
<div class="hatnote">Content</div>
<link mw-points-to-id=ABC/>
<div class="hatnote">Content</div>
<p>...

Change 680370 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/services/mobileapps@master] Follow-up I939ba9828: Check for <link> tag as well as <style>

https://gerrit.wikimedia.org/r/680370

Nice catch @Izno! Thanks to you and @Esanders for the patch.

Change 680370 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Follow-up I939ba9828: Check for <link> tag as well as <style>

https://gerrit.wikimedia.org/r/680370

I'm afraid we're still seeing this issue at pt.wp, for example:
https://pt.wikipedia.org/wiki/Corregedor_%28Portugal%29

The example case in the task has regressed too. It looks like there are multiple TemplateStyle tags, rather than just one which the code expects:

Change 922495 had a related patch set uploaded (by Esanders; author: Esanders):

[mediawiki/services/mobileapps@master] Skip multiple TemplateStyles tags

https://gerrit.wikimedia.org/r/922495

Change 922495 merged by jenkins-bot:

[mediawiki/services/mobileapps@master] Skip multiple TemplateStyles tags

https://gerrit.wikimedia.org/r/922495