Page MenuHomePhabricator

Add Links: answer cannot be unselected
Closed, ResolvedPublic

Description

After selecting Yes or No in the link dialog, there is no way to undo that selection - the user can select the opposite, but there is no way to return the task to its original "skipped" state. Clicking on the selected button again should unselect it.

Event Timeline

Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Etonkovidova renamed this task from Add link: the last "Skip" is disabled to Add Links: the last "Skip" is disabled.Mar 16 2021, 1:14 AM

This is part of T269658: Add a link: skipped all suggestions dialog which is not implemented yet.

Note: It seems that it's not possible to apply "Skip" state to links that were marked with "Yes" or "No".

@MMiller_WMF @RHo any thoughts about that? Should there be a way to unselect Yes/No? Should the "Skip" text removed from the navigation button if there is something selected already?

This is part of T269658: Add a link: skipped all suggestions dialog which is not implemented yet.

Note: It seems that it's not possible to apply "Skip" state to links that were marked with "Yes" or "No".

@MMiller_WMF @RHo any thoughts about that? Should there be a way to unselect Yes/No? Should the "Skip" text removed from the navigation button if there is something selected already?

Hi @Tgr, it should definitely be possible to unselect Yes/No. Perhaps naming it "Skip" state is not exactly accurate, as the state we care about is if all links are "unselected".
As for the "Skip" label on the navigation button, I think it's fine to leave as it is. We chose to name it "Skip" as it seemed to make it clearer during user testing that links did not require a decision, but the label is really more about navigation (so could in theory have been called "Next" instead).

So how should the unselection happen? Clicking again on the selected button?

So how should the unselection happen? Clicking again on the selected button?

The Yes and No buttons are toggle buttons so it would be toggle off whichever one was selected

Let's convert this task into a reminder to do that then, since the originally reported issue is already part of another task.

Tgr renamed this task from Add Links: the last "Skip" is disabled to Add Links: answer cannot be unselected.Mar 16 2021, 7:25 PM
Tgr updated the task description. (Show Details)
Etonkovidova claimed this task.

Re-checked - the "Yes/No" buttons act as toggle buttons now. Mark as Resolved.