Page MenuHomePhabricator
Create Task
Maniphest T277520

Allow extensions to specify immovable namespaces via extension.json
Closed, ResolvedPublic
Actions

Description

Currently, for extensions that add custom namespaces, if those namespaces should be immovable the only way to implement that is via the NamespaceIsMovable hook. I propose that it also be possible via extension.json when specifying namespaces, by adding a new property ismovable (defaulting to true).

The following extensions register a handler for the hook, just to say that the custom namespace added is not movable, and would benefit

  • EntitySchema (for NS_ENTITYSCHEMA_JSON)
  • Flow (for NS_TOPIC)
  • WikiLambda (for NS_ZOBJECT)

Details

Related Changes in Gerrit:
SubjectRepoBranchLines +/-
Declare ZObject namespace as not movable in extension.jsonmediawiki/extensions/WikiLambdamaster+2 -20
Declare topic namespace as not movable in extension.jsonmediawiki/extensions/Flowmaster+3 -13
Declare EntitySchema namespace as not movablemediawiki/extensions/EntitySchemamaster+2 -21
registration: Allow specifying immovable namespaces in extension.jsonmediawiki/coreREL1_35+19 -1
registry: Allow specifying immovable namespaces in extension.jsonmediawiki/coremaster+23 -1
Customize query in gerrit

Event Timeline

DannyS712 created this task.Mar 16 2021, 1:39 AM
Restricted Application added a project: User-DannyS712. · View Herald TranscriptMar 16 2021, 1:39 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
DannyS712 moved this task from Unsorted to Later on the User-DannyS712 board.Mar 16 2021, 1:40 AM
MGChecker awarded a token.Mar 16 2021, 1:43 AM
Legoktm awarded a token.Mar 16 2021, 3:30 AM
Legoktm subscribed.

It would be nice if this did not require a new global to be created and instead could be done as an attribute. Other than that, thumbs up from me.

Ammarpad subscribed.Mar 16 2021, 5:58 AM

I propose that it also be possible via extension.json when specifying namespaces, by adding a new property ismovable (defaulting to false).

There are only three namespaces with non-movable pages (per the task desc), which means the majority of namespaces are movable. So defaulting to false is not a good idea here.

gerritbot added a comment.Mar 16 2021, 1:44 PM

Change 672725 had a related patch set uploaded (by Ammarpad; owner: Ammarpad):
[mediawiki/core@master] Allow specifying immovable namespaces in extension.json

https://gerrit.wikimedia.org/r/672725

gerritbot added a project: Patch-For-Review.Mar 16 2021, 1:44 PM
DannyS712 added a comment.Mar 16 2021, 2:35 PM
In T277520#6916343, @Ammarpad wrote:

I propose that it also be possible via extension.json when specifying namespaces, by adding a new property ismovable (defaulting to false).

There are only three namespaces with non-movable pages (per the task desc), which means the majority of namespaces are movable. So defaulting to false is not a good idea here.

Yeah, I meant true, sorry

DannyS712 updated the task description. (Show Details)Mar 16 2021, 2:35 PM
gerritbot added a comment.Mar 17 2021, 6:33 AM

Change 672725 merged by jenkins-bot:
[mediawiki/core@master] registry: Allow specifying immovable namespaces in extension.json

https://gerrit.wikimedia.org/r/672725

gerritbot added a comment.Mar 17 2021, 6:40 AM

Change 672816 had a related patch set uploaded (by Legoktm; owner: Ammarpad):
[mediawiki/core@REL1_35] registry: Allow specifying immovable namespaces in extension.json

https://gerrit.wikimedia.org/r/672816

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 17 2021, 7:00 AM
gerritbot added a comment.Mar 17 2021, 7:43 AM

Change 672816 merged by jenkins-bot:
[mediawiki/core@REL1_35] registration: Allow specifying immovable namespaces in extension.json

https://gerrit.wikimedia.org/r/672816

ReleaseTaggerBot added a project: MW-1.35-notes.Mar 17 2021, 8:00 AM
Legoktm closed this task as Resolved.Mar 17 2021, 8:07 AM
Legoktm assigned this task to Ammarpad.
Maintenance_bot removed a project: Patch-For-Review.Mar 17 2021, 8:10 AM
gerritbot added a comment.Aug 17 2021, 9:14 AM

Change 713444 had a related patch set uploaded (by Lucas Werkmeister (WMDE); author: Lucas Werkmeister (WMDE)):

[mediawiki/extensions/EntitySchema@master] Declare EntitySchema namespace as not movable

https://gerrit.wikimedia.org/r/713444

gerritbot added a project: Patch-For-Review.Aug 17 2021, 9:14 AM
gerritbot added a comment.Aug 17 2021, 9:22 AM

Change 713359 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/WikiLambda@master] Declare ZObject namespace as not movable in extension.json

https://gerrit.wikimedia.org/r/713359

gerritbot added a comment.Aug 17 2021, 9:25 AM

Change 713360 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/extensions/Flow@master] Declare topic namespace as not movable in extension.json

https://gerrit.wikimedia.org/r/713360

gerritbot added a comment.Aug 17 2021, 9:25 AM

Change 713444 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Declare EntitySchema namespace as not movable

https://gerrit.wikimedia.org/r/713444

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.20; 2021-08-23).Aug 17 2021, 10:00 AM
gerritbot added a comment.Aug 17 2021, 10:08 AM

Change 713360 merged by jenkins-bot:

[mediawiki/extensions/Flow@master] Declare topic namespace as not movable in extension.json

https://gerrit.wikimedia.org/r/713360

gerritbot added a comment.Aug 19 2021, 7:07 PM

Change 713359 abandoned by Jforrester:

[mediawiki/extensions/WikiLambda@master] Declare ZObject namespace as not movable in extension.json

Reason:

https://gerrit.wikimedia.org/r/713359

Maintenance_bot removed a project: Patch-For-Review.Aug 19 2021, 7:10 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits