Page MenuHomePhabricator

Webrequest.isWMFDomain should return true for .wmflabs.org domains.
Closed, ResolvedPublic

Description

This is causing events sent from e.g. recommend.wmflabs.org for the TranslationRecommendation schemas to be filtered out of Refined data in Hive.

Event Timeline

patch sent, but I have questions:

  • If we accept wmflabs.org, should we also accept toolsforge.org ?
  • Given the 'non-official-production' status of code serve by those domains, do we really wish to accept them without further check?

Note that wmflabs.org is slowly being phased out in favor of wmcloud.org.

Note that wmflabs.org is slowly being phased out in favor of wmcloud.org.

Ah I didn't know :) Thanks a lot !

Change 673202 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery/source@master] Add wmflabs.org and wmcloud.org in WMF domain list

https://gerrit.wikimedia.org/r/673202

Hm good question. For legacy EventLogging, this will cause these events to show up in Refine, which is vital for the TranslationRecommendation schemas (were these ever working???).

For new schemas, it will only cause the is_wmf_domain field to be true. I think these are wmf domains, so this seems correct to me. Let's do it.

For new schemas, it will only cause the is_wmf_domain field to be true. I think these are wmf domains, so this seems correct to me. Let's do it.

Ack !
I reiterate the other question about toolsforge.org :)

Change 673202 merged by jenkins-bot:

[analytics/refinery/source@master] Update WMF domain list with Cloud and toolforge

https://gerrit.wikimedia.org/r/673202

Ottomata triaged this task as Medium priority.Apr 8 2021, 4:07 PM