This is causing events sent from e.g. recommend.wmflabs.org for the TranslationRecommendation schemas to be filtered out of Refined data in Hive.
Description
Description
Details
Details
| Project | Branch | Lines +/- | Subject | |
|---|---|---|---|---|
| analytics/refinery/source | master | +19 -1 | Update WMF domain list with Cloud and toolforge |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Open | None | T185233 Modern Event Platform | |||
| Open | None | T238230 Decommission EventLogging backend components by migrating to MEP | |||
| Open | None | T259734 BUOD-KR1-Q4+: Certify that analytics schema and instruments have been upgraded to use the MEP system (clearing the legacy system for sunsetting) | |||
| Open | Ottomata | T259163 Migrate legacy metawiki schemas to Event Platform | |||
| Resolved | bmansurov | T271163 TranslationRecommendation* Schemas Event Platform Migration | |||
| Resolved | JAllemandou | T277536 Webrequest.isWMFDomain should return true for .wmflabs.org domains. |
Event Timeline
Comment Actions
patch sent, but I have questions:
- If we accept wmflabs.org, should we also accept toolsforge.org ?
- Given the 'non-official-production' status of code serve by those domains, do we really wish to accept them without further check?
Comment Actions
Change 673202 had a related patch set uploaded (by Joal; owner: Joal):
[analytics/refinery/source@master] Add wmflabs.org and wmcloud.org in WMF domain list
Comment Actions
Hm good question. For legacy EventLogging, this will cause these events to show up in Refine, which is vital for the TranslationRecommendation schemas (were these ever working???).
For new schemas, it will only cause the is_wmf_domain field to be true. I think these are wmf domains, so this seems correct to me. Let's do it.
Comment Actions
For new schemas, it will only cause the is_wmf_domain field to be true. I think these are wmf domains, so this seems correct to me. Let's do it.
Ack !
I reiterate the other question about toolsforge.org :)
Comment Actions
Change 673202 merged by jenkins-bot:
[analytics/refinery/source@master] Update WMF domain list with Cloud and toolforge