Page MenuHomePhabricator
Create Task
Maniphest T277577

Move WikibaseRepo MessageParameterFormatter to service container
Closed, ResolvedPublic
Actions

Details

SubjectRepoBranchLines +/-
Move WikibaseRepo MessageParameterFormatter to service containermediawiki/extensions/Wikibasemaster+77 -16
Customize query in gerrit

Related Objects

Event Timeline

Lucas_Werkmeister_WMDE created this task.Mar 16 2021, 5:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2021, 5:26 PM
Lucas_Werkmeister_WMDE moved this task from Incoming to Ready to pick up on the Wikibase Service Migration board.EditedMar 16 2021, 5:27 PM

Note: this service depends on getUserLanguage(), and I’m not actually sure how you’re supposed to get the user language in the service wiring. global $wgLang should work, but is ugly. $services->getMainConfig()->get( 'Lang' ) would also work, since it just forwards to $wgLang, but I’m not sure if the language counts as “config”.

Lucas_Werkmeister_WMDE moved this task from Ready to pick up to Waiting for other services on the Wikibase Service Migration board.Mar 30 2021, 12:44 PM

Let’s wait with this until T278819: Move WikibaseRepo UserLanguage to service container.

Lucas_Werkmeister_WMDE mentioned this in T268600: Implement services through MediaWikiServices.Mar 31 2021, 4:13 PM
Lucas_Werkmeister_WMDE moved this task from Waiting for other services to Ready to pick up on the Wikibase Service Migration board.Apr 6 2021, 5:05 PM
ItamarWMDE claimed this task.Apr 7 2021, 8:31 AM
ItamarWMDE moved this task from Ready to pick up to Doing on the Wikibase Service Migration board.
gerritbot added a comment.Apr 7 2021, 9:23 AM

Change 677499 had a related patch set uploaded (by Itamar Givon; author: Itamar Givon):

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo MessageParameterFormatter to service container

https://gerrit.wikimedia.org/r/677499

gerritbot added a project: Patch-For-Review.Apr 7 2021, 9:23 AM
ItamarWMDE moved this task from Doing to Up for review on the Wikibase Service Migration board.Apr 7 2021, 9:24 AM
ItamarWMDE mentioned this in T279513: WikibaseRepo: Move ExceptionLocalizer to service container.Apr 7 2021, 9:27 AM
ItamarWMDE mentioned this in T279516: WikibaseRepo: Move ValidatorErrorLocalizer to service container.
gerritbot added a comment.Apr 7 2021, 10:55 AM

Change 677499 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Move WikibaseRepo MessageParameterFormatter to service container

https://gerrit.wikimedia.org/r/677499

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.1; 2021-04-13).Apr 7 2021, 11:00 AM
Maintenance_bot removed a project: Patch-For-Review.Apr 7 2021, 11:11 AM
Lucas_Werkmeister_WMDE closed this task as Resolved.Apr 7 2021, 12:13 PM
Lucas_Werkmeister_WMDE moved this task from Up for review to Done on the Wikibase Service Migration board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL