Page MenuHomePhabricator

Prepare User option methods for hard deprecation
Closed, ResolvedPublic

Description

The following methods are soft deprecated and should not be used any more.

  • getBoolOption()
    • mediawiki/core
    • mediawiki/extensions/GrowthExperiments
    • mediawiki/extensions/SocialProfile
    • mediawiki/extensions/Popups
    • mediawiki/extensions/TwoColConflict
    • mediawiki/extensions/AdvancedSearch
    • mediawiki/extensions/CentralAuth
    • mediawiki/extensions/ORES
    • mediawiki/extensions/BlueSpiceFlaggedRevsConnector
    • mediawiki/extensions/ContactPage
    • mediawiki/extensions/ContentTranslation
    • mediawiki/extensions/CookieWarning
    • mediawiki/extensions/FlaggedRevs
    • mediawiki/extensions/ForcePreview
    • mediawiki/extensions/GPGMail
    • mediawiki/extensions/ProofreadPage
    • mediawiki/extensions/UniversalLanguageSelector
    • mediawiki/skins/MinervaNeue
    • mediawiki/skins/Timeless
  • getIntOption()
    • mediawiki/core
    • mediawiki/extensions/SocialProfile
    • mediawiki/extensions/Challenge
    • mediawiki/extensions/EventLogging
    • mediawiki/extensions/Flow
  • setOption() (see T277818)
  • getOptionKinds()
    • mediawiki/core
    • mediawiki/extensions/GlobalPreferences
    • mediawiki/extensions/CodeMirror
  • listOptionKinds()
    • mediawiki/core
    • mediawiki/extensions/GlobalPreferences
  • resetOptions()
    • mediawiki/core
    • mediawiki/extensions/EditUser

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35+2 -1
mediawiki/extensions/BlueSpiceFlaggedRevsConnectorREL1_35-4.0.x+2 -1
mediawiki/extensions/ForcePreviewmaster+20 -7
mediawiki/coremaster+105 -43
mediawiki/coremaster+8 -2
mediawiki/extensions/ContentTranslationmaster+5 -2
mediawiki/extensions/ORESmaster+11 -7
mediawiki/extensions/TwoColConflictmaster+84 -62
mediawiki/extensions/TwoColConflictmaster+12 -13
mediawiki/extensions/TwoColConflictmaster+31 -20
mediawiki/coremaster+6 -3
mediawiki/extensions/AdvancedSearchmaster+9 -5
mediawiki/extensions/ContactPagemaster+20 -7
mediawiki/extensions/TwoColConflictmaster+138 -77
mediawiki/extensions/Challengemaster+40 -8
mediawiki/coremaster+10 -5
mediawiki/skins/MinervaNeuemaster+3 -1
mediawiki/coremaster+6 -4
mediawiki/extensions/GPGMailmaster+9 -4
mediawiki/extensions/SocialProfilemaster+38 -13
mediawiki/skins/Timelessmaster+4 -1
mediawiki/coremaster+15 -11
mediawiki/coremaster+1 -1
mediawiki/coremaster+36 -29
mediawiki/coremaster+50 -41
mediawiki/extensions/Popupsmaster+81 -22
mediawiki/extensions/GrowthExperimentsmaster+165 -58
mediawiki/extensions/GlobalPreferencesmaster+1 -2
mediawiki/extensions/CodeMirrormaster+4 -2
mediawiki/extensions/EventLoggingmaster+9 -1
mediawiki/extensions/FlaggedRevsmaster+7 -3
mediawiki/extensions/BlueSpiceFlaggedRevsConnectormaster+2 -1
mediawiki/extensions/GPGMailmaster+7 -3
mediawiki/extensions/Flowmaster+2 -1
mediawiki/extensions/UniversalLanguageSelectormaster+8 -1
mediawiki/extensions/CookieWarningmaster+19 -5
mediawiki/extensions/ProofreadPagemaster+4 -2
mediawiki/extensions/GPGMailmaster+4 -1
mediawiki/extensions/CentralAuthmaster+18 -7
mediawiki/extensions/GlobalPreferencesmaster+4 -2
mediawiki/coremaster+25 -13
mediawiki/extensions/EditUsermaster+9 -1
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 684329 merged by jenkins-bot:

[mediawiki/extensions/CodeMirror@master] Avoid using User::getOptionKinds()

https://gerrit.wikimedia.org/r/684329

Change 685940 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GlobalPreferences@master] Avoid using User::listOptionKinds()

https://gerrit.wikimedia.org/r/685940

Change 686498 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Avoid using User::listOptionKinds()

https://gerrit.wikimedia.org/r/686498

Change 685940 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Avoid using User::listOptionKinds()

https://gerrit.wikimedia.org/r/685940

Change 698291 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] DefaultPreferencesFactory: inject UserOptionsManager update options calls

https://gerrit.wikimedia.org/r/698291

Change 698323 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/skins/MinervaNeue@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/698323

Change 698326 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Popups@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/698326

Change 675330 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/675330

Test wiki created on Patch Demo by Phuedx (WMF) using patch(es) linked to this task:

https://patchdemo.wmflabs.org/wikis/009aa3b852/w/

Test wiki on Patch Demo by Phuedx (WMF) using patch(es) linked to this task was deleted:

https://patchdemo.wmflabs.org/wikis/009aa3b852/w/

Change 698326 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/698326

Change 698291 merged by jenkins-bot:

[mediawiki/core@master] DefaultPreferencesFactory: inject and use UserOptionsManager

https://gerrit.wikimedia.org/r/698291

Change 701969 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] api: Replace deprecated User::getOptionKinds in ApiOptions

https://gerrit.wikimedia.org/r/701969

Change 701969 merged by jenkins-bot:

[mediawiki/core@master] api: Replace deprecated User::getOptionKinds/resetOptions in ApiOptions

https://gerrit.wikimedia.org/r/701969

Change 705189 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/skins/Timeless@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/705189

Change 675327 abandoned by Zabe:

[mediawiki/core@master] Avoid using User::getOptionKinds()

Reason:

Done with https://gerrit.wikimedia.org/r/c/mediawiki/core/ /701969

https://gerrit.wikimedia.org/r/675327

Change 674405 abandoned by Zabe:

[mediawiki/core@master] Avoid using User::resetOptions()

Reason:

Done with https://gerrit.wikimedia.org/r/c/mediawiki/core/ /701969

https://gerrit.wikimedia.org/r/674405

Change 705189 merged by jenkins-bot:

[mediawiki/skins/Timeless@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/705189

Change 705733 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Challenge@master] Avoid using User::getBoolOption() and ::getIntOption()

https://gerrit.wikimedia.org/r/705733

Change 675893 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Avoid using User::getBoolOption() and ::getIntOption()

https://gerrit.wikimedia.org/r/675893

Change 675862 merged by jenkins-bot:

[mediawiki/extensions/GPGMail@master] Avoid using deprecated user option methods

https://gerrit.wikimedia.org/r/675862

Change 709842 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Allow UserIdentity in WebRequest::getLimitOffsetForUser

https://gerrit.wikimedia.org/r/709842

Change 709853 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated User function in ChangesListSpecialPage

https://gerrit.wikimedia.org/r/709853

Change 709854 had a related patch set uploaded (by Umherirrender; author: Umherirrender):

[mediawiki/core@master] Replace deprecated User::getOption in LanguageConverter

https://gerrit.wikimedia.org/r/709854

Change 709854 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated User::getOption in LanguageConverter

https://gerrit.wikimedia.org/r/709854

Change 698323 merged by jenkins-bot:

[mediawiki/skins/MinervaNeue@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/698323

Change 675326 abandoned by Zabe:

[mediawiki/core@master] Avoid using User::getBoolOption() (part 2)

Reason:

superseeded by multiple different patches

https://gerrit.wikimedia.org/r/675326

Change 711730 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/TwoColConflict@master] Avoid using User::getOption() and ::getBoolOption()

https://gerrit.wikimedia.org/r/711730

Change 705733 merged by jenkins-bot:

[mediawiki/extensions/Challenge@master] Avoid using User::getBoolOption() and ::getIntOption()

https://gerrit.wikimedia.org/r/705733

Zabe updated the task description. (Show Details)

Change 713229 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Use UserIdentity instead of User in TwoColConflictContext

https://gerrit.wikimedia.org/r/713229

Change 713231 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Use UserIdentity instead of User in SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/713231

Change 713232 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/TwoColConflict@master] Replace all hard-coded references to the User class

https://gerrit.wikimedia.org/r/713232

Change 711730 abandoned by Thiemo Kreuz (WMDE):

[mediawiki/extensions/TwoColConflict@master] [DNM] Avoid using User::getOption() and ::getBoolOption()

Reason:

Replaced with a series of smaller patches, see I3462e7b and Ifb9c53d.

https://gerrit.wikimedia.org/r/711730

Change 713529 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AdvancedSearch@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/713529

Change 713534 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ContactPage@master] SpecialContact: inject UserOptionsLookup

https://gerrit.wikimedia.org/r/713534

Change 713534 merged by jenkins-bot:

[mediawiki/extensions/ContactPage@master] SpecialContact: inject UserOptionsLookup

https://gerrit.wikimedia.org/r/713534

Change 713529 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/713529

Change 709842 abandoned by Umherirrender:

[mediawiki/core@master] Allow UserIdentity in WebRequest::getLimitOffsetForUser

Reason:

superseeded by If739492953ee53a39c81894c48f16be81c845542

https://gerrit.wikimedia.org/r/709842

Change 713229 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Use UserIdentity instead of User in TwoColConflictContext

https://gerrit.wikimedia.org/r/713229

Change 713231 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Use UserIdentity instead of User in SplitTwoColConflictHelper

https://gerrit.wikimedia.org/r/713231

Change 713232 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Replace all hard-coded references to the User class

https://gerrit.wikimedia.org/r/713232

Change 715332 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ORES@master] Avoid using User::getBoolOption() and ::getOption()

https://gerrit.wikimedia.org/r/715332

Change 715333 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ContentTranslation@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/715333

Change 715335 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/ForcePreview@master] Avoid using User::getBoolOption() and ::getOption()

https://gerrit.wikimedia.org/r/715335

Change 715336 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate User::getIntOption()

https://gerrit.wikimedia.org/r/715336

Change 715332 merged by jenkins-bot:

[mediawiki/extensions/ORES@master] Avoid using User::getBoolOption() and ::getOption()

https://gerrit.wikimedia.org/r/715332

Change 715333 merged by jenkins-bot:

[mediawiki/extensions/ContentTranslation@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/715333

Change 715336 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User::getBoolOption()

https://gerrit.wikimedia.org/r/715336

Change 709853 merged by jenkins-bot:

[mediawiki/core@master] Replace deprecated User function in ChangesListSpecialPage

https://gerrit.wikimedia.org/r/709853

Change 715335 merged by jenkins-bot:

[mediawiki/extensions/ForcePreview@master] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/715335

Zabe updated the task description. (Show Details)
Zabe removed a project: Patch-For-Review.

Change 745267 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/745267

Change 745229 had a related patch set uploaded (by Pwirth; author: Zabe):

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/745229

Change 745229 merged by Pwirth:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35-4.0.x] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/745229

Change 745267 merged by jenkins-bot:

[mediawiki/extensions/BlueSpiceFlaggedRevsConnector@REL1_35] Avoid using User::getBoolOption()

https://gerrit.wikimedia.org/r/745267