EditHandler: Call to a member function getContent() on null
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.34

message

Call to a member function getContent() on null

exception.trace

from /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Handler/EditHandler.php(101)
#0 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Handler/ActionModuleBasedHandler.php(152): MediaWiki\Rest\Handler\EditHandler->mapActionModuleResult(array)
#1 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Router.php(395): MediaWiki\Rest\Handler\ActionModuleBasedHandler->execute()
#2 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MediaWiki\Rest\Handler\UpdateHandler)
#3 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#4 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#5 /srv/mediawiki/php-1.36.0-wmf.34/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#6 /srv/mediawiki/w/rest.php(3): require(string)
#7 {main}

and in the same requests, prior to reaching the above fatal error:

message2

PHP Notice: Undefined index: newrevid

trace

from /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Handler/EditHandler.php(100)
#0 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Handler/EditHandler.php(100): MWExceptionHandler::handleError(integer, string, string, integer, array)
#1 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Handler/ActionModuleBasedHandler.php(152): MediaWiki\Rest\Handler\EditHandler->mapActionModuleResult(array)
#2 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Router.php(395): MediaWiki\Rest\Handler\ActionModuleBasedHandler->execute()
#3 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/Router.php(322): MediaWiki\Rest\Router->executeHandler(MediaWiki\Rest\Handler\UpdateHandler)
#4 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/EntryPoint.php(165): MediaWiki\Rest\Router->execute(MediaWiki\Rest\RequestFromGlobals)
#5 /srv/mediawiki/php-1.36.0-wmf.34/includes/Rest/EntryPoint.php(130): MediaWiki\Rest\EntryPoint->execute()
#6 /srv/mediawiki/php-1.36.0-wmf.34/rest.php(31): MediaWiki\Rest\EntryPoint::main()
#7 /srv/mediawiki/w/rest.php(3): require(string)
#8 {main}

Impact

Notes

Details

Request URL: https://sq.wikipedia.org/w/rest.php/v1/page/[page]

	Subject	Repo	Branch	Lines +/-
	UpdateHandler: fix response for null edits	mediawiki/core	master	+6 -7
	REST edit: handle null edits correctly	mediawiki/core	master	+92 -0

Customize query in gerrit

Related Objects

Mentioned Here: rMWb38e0e8e326d: REST edit: handle null edits correctly

Event Timeline

dancy created this task.Mar 16 2021, 9:03 PM

Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 16 2021, 9:03 PM

dancy edited Stack Trace. (Show Details)Mar 16 2021, 9:04 PM

Reedy added a project: MediaWiki-REST-API.Mar 16 2021, 9:05 PM

dancy updated the task description. (Show Details)Mar 16 2021, 9:05 PM

brennen renamed this task from Call to a member function getContent() on null to EditHandler: Call to a member function getContent() on null.Mar 19 2021, 12:03 AM

brennen changed Request URL from https://sq.wikipedia.org/w/rest.php/v1/page/P%C3%ABrdoruesi:Smallem%2FLivadhi%20personal%2FLangCodes to https://sq.wikipedia.org/w/rest.php/v1/page/[page].

brennen added projects: Platform Engineering, User-brennen.

brennen moved this task from Backlog to Logs/Train on the User-brennen board.

Krinkle updated the task description. (Show Details)Mar 19 2021, 12:25 AM

Krinkle edited Stack Trace. (Show Details)

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.

Krinkle updated the task description. (Show Details)

At a glance, I suspect this will happen for null-edits: no new revision is created, so newrevid isn't set, so trying to load the revision returns null, so calling getContent() throws.

EDIT: confirmed. Fixing.

daniel claimed this task.Mar 19 2021, 12:13 PM

daniel added a project: Platform Team Workboards (Clinic Duty Team).

daniel removed a project: Platform Engineering.

daniel moved this task from Inbox to Doing(WIP:5) on the Platform Team Workboards (Clinic Duty Team) board.

Change 673479 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] REST edit: handle null edits correctly

https://gerrit.wikimedia.org/r/673479

gerritbot added a project: Patch-For-Review.Mar 19 2021, 1:11 PM

daniel triaged this task as High priority.Mar 19 2021, 1:11 PM

daniel moved this task from Doing(WIP:5) to Waiting for Review on the Platform Team Workboards (Clinic Duty Team) board.

Change 673479 merged by jenkins-bot:
[mediawiki/core@master] REST edit: handle null edits correctly

https://gerrit.wikimedia.org/r/673479

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 19 2021, 3:00 PM

Maintenance_bot removed a project: Patch-For-Review.Mar 19 2021, 3:10 PM

The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.

SELECT ... FROM `revision` ... WHERE rev_id = 0

In T277601#6933253, @Ammarpad wrote:
The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.
SELECT ... FROM `revision` ... WHERE rev_id = 0

While generally this would be pointless but harmless, this actually led me to realize a flaw in my patch: the response representing the state after a null-edit should reflect information from the page's current revision, not the edit's base revision. I'll make another patch to improve this.

Change 674627 had a related patch set uploaded (by Daniel Kinzler; owner: Daniel Kinzler):
[mediawiki/core@master] UpdateHandler: fix response for null edits

https://gerrit.wikimedia.org/r/674627

gerritbot added a project: Patch-For-Review.Mar 24 2021, 3:08 PM

In T277601#6941784, @daniel wrote:
In T277601#6933253, @Ammarpad wrote:
The fix for this (b38e0e8) may send a db query looking for revision with rev_id 0 which does not make sense.
SELECT ... FROM `revision` ... WHERE rev_id = 0
While generally this would be pointless but harmless, this actually led me to realize a flaw in my patch: the response representing the state after a null-edit should reflect information from the page's current revision, not the edit's base revision. I'll make another patch to improve this.