Page MenuHomePhabricator
Create Task
Maniphest T277640

Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users
Closed, ResolvedPublic2 Estimated Story Points
Actions

Description

Background

When anonymous / non logged-in users disable Page-Previews, they see a second screen explaining that a link is added to the footer where they can re-enable. In T277639: Settings pop up for RefPreviews and Page Previews we will create a joint settings dialog for this user group to display all popup types in one dialog, and will adjust the behavior of the footer link in this ticket.

Requirements

  • After an anonymous user / a user that is not logged in clicks on the cog wheel and then disables either the Page previews or Reference previews, or both settings, users see the same graphic and message about re-enabling in the footer (with the adjusted header, "Previews")
  • Show the link to re-enable previews in the footer whenever one of the settings is disabled, using the existing link
  • Do not label the link "Enable previews" any more, but "Edit preview settings"
  • When clicking "Edit preview settings", the settings dialog comes back with the previously set settings and the user can change their setting for any preview type. If they leave it unchecked and click save again, do not show the graphic about the footer (this is current behavior for Page Previews)

Mocks

Note: the header of the pop-up should be "Previews" as above (mock has not been updated)

Anonymous disable - screen 2.png (494×630 px, 41 KB)

Details

SubjectRepoBranchLines +/-
Clean up popup type settings related codemediawiki/extensions/Popupsmaster+46 -69
Updated settings link for anonymous usersmediawiki/extensions/Popupsmaster+6 -6
Clean up code enabling individual popup typesmediawiki/extensions/Popupsmaster+81 -46
Customize query in gerrit

Related Objects
Search...

Event Timeline

Lena_WMDE created this task.Mar 17 2021, 9:02 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2021, 9:03 AM
Lena_WMDE moved this task from Backlog to In preparation on the Reference Previews board.Mar 17 2021, 9:18 AM
ECohen_WMDE renamed this task from Add settings link to bottom of page for RefPreviews to Add settings link to bottom of page for RefPreviews anonymous users.Mar 17 2021, 9:46 AM
ECohen_WMDE updated the task description. (Show Details)
ECohen_WMDE updated the task description. (Show Details)
Lena_WMDE mentioned this in T277639: Settings pop up for RefPreviews and Page Previews.Mar 17 2021, 10:00 AM
Lena_WMDE edited projects, added WMDE-TechWish-Sprint-2021-03-17; removed WMDE-TechWish.Mar 17 2021, 11:11 AM
Lena_WMDE moved this task from In preparation to Doing on the Reference Previews board.
Lena_WMDE renamed this task from Add settings link to bottom of page for RefPreviews anonymous users to Add settings link to bottom of page for RefPreviews anonymous/non logged-in users.Mar 17 2021, 11:18 AM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE added a subtask: T277639: Settings pop up for RefPreviews and Page Previews.Mar 17 2021, 12:50 PM
Lena_WMDE added a parent task: T277641: Collect PrefUpdate events for reference previews, remove for page previews.
Lena_WMDE set the point value for this task to 2.Mar 18 2021, 3:12 PM
thiemowmde added a project: WMDE-TechWish-Sprint-2021-03-31.Mar 31 2021, 8:06 AM
lilients_WMDE moved this task from Sprint Backlog to Watching (Stalled) on the WMDE-TechWish-Sprint-2021-03-31 board.Mar 31 2021, 12:35 PM
lilients_WMDE subscribed.Mar 31 2021, 12:55 PM

The changes we are discussing in this ticket https://phabricator.wikimedia.org/T277639#6954081 would also mean a different implementation for this ticket.

lilients_WMDE moved this task from Watching (Stalled) to Sprint Backlog on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 6 2021, 1:11 PM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 7 2021, 11:05 AM
lilients_WMDE moved this task from Doing to Watching (Stalled) on the WMDE-TechWish-Sprint-2021-03-31 board.Apr 13 2021, 8:59 AM
Lena_WMDE renamed this task from Add settings link to bottom of page for RefPreviews anonymous/non logged-in users to Settings link to bottom of page for RefPreviews and Page Previews anonymous/non logged-in users.Apr 14 2021, 9:27 AM
Lena_WMDE updated the task description. (Show Details)
Lena_WMDE updated the task description. (Show Details)Apr 14 2021, 9:29 AM
Lena_WMDE updated the task description. (Show Details)
lilients_WMDE added a comment.Apr 14 2021, 9:50 AM

Because there are now more popup type settings in the settings window and they can have different settings (one could be enabled and the other disabled), it might make sense to change the label from "Enable previews" to "Edit preview settings" (or something similar). Also I would always display the link for the settings to not confuse users. For example if a user wants to change a specific setting and enabled all types before, the link will not appear, although it was displayed before.

Lena_WMDE added a project: WMDE-TechWish-Sprint-2021-04-14.Apr 14 2021, 11:07 AM
Lena_WMDE updated the task description. (Show Details)Apr 15 2021, 7:34 AM
Lena_WMDE added a comment.Apr 15 2021, 7:39 AM

Thanks @lilients_WMDE that's a good point, I've updated the ticket.

lilients_WMDE added a comment.Apr 16 2021, 8:46 AM

We need to hide the footer link when a conflicting gadget is activated.

gerritbot added a comment.Apr 16 2021, 11:20 AM

Change 680293 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Clean up code enabling individual popup types

https://gerrit.wikimedia.org/r/680293

gerritbot added a project: Patch-For-Review.Apr 16 2021, 11:20 AM
lilients_WMDE claimed this task.Apr 19 2021, 8:31 AM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-04-14 board.
lilients_WMDE removed lilients_WMDE as the assignee of this task.Apr 21 2021, 9:35 AM
lilients_WMDE moved this task from Doing to Sprint Backlog on the WMDE-TechWish-Sprint-2021-04-14 board.
lilients_WMDE claimed this task.Apr 22 2021, 8:34 AM
lilients_WMDE moved this task from Sprint Backlog to Doing on the WMDE-TechWish-Sprint-2021-04-14 board.
thiemowmde moved this task from Doing to Review on the WMDE-TechWish-Sprint-2021-04-14 board.Apr 22 2021, 10:27 AM
gerritbot added a comment.Apr 22 2021, 10:27 AM

Change 681946 had a related patch set uploaded (by Svantje Lilienthal; author: Svantje Lilienthal):

[mediawiki/extensions/Popups@master] Updated settings link for anonymous users

https://gerrit.wikimedia.org/r/681946

gerritbot added a comment.Apr 22 2021, 3:46 PM

Change 681949 had a related patch set uploaded (by Thiemo Kreuz (WMDE); author: Thiemo Kreuz (WMDE)):

[mediawiki/extensions/Popups@master] Clean up popup type settings related code

https://gerrit.wikimedia.org/r/681949

gerritbot added a comment.Apr 22 2021, 3:47 PM

Change 680293 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Clean up code enabling individual popup types

https://gerrit.wikimedia.org/r/680293

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 22 2021, 4:00 PM
Lena_WMDE updated the task description. (Show Details)Apr 23 2021, 10:39 AM
gerritbot added a comment.Apr 23 2021, 10:56 AM

Change 681946 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Updated settings link for anonymous users

https://gerrit.wikimedia.org/r/681946

gerritbot added a comment.Apr 23 2021, 1:46 PM

Change 681949 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Clean up popup type settings related code

https://gerrit.wikimedia.org/r/681949

Maintenance_bot removed a project: Patch-For-Review.Apr 23 2021, 2:10 PM
thiemowmde updated the task description. (Show Details)Apr 26 2021, 7:19 AM
thiemowmde moved this task from Review to Demo on the WMDE-TechWish-Sprint-2021-04-14 board.
thiemowmde updated the task description. (Show Details)Apr 26 2021, 7:25 AM
Lena_WMDE closed this task as Resolved.Apr 28 2021, 8:05 AM
Lena_WMDE closed subtask T277639: Settings pop up for RefPreviews and Page Previews as Resolved.
Lena_WMDE moved this task from Demo to Done on the WMDE-TechWish-Sprint-2021-04-14 board.
thiemowmde mentioned this in T281352: Broken settings dialogue for reference previews when in conflict with a skin/gadget.Apr 28 2021, 1:24 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL