Echo checks whether an edit is a revert before sending some notifications. While trying to re-use that logic for DiscussionTools's notifications, we realized that it could be simplified thanks to the EditResult revert detection improvements from T254074.
Description
Description
Details
Details
| Subject | Repo | Branch | Lines +/- | |
|---|---|---|---|---|
| Simplify code for detecting rollbacks | mediawiki/extensions/Echo | master | +7 -13 |
| Status | Subtype | Assigned | Task | ||
|---|---|---|---|---|---|
| Resolved | Ostrzyciel | T56007 "reverted"-type notifications should be based on the actual page content | |||
| Resolved | matmarex | T277649 Update Echo for the EditResult revert detection improvements |
Event Timeline
Comment Actions
@matmarex you may want to look at https://gerrit.wikimedia.org/r/c/mediawiki/extensions/Echo/+/608884 as part of this
Comment Actions
I've seen it, but it also includes functional changes, and I'd like to keep this to just a code cleanup, to make it easier to review and not require community consultations.
Comment Actions
Change 673003 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/Echo@master] Simplify code for detecting rollbacks
Comment Actions
Change 673003 merged by jenkins-bot:
[mediawiki/extensions/Echo@master] Simplify code for detecting rollbacks