Page MenuHomePhabricator

Obscure errors from ext.tmh.OgvJs without a stack trace (such as `r[o]=i[o]*u`, `r.tgt=t.outerHTML`, etc.)
Closed, DeclinedPublicPRODUCTION ERROR

Description

message 1
TypeError: undefined is not an object (evaluating 'r[o]=i[o]*u') 
at https://commons.wikimedia.org/w/load.php?lang=de&modules=ext.tmh.OgvJs&skin=vector&version=1jgdz:115:476
message 2
TypeError: null is not an object (evaluating 'r.tgt=t.outerHTML')

https://logstash.wikimedia.org/goto/9da2d423d9aec36b03696456e45831e3
Note: A lot of the videos triggering the error are "NSFW".

Event Timeline

@brion I recall ogvjs having recently been updated, so this might be fresh on your mind?

It comes from this portion of the code (source, debug source):

/**
 * @file Web Audio API backend for AudioFeeder
 */

o.prototype._audioProcess=function(e){
  var t,i,r,o,a;a="number"==typeof e.playbackTime?e.playbackTime:this._context.currentTime+this.bufferSize/this.rate;var s=this._playbackTimeAtBufferTail;if(s<a&&(this._delayedTime+=a-s),this._bufferQueue.sampleCount()<this.bufferSize&&this.onstarved&&this.onstarved(),this._bufferQueue.sampleCount()<this.bufferSize){for(t=0;t<this.channels;t++)for(r=e.outputBuffer.getChannelData(t),o=0;o<this.bufferSize;o++)r[o]=0;this._dropped++}else{var u=this.muted?0:this.volume,d=this._bufferQueue.nextBuffer();if(d[0].length<this.bufferSize)throw"Audio buffer not expected length.";for(t=0;t<this.channels;t++)for(i=d[t],this._liveBuffer[t].set(d[t]),r=e.outputBuffer.getChannelData(t),o=0;o<i.length;o++)r[o]=i[o]*u;

Krinkle renamed this task from TypeError: undefined is not an object (evaluating 'r[o]=i[o]*u') to Obscure errors from ext.tmh.OgvJs without a stack trace (such as `r[o]=i[o]*u`, `r.tgt=t.outerHTML`, etc.) .Apr 14 2021, 7:23 PM
Krinkle updated the task description. (Show Details)
Jdlrobson claimed this task.

No errors in the last 7 days from what I can see.

I was using the wrong filter :)

Declining per T429074: ogv.js got removed.

Restricted Application changed the subtype of this task from "Task" to "Production Error". · View Herald TranscriptJun 15 2026, 3:53 AM