Argument 1 passed to DataValues\Geo\Values\LatLongValue::__construct() must be of the type float, string given
Closed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.34

message

Argument 1 passed to DataValues\Geo\Values\LatLongValue::__construct() must be of the type float, string given, called in /srv/mediawiki/php-1.36.0-wmf.34/vendor/data-values/geo/src/Values/GlobeCoordinateValue.php on line 223

Impact

Unknown.

Presumably if a value can't be passed the user should receive feedback to that effect.

Notes

6 of these in the last ~4 hours.

Acceptance Criteria

Check whether this error got introduced recently with stricter type checking. It may have allowed string values ("1.234" instead of 1.234) before. It may be ok to allow both.
If this is caused by completely invalid input, handle the exception and send an error in the response.

Details

Request ID: YFJK0tKPIg2eFM7VqMP14AAAAMI
Request URL: https://www.wikidata.org/w/api.php

Stack Trace

exception.trace

from /srv/mediawiki/php-1.36.0-wmf.34/vendor/data-values/geo/src/Values/LatLongValue.php(33)
#0 /srv/mediawiki/php-1.36.0-wmf.34/vendor/data-values/geo/src/Values/GlobeCoordinateValue.php(223): DataValues\Geo\Values\LatLongValue->__construct(string, string)
#1 /srv/mediawiki/php-1.36.0-wmf.34/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(126): DataValues\Geo\Values\GlobeCoordinateValue::newFromArray(array)
#2 /srv/mediawiki/php-1.36.0-wmf.34/vendor/data-values/serialization/src/Deserializers/DataValueDeserializer.php(91): DataValues\Deserializers\DataValueDeserializer->getDeserialization(array)
#3 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(128): DataValues\Deserializers\DataValueDeserializer->deserialize(array)
#4 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(117): Wikibase\DataModel\Deserializers\SnakDeserializer->deserializeDataValue(array)
#5 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(100): Wikibase\DataModel\Deserializers\SnakDeserializer->newValueSnak(array)
#6 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/SnakDeserializer.php(82): Wikibase\DataModel\Deserializers\SnakDeserializer->getDeserialized(array)
#7 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(110): Wikibase\DataModel\Deserializers\SnakDeserializer->deserialize(array)
#8 /srv/mediawiki/php-1.36.0-wmf.34/vendor/wikibase/data-model-serialization/src/Deserializers/StatementDeserializer.php(100): Wikibase\DataModel\Deserializers\StatementDeserializer->getDeserialized(array)
#9 /srv/mediawiki/php-1.36.0-wmf.34/extensions/Wikibase/repo/includes/Api/SetClaim.php(266): Wikibase\DataModel\Deserializers\StatementDeserializer->deserialize(array)
#10 /srv/mediawiki/php-1.36.0-wmf.34/extensions/Wikibase/repo/includes/Api/SetClaim.php(162): Wikibase\Repo\Api\SetClaim->getStatementFromParams(array)
#11 /srv/mediawiki/php-1.36.0-wmf.34/extensions/Wikibase/repo/includes/Api/SetClaim.php(151): Wikibase\Repo\Api\SetClaim->executeInternal()
#12 /srv/mediawiki/php-1.36.0-wmf.34/includes/api/ApiMain.php(1612): Wikibase\Repo\Api\SetClaim->execute()
#13 /srv/mediawiki/php-1.36.0-wmf.34/includes/api/ApiMain.php(591): ApiMain->executeAction()
#14 /srv/mediawiki/php-1.36.0-wmf.34/includes/api/ApiMain.php(562): ApiMain->executeActionWithErrorHandling()
#15 /srv/mediawiki/php-1.36.0-wmf.34/api.php(90): ApiMain->execute()
#16 /srv/mediawiki/php-1.36.0-wmf.34/api.php(45): wfApiMain()
#17 /srv/mediawiki/w/api.php(3): require(string)
#18 {main}

Project	Branch	Lines +/-	Subject
mediawiki/vendor	master	+24 -20	Update DataValues/Geo Library to v4.2.3 to match version in wikibase
mediawiki/extensions/Wikibase	master	+1 -1	Add correct version of DataValues/Geo package to accept string values in LatLongValues
mediawiki/extensions/Wikibase	master	+1 -1	Add new version of DataValues/Geo package to accept string values in LatLongValues

Customize query in gerrit

Event Timeline

brennen created this task.Mar 17 2021, 6:37 PM

Restricted Application added projects: Wikidata, Discovery-Search. · View Herald TranscriptMar 17 2021, 6:37 PM

Restricted Application added a subscriber: Aklapper. · View Herald Transcript

brennen added a project: User-brennen.Mar 17 2021, 6:37 PM

Restricted Application added a project: wdwb-tech. · View Herald TranscriptMar 17 2021, 6:37 PM

brennen moved this task from Backlog to Logs/Train on the User-brennen board.Mar 17 2021, 6:37 PM

WMDE-leszek added a subscriber: WMDE-leszek.Mar 17 2021, 6:38 PM

• Addshore moved this task from Inbox to Blocked on the wdwb-tech board.Mar 17 2021, 6:41 PM

• Addshore moved this task from Blocked to legacy-backlog on the wdwb-tech board.

• Addshore edited projects, added wdwb-tech (legacy-backlog); removed wdwb-tech.

• Addshore added a subscriber: • Addshore.

• Addshore edited projects, added wdwb-tech; removed wdwb-tech (legacy-backlog).Mar 18 2021, 12:27 PM

• Addshore moved this task from Inbox to Triaged Low (0-50) on the wdwb-tech board.

MPhamWMF removed a project: Discovery-Search.Mar 22 2021, 3:14 PM

dcausse removed a project: GeoData.Mar 22 2021, 3:15 PM

Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Mar 25 2021, 2:56 AM

• Addshore moved this task from Incoming to Prioritized Wikidata Tech Backlog (prioritised from top to bottom) on the Wikidata-Campsite board.Apr 6 2021, 11:50 AM

Jakob_WMDE updated the task description. (Show Details)Apr 6 2021, 4:54 PM

Suspected ways of reproducing the error (to be verified if actually true)

throwing in "garbage" input to wbsetclaim API
using float number input (assumpution being that strict type checking could have led to the regression here)

WMDE-leszek set the point value for this task to 3.Apr 16 2021, 10:27 AM

WMDE-leszek moved this task from Prioritized Wikidata Tech Backlog (prioritised from top to bottom) to Wikidata-Campsite-Iteration-∞ (On Hold) on the Wikidata-Campsite board.

WMDE-leszek edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.

Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Apr 16 2021, 11:15 AM

Silvan_WMDE claimed this task.Apr 16 2021, 3:58 PM

Silvan_WMDE moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.

This has been fixed in this Pull Request in the Datatype/Geo library.

Still TODO: We still need to wait for the release of 4.3.0 of the package and update the /wikibase/composer.json file with the new version number for this fix to be applied.

guergana.tzatchkova claimed this task.Apr 20 2021, 3:00 PM

guergana.tzatchkova added a subscriber: Silvan_WMDE.

Version 4.3.0 has been released. Will do the remaining tasks.

Change 681699 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/Wikibase@master] Add new version of DataValues/Geo package to accept string values in LatLongValues

https://gerrit.wikimedia.org/r/681699

gerritbot added a project: Patch-For-Review.Apr 21 2021, 2:38 PM

The bug should be fixed by merging patch 681699
It is still a good idea to update the package also in mediawiki-vendor when the 681699 is merged.

Mediawiki-vendor on Gerrit
Mediawiki-vendor Github mirror

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 21 2021, 3:13 PM

Jakob_WMDE moved this task from Peer Review to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 22 2021, 9:20 AM

Change 681699 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add new version of DataValues/Geo package to accept string values in LatLongValues

https://gerrit.wikimedia.org/r/681699

ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 22 2021, 1:00 PM

Change 681990 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/vendor@master] Update DataValues/Geo Library to v4.3.0 to match version in mediawiki

https://gerrit.wikimedia.org/r/681990

Since discovering that version 4.3.0 of DataValues Geo needs a PHP version 7.3 and the current version in our production environment is 7.2, we will introduce the fix in version 4.2.3 instead.

• Addshore moved this task from Triaged Low (0-50) to Active on the wdwb-tech board.Apr 23 2021, 10:54 AM

Change 682136 had a related patch set uploaded (by Guergana Tzatchkova; author: Guergana Tzatchkova):

[mediawiki/extensions/Wikibase@master] Add correct version of DataValues/Geo package to accept string values in LatLongValues

https://gerrit.wikimedia.org/r/682136

Change 682136 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Add correct version of DataValues/Geo package to accept string values in LatLongValues

https://gerrit.wikimedia.org/r/682136

guergana.tzatchkova moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 26 2021, 10:16 AM

Change 681990 merged by jenkins-bot:

[mediawiki/vendor@master] Update DataValues/Geo Library to v4.2.3 to match version in wikibase

https://gerrit.wikimedia.org/r/681990

Jakob_WMDE moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Apr 27 2021, 9:17 AM

Reproduction URL I found from logs:

https://www.wikidata.org/w/api.php?callback=jQuery33107563274978080303_1617624054908&action=wbformatvalue&datavalue=%7B%22value%22%3A%7B%22latitude%22%3A%22%22%2C%22longitude%22%3A%22%22%2C%22altitude%22%3A0%2C%22precision%22%3A0%2C%22globe%22%3A%22http%3A%2F%2Fwww.wikidata.org%2Fentity%2FQ2%22%7D%2C%22type%22%3A%22globecoordinate%22%7D&datatype=globe-coordinate&format=json&_=1617624054925

Now gives us a nice error page

And nothing appears in the logs

Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.May 3 2021, 10:15 AM

	F34438665: image.png
	May 3 2021, 9:31 AM

Argument 1 passed to DataValues\Geo\Values\LatLongValue::__construct() must be of the type float, string givenClosed, ResolvedPublic3 Estimated Story PointsPRODUCTION ERRORActions