Page MenuHomePhabricator
Create Task
Maniphest T277693

ForeignDBFile attempts to load users in the context of the wrong wiki
Open, Needs TriagePublic
Actions

Description

When a wiki is configured to use another wiki as a shared image repository via the ForeignDBViaLBRepo abstraction, the ForeignDBFile objects produced by the repo always try to load the User object of the image uploader in the context of the client wiki, rather than the repository wiki. If the user tables of the two wikis are different, this can result in incorrect attribution being displayed, or cryptic Cannot create a user with no name, no ID, and no actor ID errors.

Instead, ForeignDBFile instances should always use the user table of the repository wiki to load uploader info.

Details

SubjectRepoBranchLines +/-
[DNM] LocalFile: Load User objects in the context of the remote wikimediawiki/coremaster+20 -5
Customize query in gerrit

Related Objects

Event Timeline

TK-999 created this task.Mar 17 2021, 6:59 PM
Restricted Application added a project: Commons. · View Herald TranscriptMar 17 2021, 6:59 PM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
TK-999 added a comment.Mar 17 2021, 7:04 PM

Note: This is essentially T222212 but for images.

gerritbot added a comment.Mar 17 2021, 7:11 PM

Change 673079 had a related patch set uploaded (by TK-999; owner: TK-999):
[mediawiki/core@master] [DNM] LocalFile: Load User objects in the context of the remote wiki

https://gerrit.wikimedia.org/r/673079

gerritbot added a project: Patch-For-Review.Mar 17 2021, 7:11 PM
Pcj awarded a token.Mar 17 2021, 7:13 PM
Pcj subscribed.
TK-999 added subscribers: • Pchelolo, daniel.Mar 17 2021, 7:57 PM

Tentatively tagging @daniel and @Pchelolo due to their recent work around similar issues. :)

• Pchelolo added a project: Platform Team Workboards (MW Expedition).Mar 17 2021, 7:59 PM
• Pchelolo added a comment.Mar 17 2021, 8:02 PM

Yeah, we've done much progress with converting everything to UserIdentity/ActorStore and thus supporting better cross-wiki users, but haven't touched the File yet, mostly cause it's a very large class hierarchy, so it's hard and didn't qualify as a low hanging fruit.

How high of a priority is this? We can put this next on our agenda.

TK-999 added a comment.Mar 17 2021, 8:27 PM

Thanks for the quick response! This fix in itself would not solve our problems, as we still have to finish the actor migration across all of our wikis. I consider this patch more as a future insurance to ensure the problem doesn't pop up after that's done, so probably not so urgent.

daniel moved this task from Unsorted pile to UserStore pile on the Platform Team Workboards (MW Expedition) board.Jun 8 2021, 11:42 AM
Meow moved this task from Incoming to Thumbnail and file renderings on the Commons board.Jul 28 2021, 9:04 AM
Meow moved this task from Thumbnail and file renderings to Incoming on the Commons board.Jul 28 2021, 9:22 AM
daniel moved this task from UserStore pile to PageStore pile on the Platform Team Workboards (MW Expedition) board.Jun 29 2022, 10:59 AM
Pppery edited projects, added Patch-Needs-Improvement; removed Patch-For-Review.Oct 10 2023, 5:28 AM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL