Page MenuHomePhabricator
Create Task
Maniphest T277702

GrowthExperiments\Maintenance\RefreshLinkRecommendations: no transaction to commit, something got out of sync
Closed, ResolvedPublicPRODUCTION ERROR
Actions

Description

Error

MediaWiki version: 1.36.0-wmf.35

message
GrowthExperiments\Maintenance\RefreshLinkRecommendations::execute: no transaction to commit, something got out of sync
Notes

The error (total count: 60 when the task is file) is exclusively on testwiki.

Details

Request URL
n/a
Stack Trace
exception.trace
from /srv/mediawiki/php-1.36.0-wmf.35/includes/libs/rdbms/database/Database.php(4618)
#0 /srv/mediawiki/php-1.36.0-wmf.35/includes/libs/rdbms/database/DBConnRef.php(68): Wikimedia\Rdbms\Database->commit(string)
#1 /srv/mediawiki/php-1.36.0-wmf.35/includes/libs/rdbms/database/DBConnRef.php(649): Wikimedia\Rdbms\DBConnRef->__call(string, array)
#2 /srv/mediawiki/php-1.36.0-wmf.35/maintenance/includes/Maintenance.php(1435): Wikimedia\Rdbms\DBConnRef->commit(string)
#3 /srv/mediawiki/php-1.36.0-wmf.35/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(197): Maintenance->commitTransaction(Wikimedia\Rdbms\DBConnRef, string)
#4 /srv/mediawiki/php-1.36.0-wmf.35/maintenance/doMaintenance.php(112): GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
#5 /srv/mediawiki/php-1.36.0-wmf.35/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(486): require_once(string)
#6 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string)
#7 {main}
Related Changes in Gerrit:
SubjectRepoBranchLines +/-
refreshLinkRecommendations.php: use explicit beginmediawiki/extensions/GrowthExperimentsmaster+6 -2
Fix "no transaction to commit" logspammediawiki/extensions/GrowthExperimentsmaster+1 -3
Customize query in gerrit

Related Objects

Event Timeline

Etonkovidova created this task.Mar 17 2021, 8:26 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 17 2021, 8:26 PM
Tgr edited projects, added Growth-Team (Sprint 0 (Growth Team)); removed Growth-Team.Mar 17 2021, 10:57 PM
gerritbot added a comment.Mar 17 2021, 10:58 PM

Change 673150 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] Fix "no transaction to commit" logspam

https://gerrit.wikimedia.org/r/673150

gerritbot added a project: Patch-For-Review.Mar 17 2021, 10:58 PM
Tgr claimed this task.Mar 17 2021, 10:58 PM
Tgr moved this task from Incoming to Code Review on the Growth-Team (Sprint 0 (Growth Team)) board.
kostajh moved this task from Code Review to QA on the Growth-Team (Sprint 0 (Growth Team)) board.Mar 18 2021, 10:01 AM

Probably not worth a backport, but will let @Tgr decide.

gerritbot added a comment.Mar 18 2021, 10:24 AM

Change 673150 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] Fix "no transaction to commit" logspam

https://gerrit.wikimedia.org/r/673150

ReleaseTaggerBot added a project: MW-1.36-notes (1.36.0-wmf.36; 2021-03-23).Mar 18 2021, 11:00 AM
Tgr added a comment.Mar 18 2021, 11:08 AM

Agreed. It's just logspam and not a huge amount of it.

Maintenance_bot removed a project: Patch-For-Review.Mar 18 2021, 11:10 AM
Tgr mentioned this in T274939: 1.36.0-wmf.35 deployment blockers.Mar 18 2021, 11:10 AM
Etonkovidova closed this task as Resolved.Mar 23 2021, 9:37 PM

The error is not present anymore in wmf.36.

gerritbot added a comment.Apr 7 2021, 4:32 PM

Change 677609 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: use explicit begin

https://gerrit.wikimedia.org/r/677609

gerritbot added a project: Patch-For-Review.Apr 7 2021, 4:32 PM
kostajh reopened this task as Open.Apr 13 2021, 10:54 AM

I'm confused how these were resolved given that https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/677609 wasn't merged/deployed. @Tgr is your patch still needed?

Tgr added a comment.Apr 13 2021, 11:43 AM

The error is still present, so some kind of fix is still needed. I'm hoping using an explicit transaction will fix it, although I still don't understand why the previous fix did not work.

gerritbot added a comment.Apr 13 2021, 1:06 PM

Change 677609 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: use explicit begin

https://gerrit.wikimedia.org/r/677609

Maintenance_bot removed a project: Patch-For-Review.Apr 13 2021, 1:11 PM
ReleaseTaggerBot added a project: MW-1.37-notes (1.37.0-wmf.3; 2021-04-27).Apr 13 2021, 2:00 PM
Krinkle moved this task from Untriaged to Mar 2021 on the Wikimedia-production-error board.Apr 14 2021, 6:55 PM
MBinder_WMF added a project: Growth-Team-Filtering.Apr 15 2021, 6:47 PM
• Rileych removed a project: Growth-Team-Filtering.Apr 20 2021, 4:43 PM
Etonkovidova moved this task from QA to Test in Production | Watching on the Growth-Team (Sprint 0 (Growth Team)) board.Apr 27 2021, 12:40 AM
Etonkovidova closed this task as Resolved.Apr 30 2021, 10:05 PM

Checked in wmf.3 - the error is not present.

Urbanecm_WMF added a project: GrowthExperiments-NewcomerTasks.Jan 21 2026, 2:39 PM
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL · Credits