Page MenuHomePhabricator
Create Task
Maniphest T277738

Add missing keyboard navigation events to popover component
Closed, ResolvedPublic5 Estimated Story Points
Actions

Description

Users should be able to dismiss popovers using their keyboard by performing any of the following actions:

  • pressing enteragain, in case the element that triggered the popover is still focused
  • pressing esc, while the popover is open
  • pressing tab to remove the focus from the trigger element and place it on the next focusable element on the page.

ACS:

  • Users are able to not only enable, but also dismiss the popover using their keyboard.

Related Objects

Event Timeline

Sarai-WMDE created this task.Mar 18 2021, 9:44 AM
Restricted Application added a project: Wikidata. · View Herald TranscriptMar 18 2021, 9:44 AM
Restricted Application added a subscriber: Aklapper. · View Herald Transcript
Sarai-WMDE mentioned this in T275542: (MS 6) using the tooltip component in the QB.Mar 30 2021, 9:15 AM
Sarai-WMDE updated the task description. (Show Details)Apr 15 2021, 11:11 AM
• Tonina_Zhelyazkova_WMDE mentioned this in T280159: Release WiKit (Wikidata/Wikibase Design System) version 2.0.0.Apr 19 2021, 5:18 PM
Addshore added a project: [DEPRECATED] wdwb-tech.May 11 2021, 8:27 AM
Addshore moved this task from Inbox to To Prioritize on the [DEPRECATED] wdwb-tech board.
Sarai-WMDE updated the task description. (Show Details)May 11 2021, 12:48 PM
Sarai-WMDE moved this task from Incoming to Ongoing on the Wikidata Design System board.May 17 2021, 2:20 PM
Sarai-WMDE moved this task from Ongoing to Prioritized on the Wikidata Design System board.
Sarai-WMDE moved this task from Prioritized to Waiting for Story time on the Wikidata Design System board.May 17 2021, 2:23 PM
Addshore moved this task from To Prioritize to Triaged Low (0-50) on the [DEPRECATED] wdwb-tech board.May 25 2021, 11:13 AM
Sarai-WMDE added a comment.Jun 21 2021, 3:24 PM

Removing the wdwb-tech tag after realizing that this is rather a user-facing, product task.

Sarai-WMDE removed a project: [DEPRECATED] wdwb-tech.Jun 21 2021, 3:24 PM
Addshore added a project: [DEPRECATED] wdwb-tech.Jun 22 2021, 12:23 PM
Addshore moved this task from Triaged Low (0-50) to Product Realm on the [DEPRECATED] wdwb-tech board.
Addshore subscribed.
In T277738#7166321, @Sarai-WMDE wrote:

Removing the wdwb-tech tag after realizing that this is rather a user-facing, product task.

Added it back, but moved to "product realm" and I'll remove it from our tech prio backlog for that reason too

Sarai-WMDE updated the task description. (Show Details)Jun 23 2021, 10:14 AM
Sarai-WMDE added a project: Wikidata-Campsite.Jun 23 2021, 10:37 AM
Addshore set the point value for this task to 5.Jun 23 2021, 10:50 AM
Sarai-WMDE moved this task from Incoming to Unconnected Stories on the Wikidata-Campsite board.Jun 23 2021, 10:51 AM
Addshore edited projects, added Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)); removed Wikidata-Campsite.Jun 23 2021, 11:02 AM
Lucas_Werkmeister_WMDE mentioned this in T277762: The dropdown should not be activated when toggling the tooltip via enter.Jun 25 2021, 11:19 AM
Addshore added a project: wikidata-campsite-a-b-split.Jun 28 2021, 1:13 PM
Addshore moved this task from Backlog to Unused... on the wikidata-campsite-a-b-split board.Jun 28 2021, 1:19 PM
Addshore moved this task from Unused... to Team A driven on the wikidata-campsite-a-b-split board.
• Tonina_Zhelyazkova_WMDE moved this task from Waiting for Story time to Ongoing on the Wikidata Design System board.Jun 29 2021, 8:50 AM
Ladsgroup claimed this task.Jul 1 2021, 11:27 AM
Ladsgroup moved this task from To Do (prioritised from top to bottom) to Doing on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.
Restricted Application added a project: User-Ladsgroup. · View Herald TranscriptJul 1 2021, 11:27 AM
Maintenance_bot moved this task from incoming to in progress on the Wikidata board.Jul 1 2021, 12:15 PM
Maintenance_bot moved this task from Incoming to In progress on the User-Ladsgroup board.
Ladsgroup moved this task from Doing to Peer Review on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 1 2021, 1:49 PM

https://github.com/wmde/wikit/pull/440

Lucas_Werkmeister_WMDE subscribed.Jul 1 2021, 2:15 PM

What about pressing Space? That key also toggles buttons, and at least in the storybook, it opens the popover, but with the current version of the pull request it doesn’t close it again.

Sarai-WMDE added a comment.Jul 1 2021, 2:30 PM

Agh! My bad, I overlooked that. So pressing space, like with enter, should dismiss the popover when the focus is still on its trigger.

Ladsgroup moved this task from Peer Review to Test (Verification) on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 1 2021, 4:45 PM
Sarai-WMDE closed this task as Resolved.Jul 7 2021, 10:33 AM
Maintenance_bot moved this task from Test (Verification) to Done on the Wikidata-Campsite (Wikidata-Campsite-Iteration-∞ (On Hold)) board.Jul 7 2021, 11:16 AM
Maintenance_bot moved this task from In progress to Done on the User-Ladsgroup board.
Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL