Page MenuHomePhabricator

Remove the cookie hack for testing the reply tool
Closed, ResolvedPublic

Description

Now that it's available as a beta feature (almost) everywhere, we should remove the cookie hack we used for testing the reply tool.

For user who had enabled it, we should enable the beta feature instead, so that the tool doesn't disappear for them when we remove that, and so that they can easily disable it if they wish (https://www.mediawiki.org/wiki/Topic:W5dip3pxqfudyutx).

Event Timeline

matmarex renamed this task from Remove the cookie hack for testing thr reply tool to Remove the cookie hack for testing the reply tool.Mar 18 2021, 5:29 PM
matmarex claimed this task.
matmarex updated the task description. (Show Details)

Change 672833 had a related patch set uploaded (by Bartosz Dziewoński; owner: Bartosz Dziewoński):
[mediawiki/extensions/DiscussionTools@master] Migrate cookie hack users to beta feature

https://gerrit.wikimedia.org/r/672833

Does the cookie hack also enable sub-features that are marked as "unavailable" on a specific wiki (none at the moment, but could happen again when we deploy new features)?

Yes, but I think we should only use the URL hack ?dtenable=1 for this.

If we really want to allow users to use "unavailable" features in the long term, then I think we should allow doing it with hidden preferences.

Change 679415 had a related patch set uploaded (by Bartosz Dziewoński; author: Bartosz Dziewoński):

[mediawiki/extensions/DiscussionTools@master] Remove cookie hack for loading unavailable tools

https://gerrit.wikimedia.org/r/679415

Another bug report from a user unable to turn off DiscussionTools: https://www.mediawiki.org/wiki/Topic:W72yk2ke0yt2nfxn

Change 672833 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Migrate cookie hack users to beta feature

https://gerrit.wikimedia.org/r/672833

Change 679415 merged by jenkins-bot:

[mediawiki/extensions/DiscussionTools@master] Remove cookie hack for loading unavailable tools

https://gerrit.wikimedia.org/r/679415