Page MenuHomePhabricator

Argument 5 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggester::__construct() must be of the type array, null given
Closed, ResolvedPublic

Description

This shows up in the journal logs for refreshLinkRecommendations.php quite a bit. Presumably a missing task config page, but given our scaling plans, it needs to be handled more gracefully.

Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: [6ee0cbbeb68586d5457c66de] [no req]   TypeError: Argument 5 passed to GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggester::__construct() must be of the type array, null given, called in /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/LocalSearchTaskSuggesterFactory.php on line 63
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: Backtrace:
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: from /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/LocalSearchTaskSuggester.php(35)
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #0 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/LocalSearchTaskSuggesterFactory.php(63): GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggester->__construct(GrowthExperiments\NewcomerTasks\TaskType\TaskTypeHandlerRegistry, SearchEngineFactory, GrowthExperiments\NewcomerTasks\TaskSuggester\SearchStrategy\SearchStrategy, MediaWiki\Cache\LinkBatchFactory, NULL, array)
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #1 /srv/mediawiki/php-master/extensions/GrowthExperiments/includes/NewcomerTasks/TaskSuggester/DecoratingTaskSuggesterFactory.php(43): GrowthExperiments\NewcomerTasks\TaskSuggester\LocalSearchTaskSuggesterFactory->create()
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #2 /srv/mediawiki/php-master/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(222): GrowthExperiments\NewcomerTasks\TaskSuggester\DecoratingTaskSuggesterFactory->create()
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #3 /srv/mediawiki/php-master/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(118): GrowthExperiments\Maintenance\RefreshLinkRecommendations->initServices()
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #4 /srv/mediawiki/php-master/maintenance/doMaintenance.php(112): GrowthExperiments\Maintenance\RefreshLinkRecommendations->execute()
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #5 /srv/mediawiki/php-master/extensions/GrowthExperiments/maintenance/refreshLinkRecommendations.php(489): require_once(string)
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #6 /srv/mediawiki/multiversion/MWScript.php(101): require_once(string)
Mar 18 18:33:20 deployment-mwmaint01 mediawiki_job_growthexperiments-refreshLinkRecommendations[8835]: #7 {main}

Event Timeline

Change 673355 had a related patch set uploaded (by Gergő Tisza; owner: Gergő Tisza):
[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: Don't init tasks when disabled

https://gerrit.wikimedia.org/r/673355

Change 673355 merged by jenkins-bot:
[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: Don't init tasks when disabled

https://gerrit.wikimedia.org/r/673355

Checked in wmf.37 - https://logstash.wikimedia.org/goto/53cbb5f330dc467e276a2c2157b9d147 (the link should show the view filtered for the error) - shows total count of 24 on frwikitionary wmf.37.

@Tgr - does it need more work since the errors are still present?

Yeah, the fix clearly didn't work.

Change 677319 had a related patch set uploaded (by Gergő Tisza; author: Gergő Tisza):

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: fix missing config page error

https://gerrit.wikimedia.org/r/677319

Change 677319 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] refreshLinkRecommendations.php: fix missing config page error

https://gerrit.wikimedia.org/r/677319

Checked wmf.1 - the error is not present anymore.