Page MenuHomePhabricator

Transition callers of deprecated User::setOption()
Closed, ResolvedPublic

Description

User::setOption() is soft deprecated and should not be used anymore. It needs to be replaced in the following repositories. User::setOption() should be replaced with UserOptionsManager::setOption().

WMF deployed

  • mediawiki/core
  • mediawiki/extensions/Wikibase
  • mediawiki/extensions/GrowthExperiments
  • mediawiki/extensions/ORES
  • mediawiki/extensions/Echo
  • mediawiki/extensions/TranslationNotifications
  • mediawiki/extensions/CirrusSearch
  • mediawiki/extensions/GlobalPreferences
  • mediawiki/extensions/Translate
  • mediawiki/extensions/BetaFeatures
  • mediawiki/extensions/Flow
  • mediawiki/extensions/Popups
  • mediawiki/extensions/TwoColConflict
  • mediawiki/extensions/UniversalLanguageSelector
  • mediawiki/extensions/VisualEditor
  • mediawiki/extensions/AdvancedSearch
  • mediawiki/extensions/CentralAuth
  • mediawiki/extensions/EntitySchema
  • mediawiki/extensions/FileImporter
  • mediawiki/extensions/GettingStarted
  • mediawiki/extensions/LdapAuthentication
  • mediawiki/extensions/LoginNotify
  • mediawiki/extensions/Math
  • mediawiki/extensions/PageTriage
  • mediawiki/extensions/Thanks
  • mediawiki/extensions/UserMerge
  • mediawiki/extensions/WikimediaIncubator
  • mediawiki/extensions/WikimediaMaintenance
  • mediawiki/extensions/WikimediaMessages
  • mediawiki/skins/Vector

not WMF deployed

  • mediawiki/extensions/BlueSpiceAvatars
  • mediawiki/extensions/GoogleAuthenticator
  • mediawiki/extensions/OpenID
  • mediawiki/extensions/ArticleFeedbackv5
  • mediawiki/extensions/Auth_remoteuser
  • mediawiki/extensions/BlueSpiceFoundation
  • mediawiki/extensions/BlueSpiceReadConfirmation
  • mediawiki/extensions/CategoryTagSorter
  • mediawiki/extensions/CollapsibleVector
  • mediawiki/extensions/CookieWarning
  • mediawiki/extensions/DumpHTML
  • mediawiki/extensions/InviteSignup
  • mediawiki/extensions/LanguageSelector
  • mediawiki/extensions/LDAPUserInfo
  • mediawiki/extensions/MathSearch
  • mediawiki/extensions/OnlineStatus
  • mediawiki/extensions/SiteSettings
  • mediawiki/extensions/SocialProfile
  • mediawiki/extensions/StickToThatLanguage
  • mediawiki/extensions/WikiLexicalData

Details

ProjectBranchLines +/-Subject
mediawiki/extensions/OpenIDmaster+29 -12
mediawiki/extensions/GoogleAuthenticatormaster+53 -26
mediawiki/extensions/CategoryTagSortermaster+18 -16
mediawiki/coremaster+85 -27
mediawiki/extensions/LdapAuthenticationmaster+3 -2
mediawiki/extensions/WikimediaIncubatormaster+14 -5
mediawiki/extensions/LanguageSelectormaster+6 -4
mediawiki/extensions/BetaFeaturesmaster+9 -5
mediawiki/extensions/InviteSignupmaster+9 -5
mediawiki/extensions/GettingStartedmaster+11 -8
mediawiki/extensions/WikimediaMaintenancemaster+16 -9
mediawiki/extensions/TranslationNotificationsmaster+81 -30
mediawiki/extensions/UniversalLanguageSelectormaster+30 -4
mediawiki/extensions/CirrusSearchmaster+3 -3
mediawiki/extensions/AdvancedSearchmaster+6 -4
mediawiki/extensions/EntitySchemamaster+5 -12
mediawiki/extensions/GlobalPreferencesmaster+12 -7
mediawiki/extensions/SocialProfilemaster+8 -7
mediawiki/extensions/GrowthExperimentsmaster+6 -3
mediawiki/extensions/GrowthExperimentsmaster+3 -2
mediawiki/extensions/GrowthExperimentsmaster+72 -43
mediawiki/skins/Vectormaster+26 -10
mediawiki/extensions/Wikibasemaster+43 -14
mediawiki/extensions/Echomaster+72 -11
mediawiki/coremaster+50 -41
mediawiki/extensions/TwoColConflictmaster+7 -4
mediawiki/extensions/EntitySchemamaster+12 -3
mediawiki/extensions/Popupsmaster+24 -7
mediawiki/extensions/CentralAuthmaster+15 -12
mediawiki/extensions/CookieWarningmaster+3 -2
mediawiki/extensions/DumpHTMLmaster+10 -2
mediawiki/extensions/Translatemaster+32 -10
mediawiki/extensions/LDAPUserInfomaster+9 -1
mediawiki/extensions/WikimediaMessagesmaster+3 -9
mediawiki/extensions/BlueSpiceFoundationmaster+6 -1
mediawiki/extensions/ORESmaster+47 -38
mediawiki/extensions/MathSearchmaster+13 -2
mediawiki/extensions/WikiLexicalDatamaster+21 -6
mediawiki/extensions/BlueSpiceAvatarsmaster+8 -5
mediawiki/extensions/PageTriagemaster+3 -2
mediawiki/extensions/FileImportermaster+13 -2
mediawiki/extensions/Flowmaster+7 -4
mediawiki/extensions/OnlineStatusmaster+46 -11
mediawiki/extensions/SiteSettingsmaster+18 -5
mediawiki/extensions/StickToThatLanguagemaster+13 -2
mediawiki/extensions/UserMergemaster+5 -2
mediawiki/extensions/Auth_remoteusermaster+10 -2
mediawiki/extensions/LoginNotifymaster+3 -2
mediawiki/extensions/BlueSpiceReadConfirmationmaster+6 -4
mediawiki/extensions/Thanksmaster+3 -2
mediawiki/extensions/Mathmaster+3 -1
mediawiki/extensions/VisualEditormaster+14 -10
mediawiki/extensions/CollapsibleVectormaster+4 -2
mediawiki/extensions/ArticleFeedbackv5master+20 -3
Show related patches Customize query in gerrit

Event Timeline

There are a very large number of changes, so older changes are hidden. Show Older Changes

Change 684030 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/extensions/Popups@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684030

Change 684031 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/extensions/SocialProfile@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684031

Change 684035 had a related patch set uploaded (by Anjali041; author: Anjali041):

[mediawiki/extensions/TwoColConflict@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684035

Change 675997 merged by jenkins-bot:

[mediawiki/extensions/CentralAuth@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/675997

Change 697941 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/Wikibase@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/697941

Change 684030 merged by jenkins-bot:

[mediawiki/extensions/Popups@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684030

Change 698291 had a related patch set uploaded (by DannyS712; author: DannyS712):

[mediawiki/core@master] DefaultPreferencesFactory: inject UserOptionsManager update options calls

https://gerrit.wikimedia.org/r/698291

Change 679733 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/679733

Change 684035 merged by jenkins-bot:

[mediawiki/extensions/TwoColConflict@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684035

Change 698291 merged by jenkins-bot:

[mediawiki/core@master] DefaultPreferencesFactory: inject and use UserOptionsManager

https://gerrit.wikimedia.org/r/698291

Change 675920 merged by jenkins-bot:

[mediawiki/extensions/Echo@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/675920

Change 697941 merged by jenkins-bot:

[mediawiki/extensions/Wikibase@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/697941

Change 705177 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/705177

Change 675915 merged by jenkins-bot:

[mediawiki/skins/Vector@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/675915

Change 705177 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/705177

Krinkle renamed this task from Avoid using User::setOption() to Transition callers to User::setOption().Jul 27 2021, 12:24 AM
Krinkle renamed this task from Transition callers to User::setOption() to Transition callers of deprecated User::setOption().

Change 709470 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/709470

Change 709476 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/TranslationNotifications@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/709476

Change 709506 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/709506

Change 709506 abandoned by Gergő Tisza:

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

Reason:

https://gerrit.wikimedia.org/r/c/mediawiki/extensions/GrowthExperiments/+/709470 was uploaded just a few hours before this patch.

https://gerrit.wikimedia.org/r/709506

Change 709470 merged by jenkins-bot:

[mediawiki/extensions/GrowthExperiments@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/709470

Change 684031 merged by jenkins-bot:

[mediawiki/extensions/SocialProfile@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/684031

Change 711738 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/CirrusSearch@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711738

Change 711740 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/AdvancedSearch@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711740

Change 711748 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/UniversalLanguageSelector@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711748

Change 711750 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/EntitySchema@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711750

Change 678632 merged by jenkins-bot:

[mediawiki/extensions/GlobalPreferences@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/678632

Change 712308 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GettingStarted@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/712308

Change 711750 merged by jenkins-bot:

[mediawiki/extensions/EntitySchema@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711750

Change 712927 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/WikimediaMaintenance@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/712927

Change 711740 merged by jenkins-bot:

[mediawiki/extensions/AdvancedSearch@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711740

Change 712983 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/GoogleAuthenticator@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/712983

Change 712985 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/extensions/OpenID@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/712985

Change 711738 merged by jenkins-bot:

[mediawiki/extensions/CirrusSearch@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711738

Change 711748 merged by jenkins-bot:

[mediawiki/extensions/UniversalLanguageSelector@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/711748

Change 709476 merged by jenkins-bot:

[mediawiki/extensions/TranslationNotifications@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/709476

Change 712927 merged by jenkins-bot:

[mediawiki/extensions/WikimediaMaintenance@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/712927

Change 712308 merged by jenkins-bot:

[mediawiki/extensions/GettingStarted@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/712308

Change 715746 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/InviteSignup@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/715746

Change 716233 had a related patch set uploaded (by Vlad.shapik; author: Vlad.shapik):

[mediawiki/extensions/LanguageSelector@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/716233

Change 676719 merged by jenkins-bot:

[mediawiki/extensions/BetaFeatures@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/676719

Change 715746 merged by jenkins-bot:

[mediawiki/extensions/InviteSignup@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/715746

Change 716233 merged by jenkins-bot:

[mediawiki/extensions/LanguageSelector@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/716233

Change 720319 had a related patch set uploaded (by Zabe; author: Zabe):

[mediawiki/core@master] Hard deprecate User::setOption()

https://gerrit.wikimedia.org/r/720319

Change 676728 merged by jenkins-bot:

[mediawiki/extensions/WikimediaIncubator@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/676728

Change 678979 merged by jenkins-bot:

[mediawiki/extensions/LdapAuthentication@master] Avoid using User::setOption()

https://gerrit.wikimedia.org/r/678979

Change 720319 merged by jenkins-bot:

[mediawiki/core@master] Hard deprecate User::setOption()

https://gerrit.wikimedia.org/r/720319

Change 679729 merged by jenkins-bot:

[mediawiki/extensions/CategoryTagSorter@master] Avoid using User::getOption() and ::setOption()

https://gerrit.wikimedia.org/r/679729

Change 712983 merged by jenkins-bot:

[mediawiki/extensions/GoogleAuthenticator@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/712983

Change 712985 merged by jenkins-bot:

[mediawiki/extensions/OpenID@master] Avoid using User::setOption() and ::getOption()

https://gerrit.wikimedia.org/r/712985

Zabe updated Other Assignee, added: Zabe.
Zabe removed a project: Patch-For-Review.
Zabe updated the task description. (Show Details)
Zabe updated Other Assignee, removed: Zabe.