Page MenuHomePhabricator

Migrate the rest of the maintenance scripts to subclass maintenance
Open, MediumPublic

Description

dumpBackup is one of them.

Details

Reference
bz25782

Event Timeline

bzimport raised the priority of this task from to Medium.Nov 21 2014, 11:23 PM
bzimport set Reference to bz25782.
bzimport added a subscriber: Unknown Object (MLST).
Reedy created this task.Nov 4 2010, 11:13 AM
Reedy added a comment.Nov 4 2010, 11:28 AM

dumpTextPass
eval (still needs it)
fuzz-tester
importDump
importImages
importTextFiles
mcc
preprocessorFuzzTest
userOptions

Reedy added a comment.Nov 4 2010, 11:33 AM

archives
-upgradeLogging

gearman
-gearmanWorker
-gearmanRefreshLinks

language
-checkDupeMessages
-checkExtensions
-checkLanguage
-rebuildLanguage
-transstat

storage
-checkStorage
-compressOld
-moveToExternal
-recompressTracked
-resolveStubs
-testCompression
-trackBlobs

tests
-parsertests

phpunit
-phpunit

I think this is done now, right, Reedy?

Reedy added a comment.Feb 9 2011, 8:01 AM

Afaik, nope

Krinkle updated the task description. (Show Details)Dec 10 2014, 2:09 PM
Krinkle added a project: Technical-Debt.
Krinkle set Security to None.
Krinkle removed a subscriber: Unknown Object (MLST).
lcawte added a subscriber: lcawte.Dec 11 2014, 7:08 PM

So it appears all of the maintenance/ directory scripts listed here have yet to be done with the exception of importDump.php. I didn't check the subdirectories but I imagine there has been less attention given to those. Would it be worth creating subtasks for all of these?

demon added a comment.Dec 11 2014, 7:53 PM

So it appears all of the maintenance/ directory scripts listed here have yet to be done with the exception of importDump.php. I didn't check the subdirectories but I imagine there has been less attention given to those. Would it be worth creating subtasks for all of these?

If you could make a list of all maintenance scripts not using Maintenance (in subdirectories too) that'd be great. I think then we'd know if it's worth splitting into individual tasks.

In T27782#842538, @Chad wrote:

If you could make a list of all maintenance scripts not using Maintenance (in subdirectories too) that'd be great. I think then we'd know if it's worth splitting into individual tasks.

1[km@km-tp maintenance]$ ack "commandLine.inc"
2preprocessorFuzzTest.php
324:require_once __DIR__ . '/commandLine.inc';
4
5language/checkExtensions.php
624:require_once __DIR__ . '/../commandLine.inc';
7
8language/transstat.php
931:require_once __DIR__ . '/../commandLine.inc';
10
11language/checkDupeMessages.php
1224:require_once __DIR__ . '/../commandLine.inc';
13
14language/checkLanguage.php
1524:require_once __DIR__ . '/../commandLine.inc';
16
17cdb.php
1828:require_once __DIR__ . '/commandLine.inc';
19
20userOptions.inc
2128:require_once __DIR__ . '/commandLine.inc';
22
23importImages.php
2439:require_once __DIR__ . '/commandLine.inc';
25
26doMaintenance.php
2735:// If a class is using commandLine.inc (old school maintenance), they definitely
28
29eval.php
3036:require_once __DIR__ . "/commandLine.inc";
31
32storage/recompressTracked.php
3326:require __DIR__ . '/../commandLine.inc';
34
35storage/trackBlobs.php
3625:require __DIR__ . '/../commandLine.inc';
37
38storage/moveToExternal.php
3927: require_once __DIR__ . '/../commandLine.inc';
40
41storage/resolveStubs.php
4230: require_once __DIR__ . '/../commandLine.inc';
43
44storage/checkStorage.php
4525: require_once __DIR__ . '/../commandLine.inc';
46
47storage/testCompression.php
4825:require __DIR__ . '/../commandLine.inc';
49
50dumpBackup.php
5132:require_once __DIR__ . '/commandLine.inc';
52
53archives/upgradeLogging.php
5424:require __DIR__ . '/../commandLine.inc';
55
56mcc.php
5726:require_once __DIR__ . '/commandLine.inc';
58
59dumpTextPass.php
6029:require_once __DIR__ . '/commandLine.inc';

demon added a comment.Dec 11 2014, 9:24 PM

The only one that has to be not-Maintenance is eval.php. Rest just need some love :)

demon removed a subscriber: demon.Aug 19 2015, 4:41 PM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptAug 19 2015, 4:41 PM