| ifried | |
| Mar 18 2021, 10:41 PM |
| F34210424: Screen Shot 2021-04-01 at 6.41.23 PM.png | |
| Apr 1 2021, 10:42 PM |
| F34199286: ws_export_tweaks.png | |
| Mar 31 2021, 1:57 PM |
| F34171015: Implementation v1 - Annotated.jpg | |
| Mar 18 2021, 10:56 PM |
Acceptance Criteria:
Visual Details:
The first parts of this are ready for review: https://github.com/wikimedia/ws-export/pull/349
Still to come:
PR 349 is merged and live on the test site now.
Does anyone have a better phrase for "Title of the book's main page."?
@Samwilson What would be downloaded other than a full book again? Would it be a section or particular volume of a book, like if a book has many parts? If so, maybe something like "Title of the book or section" or something along those lines?
Also pinging @SGill & @nayoub for feedback: What language do you think would be more clear & accurate for users? Thanks in advance!
@Samwilson the tweaks look great!
I agree with you @ifried. If there's the possibility, as you mentioned Sam, for a user to export the entire book or a specific part of it, then it would be good to have " Title of the book or section to export". What do you think @SGill?
Patch for fixing the alignment of the back link: https://github.com/wikimedia/ws-export/pull/353
Last thing here is the title help text. PR: https://github.com/wikimedia/ws-export/pull/358
I was wrong: last thing is the form width; will get that done now.
The title help text is merged.
We need to reduce the font size of "Options" to make it consistent with the other labels (e.g. "Wikisource", "Title", "File Format", ...).
Would it also be possible to vertically center the "Back to Wikisource" button label to the arrow, if time allows?
The form width and label sizes are done in https://github.com/wikimedia/ws-export/pull/359 (ready for review).
I'm having some trouble with the vertical alignment of the arrow in 'Back to Wikisource', because it's already centred according to the font baseline, which isn't very apparent in English but can be seen in languages with more decenders. I've set it to be centred according to the 20px line-height, but I'm not 100% sure if that's super correct.
- Implement the visual tweaks as shared below
- Maybe change "Title of book's main page" to "Title of the book or section to export"
Yep.
- We need to reduce the font size of "Options" to make it consistent with the other labels (e.g. "Wikisource", "Title", "File Format", ...).
Yep, they are all 14px font size.
This is now on production. I can see the changes, such as the removal of the colons (see screenshot example below). I'm marking this as Done.
