Page MenuHomePhabricator
Create Task
Maniphest T277833

Duplicate protocol in links if $wgServer specifies a protocol
Closed, ResolvedPublic
Actions

Description

In at least one place (src/js/modal.js#L1054), Convenient Discussions prepends "https:" to the value of $wgServer.

However, if $wgServer specifies a URL with a protocol (e.g. https://en.wikipedia.org), the URL that Convenient Discussions obtains will start with https:https://en.wikipedia.org.

Convenient Discussions should probably check whether $wgServer is a protocol-relative or a protocol-absolute URL, and prepend "https:" accordingly.

Event Timeline

Alanhuang122 created this task.Mar 19 2021, 4:34 AM
Jack_who_built_the_house subscribed.Apr 4 2021, 10:00 PM
Jack_who_built_the_house closed this task as Resolved.Jun 6 2022, 12:32 AM
Jack_who_built_the_house claimed this task.

Thanks.

Convenient Discussions should probably check whether $wgServer is a protocol-relative or a protocol-absolute URL, and prepend "https:" accordingly.

This is currently done in https://github.com/jwbth/convenient-discussions/blob/1c4beeefd9f97f1ec6b1fbd00b918966eeca7f44/src/js/app.js#L299.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL