Page MenuHomePhabricator
Create Task
Maniphest T277838

Instant disable audio when selected the option
Closed, ResolvedPublic
Actions

Description

When selected the disable audio option in the settings, we need to have instant change in the settings of the player to disable audio.

Resources:

Details

SubjectRepoBranchLines +/-
Implemented instant disableAudiolabs/tools/VideoCutToolmaster+80 -79
Customize query in gerrit

Related Objects

Event Timeline

Gopavasanth created this task.Mar 19 2021, 7:45 AM
Restricted Application added a subscriber: Aklapper. · View Herald TranscriptMar 19 2021, 7:45 AM
Sandyabhi subscribed.Mar 19 2021, 12:15 PM

Hi @Gopavasanth , Remove audio is working , I just removed the audio and downloaded it.

Gopavasanth added a comment.Mar 19 2021, 12:36 PM

Hey @Sandyabhi, So this ticket is to Instantly mute the sound in the player after selecting the feature in the edit section. when tapped on undo it should enable the sound again. Is this clear now?

Sandyabhi added a comment.Mar 19 2021, 1:11 PM

Yes @Gopavasanth , I understand the issue.

Hacktovist subscribed.Mar 19 2021, 4:53 PM
Gopavasanth updated the task description. (Show Details)Mar 20 2021, 11:40 AM
gerritbot added a comment.Mar 20 2021, 2:15 PM

Change 673702 had a related patch set uploaded (by Sandyabhi; owner: Sandyabhi):
[labs/tools/VideoCutTool@master] Fixed disableAudio

https://gerrit.wikimedia.org/r/673702

gerritbot added a project: Patch-For-Review.Mar 20 2021, 2:15 PM
gerritbot added a comment.Mar 20 2021, 4:41 PM

Change 673702 merged by jenkins-bot:
[labs/tools/VideoCutTool@master] Implemented instant disableAudio

https://gerrit.wikimedia.org/r/673702

Gopavasanth mentioned this in rLTVT03b0c5acd568: Implemented instant disableAudio.Mar 20 2021, 4:41 PM
Gopavasanth closed this task as Resolved.Mar 20 2021, 4:46 PM
Gopavasanth claimed this task.
Gopavasanth reassigned this task from Gopavasanth to Sandyabhi.
Maintenance_bot removed a project: Patch-For-Review.Mar 20 2021, 5:11 PM
Hacktovist added a comment.Mar 22 2021, 6:09 PM

Can anyone help to setup the Oauth. I followed the setup guide, but it's so confusing

Gopavasanth added a comment.EditedMar 23 2021, 4:31 AM

Hey @Hacktovist! You need not setup the OAuth. You can point to the back-end servers in your env.js to make things work.

Content licensed under Creative Commons Attribution-ShareAlike (CC BY-SA) 4.0 unless otherwise noted; code licensed under GNU General Public License (GPL) 2.0 or later and other open source licenses. By using this site, you agree to the Terms of Use, Privacy Policy, and Code of Conduct. · Wikimedia Foundation · Privacy Policy · Code of Conduct · Terms of Use · Disclaimer · CC-BY-SA · GPL